From: Tanu Kaskinen <tanuk@iki.fi>
To: Khem Raj <raj.khem@gmail.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 3/3] pulseaudio: disable WebRTC code
Date: Wed, 20 Jul 2016 04:18:54 +0300 [thread overview]
Message-ID: <1468977534.3210.168.camel@iki.fi> (raw)
In-Reply-To: <CAMKF1sr8p21xDXNMScg8MUdRFh3=8O+zuxL--_A-jV52Dez1wQ@mail.gmail.com>
On Tue, 2016-07-19 at 17:54 -0700, Khem Raj wrote:
> On Tue, Jul 19, 2016 at 5:20 PM, Tanu Kaskinen <tanuk@iki.fi> wrote:
> > When updating pulseaudio to 9.0, I noticed webrtc-audio-processing is
> > a potential floating dependency. It's not an issue right now, because
> > webrtc-audio-processing isn't packaged for OpenEmbedded, but it would
> > become an issue if anyone added the library to OE.
> >
> > Signed-off-by: Tanu Kaskinen <tanuk@iki.fi>
> > ---
> > meta/recipes-multimedia/pulseaudio/pulseaudio.inc | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> > index accafe1..2cf3fb4 100644
> > --- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> > +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> > @@ -37,6 +37,10 @@ EXTRA_OECONF = "\
> > # oe-core nor meta-oe, so let's not add a PACKAGECONFIG entry for it for now.
> > EXTRA_OECONF += "--without-soxr"
> >
> > +# The WebRTC echo canceller depends on the webrtc-audio-processing library,
> > +# which is not yet packaged for OpenEmbedded.
> > +EXTRA_OECONF += "--disable-webrtc-aec"
> > +
>
> may be turn it into a packageconfig ?
Ok, I can do that. I felt uncomfortable adding a packageconfig for
this, because I'd have to reference a non-existing recipe, and who
knows what the recipe will actually be named when it gets packaged, but
I suppose a potential naming mismatch isn't a big risk.
--
Tanu
next prev parent reply other threads:[~2016-07-20 1:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 0:20 [PATCH 0/3] Audio recipe updates Tanu Kaskinen
2016-07-20 0:20 ` [PATCH 1/3] libsndfile1: 1.0.26 -> 1.0.27 Tanu Kaskinen
2016-07-20 0:20 ` [PATCH 2/3] pulseaudio: 8.0 -> 9.0 Tanu Kaskinen
2016-07-20 0:20 ` [PATCH 3/3] pulseaudio: disable WebRTC code Tanu Kaskinen
2016-07-20 0:54 ` Khem Raj
2016-07-20 1:18 ` Tanu Kaskinen [this message]
2016-07-20 22:14 ` Tanu Kaskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468977534.3210.168.camel@iki.fi \
--to=tanuk@iki.fi \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox