Re: [PATCH 3/3] pulseaudio: disable WebRTC code

[Tanu Kaskinen <tanuk@iki.fi>]

On Wed, 2016-07-20 at 04:18 +0300, Tanu Kaskinen wrote:
> On Tue, 2016-07-19 at 17:54 -0700, Khem Raj wrote:
> > On Tue, Jul 19, 2016 at 5:20 PM, Tanu Kaskinen <tanuk@iki.fi> wrote:
> > > When updating pulseaudio to 9.0, I noticed webrtc-audio-processing is
> > > a potential floating dependency. It's not an issue right now, because
> > > webrtc-audio-processing isn't packaged for OpenEmbedded, but it would
> > > become an issue if anyone added the library to OE.
> > > 
> > > Signed-off-by: Tanu Kaskinen <tanuk@iki.fi>
> > > ---
> > >  meta/recipes-multimedia/pulseaudio/pulseaudio.inc | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> > > index accafe1..2cf3fb4 100644
> > > --- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> > > +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> > > @@ -37,6 +37,10 @@ EXTRA_OECONF = "\
> > >  # oe-core nor meta-oe, so let's not add a PACKAGECONFIG entry for it for now.
> > >  EXTRA_OECONF += "--without-soxr"
> > > 
> > > +# The WebRTC echo canceller depends on the webrtc-audio-processing library,
> > > +# which is not yet packaged for OpenEmbedded.
> > > +EXTRA_OECONF += "--disable-webrtc-aec"
> > > +
> > 
> > may be turn it into a packageconfig ?
> 
> Ok, I can do that. I felt uncomfortable adding a packageconfig for
> this, because I'd have to reference a non-existing recipe, and who
> knows what the recipe will actually be named when it gets packaged, but
> I suppose a potential naming mismatch isn't a big risk.

I sent a patch for this now.

Assuming that there are no further comments, please apply the first two
patches of this series and ignore the third one.

-- 
Tanu