[PATCH] gstreamer1.0-plugins-bad: add missing wayland-native dependency

[PATCH] gstreamer1.0-plugins-bad: add missing wayland-native dependency

[Ross Burton]

The wayland support requires wayland-scanner, so add a dependency on
wayland-native.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
index 9e2b94e..d8c8179 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
@@ -58,7 +58,7 @@ PACKAGECONFIG[srtp]            = "--enable-srtp,--disable-srtp,libsrtp"
 PACKAGECONFIG[uvch264]         = "--enable-uvch264,--disable-uvch264,libusb1 libgudev"
 PACKAGECONFIG[voaacenc]        = "--enable-voaacenc,--disable-voaacenc,vo-aacenc"
 PACKAGECONFIG[voamrwbenc]      = "--enable-voamrwbenc,--disable-voamrwbenc,vo-amrwbenc"
-PACKAGECONFIG[wayland]         = "--enable-wayland --enable-egl,--disable-wayland --disable-egl,wayland virtual/egl"
+PACKAGECONFIG[wayland]         = "--enable-wayland --enable-egl,--disable-wayland --disable-egl,wayland-native wayland virtual/egl"
 PACKAGECONFIG[webp]            = "--enable-webp,--disable-webp,libwebp"
 
 # these plugins have not been ported to 1.0 (yet):
-- 
2.8.1

Re: [PATCH] gstreamer1.0-plugins-bad: add missing wayland-native dependency

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1777 bytes --]

On Wed, Jul 27, 2016 at 05:32:57PM +0100, Ross Burton wrote:
> The wayland support requires wayland-scanner, so add a dependency on
> wayland-native.

Why is this needed when wayland already depends on wayland-native?

> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
> index 9e2b94e..d8c8179 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
> @@ -58,7 +58,7 @@ PACKAGECONFIG[srtp]            = "--enable-srtp,--disable-srtp,libsrtp"
>  PACKAGECONFIG[uvch264]         = "--enable-uvch264,--disable-uvch264,libusb1 libgudev"
>  PACKAGECONFIG[voaacenc]        = "--enable-voaacenc,--disable-voaacenc,vo-aacenc"
>  PACKAGECONFIG[voamrwbenc]      = "--enable-voamrwbenc,--disable-voamrwbenc,vo-amrwbenc"
> -PACKAGECONFIG[wayland]         = "--enable-wayland --enable-egl,--disable-wayland --disable-egl,wayland virtual/egl"
> +PACKAGECONFIG[wayland]         = "--enable-wayland --enable-egl,--disable-wayland --disable-egl,wayland-native wayland virtual/egl"
>  PACKAGECONFIG[webp]            = "--enable-webp,--disable-webp,libwebp"
>  
>  # these plugins have not been ported to 1.0 (yet):
> -- 
> 2.8.1
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [PATCH] gstreamer1.0-plugins-bad: add missing wayland-native dependency

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

On 27 July 2016 at 18:07, Martin Jansa <martin.jansa@gmail.com> wrote:

> On Wed, Jul 27, 2016 at 05:32:57PM +0100, Ross Burton wrote:
> > The wayland support requires wayland-scanner, so add a dependency on
> > wayland-native.
>
> Why is this needed when wayland already depends on wayland-native?
>

Because builds from sstate won't pull in all the build dependencies
transitively, just enough to do the required tasks. The requirements are
the wayland runtime libraries (wayland) and the native tooling
(wayland-native).

Ross

[-- Attachment #2: Type: text/html, Size: 923 bytes --]

Re: [PATCH] gstreamer1.0-plugins-bad: add missing wayland-native dependency

[Khem Raj]

[-- Attachment #1.1: Type: text/plain, Size: 1203 bytes --]


> On Jul 27, 2016, at 12:51 PM, Burton, Ross <ross.burton@intel.com> wrote:
> 
> 
> On 27 July 2016 at 18:07, Martin Jansa <martin.jansa@gmail.com <mailto:martin.jansa@gmail.com>> wrote:
> On Wed, Jul 27, 2016 at 05:32:57PM +0100, Ross Burton wrote:
> > The wayland support requires wayland-scanner, so add a dependency on
> > wayland-native.
> 
> Why is this needed when wayland already depends on wayland-native?
> 
> Because builds from sstate won't pull in all the build dependencies transitively, just enough to do the required tasks. The requirements are the wayland runtime libraries (wayland) and the native tooling (waylaid-native).

Is it so that populate_sysroot tasks wont do the above two jobs ? if yes then why
If you are saying that behavior is different with or without sstate reuse if  I do
bitbake gstreamer1.0-plugins-bad, then I think there is a problem.  The entries changed here will
get added to DEPENDS in the end. So Martin has a point.

> 
> Ross
> 
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


[-- Attachment #1.2: Type: text/html, Size: 2470 bytes --]

[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

Re: [PATCH] gstreamer1.0-plugins-bad: add missing wayland-native dependency

[Richard Purdie]

On Wed, 2016-07-27 at 18:40 -0700, Khem Raj wrote:
> 
> > On Jul 27, 2016, at 12:51 PM, Burton, Ross <ross.burton@intel.com>
> > wrote:
> > Why is this needed when wayland already depends on wayland
> > > -native?
> > Because builds from sstate won't pull in all the build dependencies
> > transitively, just enough to do the required tasks. The
> > requirements are the wayland runtime libraries (wayland) and the
> > native tooling (waylaid-native).
> Is it so that populate_sysroot tasks wont do the above two jobs ? if
> yes then why
> If you are saying that behavior is different with or without sstate
> reuse if  I do
> bitbake gstreamer1.0-plugins-bad, then I think there is a problem. 
>  The entries changed here will
> get added to DEPENDS in the end. So Martin has a point.

The way the sstate code is coded, it assumes that if a target recipe X
is available from sstate, any -native/-cross dependencies of that
target are not needed and not installed.

In general this makes sense as quilt-native isn't needed if we aren't
patching, we don't need a compiler/toolchain if we're not compiling and
so on.

What it does mean is that any recipe needing a -native recipe to build 
should list it in DEPENDS directly, not rely on other dependencies to
pull it in for them. This applies to pkgconfig-native, intltool-native
and also to wayland-native.

I'm open to other ideas on how this could work but right now, its the
only way I can see to make sstate use semi-optimal, rather tahn
requiring *everything* come from sstate all the time.

Cheers,

Richard