Re: [oe-commits] [openembedded-core] 05/10: pointercal-xinput: set ALLOW_EMPTY

Re: [oe-commits] [openembedded-core] 05/10: pointercal-xinput: set ALLOW_EMPTY

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1561 bytes --]

NAK

On Thu, Aug 4, 2016 at 9:56 PM, <git@git.openembedded.org> wrote:

> rpurdie pushed a commit to branch master-next
> in repository openembedded-core.
>
> commit 461a01e4f126d5e45ca720e0e8d0e35afb13672c
> Author: Ross Burton <ross.burton@intel.com>
> AuthorDate: Tue Aug 2 21:00:56 2016 +0100
>
>     pointercal-xinput: set ALLOW_EMPTY
>
>     Many BSPs don't have pointer calibration, so set ALLOW_EMPTY so the
> package
>     still exists (for dependencies) even if there isn't a calibration file
> to
>     package.
>
>     Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  meta/recipes-graphics/xinput-calibrator/pointercal-xinput_0.0.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-graphics/xinput-calibrator/pointercal-
> xinput_0.0.bb b/meta/recipes-graphics/xinput-calibrator/pointercal-
> xinput_0.0.bb
> index 65348c3..71756c3 100644
> --- a/meta/recipes-graphics/xinput-calibrator/pointercal-xinput_0.0.bb
> +++ b/meta/recipes-graphics/xinput-calibrator/pointercal-xinput_0.0.bb
> @@ -17,4 +17,5 @@ do_install() {
>  }
>
>  PACKAGE_ARCH = "${MACHINE_ARCH}"
> +ALLOW_EMPTY_${PN} = "1"
>  CONFFILES_${PN} = "${sysconfdir}/pointercal.xinput"
>
> --
> To stop receiving notification emails like this one, please contact
> the administrator of this repository.
> --
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-commits
>

[-- Attachment #2: Type: text/html, Size: 2784 bytes --]

Re: [oe-commits] [openembedded-core] 06/10: tslib: replace pointercal with pointercal-xinput

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1697 bytes --]

Since when tslib reads pointercal-xinput file?

On Thu, Aug 4, 2016 at 9:56 PM, <git@git.openembedded.org> wrote:

> rpurdie pushed a commit to branch master-next
> in repository openembedded-core.
>
> commit a0e1ee6d4990d30f42875a8e47854131b9c8d130
> Author: Maxin B. John <maxin.john@intel.com>
> AuthorDate: Tue Jul 12 17:07:40 2016 +0300
>
>     tslib: replace pointercal with pointercal-xinput
>
>     tslib RRECOMMENDS pointercal. Replace it with pointercal-xinput
>     since we removed pointercal recipe.
>
>     Signed-off-by: Maxin B. John <maxin.john@intel.com>
>     Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  meta/recipes-graphics/tslib/tslib_1.1.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-graphics/tslib/tslib_1.1.bb
> b/meta/recipes-graphics/tslib/tslib_1.1.bb
> index b0264c3..9d3de2e 100644
> --- a/meta/recipes-graphics/tslib/tslib_1.1.bb
> +++ b/meta/recipes-graphics/tslib/tslib_1.1.bb
> @@ -44,7 +44,7 @@ DEBIAN_NOAUTONAME_tslib-tests = "1"
>  DEBIAN_NOAUTONAME_tslib-calibrate = "1"
>
>  RDEPENDS_${PN} = "tslib-conf"
> -RRECOMMENDS_${PN} = "pointercal"
> +RRECOMMENDS_${PN} = "pointercal-xinput"
>
>  FILES_${PN}-dev += "${libdir}/ts/*.la"
>  FILES_tslib-conf = "${sysconfdir}/ts.conf ${sysconfdir}/profile.d/tslib.sh
> ${datadir}/tslib"
>
> --
> To stop receiving notification emails like this one, please contact
> the administrator of this repository.
> --
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-commits
>

[-- Attachment #2: Type: text/html, Size: 2935 bytes --]

Re: [oe-commits] [openembedded-core] 06/10: tslib: replace pointercal with pointercal-xinput

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

On 4 August 2016 at 21:08, Martin Jansa <martin.jansa@gmail.com> wrote:

> Since when tslib reads pointercal-xinput file?
>

That was my comment on the list too, but this series was left in my staging
branch so ended up getting sucked into master.  I propose a revert for this
too.

Ross

[-- Attachment #2: Type: text/html, Size: 697 bytes --]

Re: [oe-commits] [openembedded-core] 06/10: tslib: replace pointercal with pointercal-xinput

[Maxin B. John]

Hi,

On Thu, Aug 04, 2016 at 10:08:29PM +0200, Martin Jansa wrote:
>Since when tslib reads pointercal-xinput file?

This change wasn't tested due to non availability of required hardware. Will revert this
change.

>On Thu, Aug 4, 2016 at 9:56 PM, <git@git.openembedded.org> wrote:
>
>    rpurdie pushed a commit to branch master-next       in repository openembedded-core.

Thanks,
Maxin

Re: [oe-commits] [openembedded-core] 10/10: packagegroup-core-x11-base.bb: replace pointercal with pointercal-xinput

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1842 bytes --]

NAK pointercal-xinput is useless without xinput-calibrator.

Just remove pointercal and let x11-common pull xinput-calibrator with
pointercal-xinupt by RRECOMMENDS.

On Thu, Aug 4, 2016 at 9:56 PM, <git@git.openembedded.org> wrote:

> rpurdie pushed a commit to branch master-next
> in repository openembedded-core.
>
> commit 7242599ff64e40d24383dd1852616a8f99416d0d
> Author: Maxin B. John <maxin.john@intel.com>
> AuthorDate: Tue Jul 12 17:07:41 2016 +0300
>
>     packagegroup-core-x11-base.bb: replace pointercal with
> pointercal-xinput
>
>     Replace pointercal with pointercal-xinput since we removed pointercal
> recipe.
>
>     Signed-off-by: Maxin B. John <maxin.john@intel.com>
>     Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  meta/recipes-graphics/packagegroups/packagegroup-core-x11-base.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-graphics/packagegroups/packagegroup-
> core-x11-base.bb b/meta/recipes-graphics/packagegroups/packagegroup-
> core-x11-base.bb
> index db3dfe3..6e8e50d 100644
> --- a/meta/recipes-graphics/packagegroups/packagegroup-core-x11-base.bb
> +++ b/meta/recipes-graphics/packagegroups/packagegroup-core-x11-base.bb
> @@ -10,7 +10,7 @@ RDEPENDS_${PN} = "\
>      packagegroup-core-x11-xserver \
>      packagegroup-core-x11-utils \
>      dbus \
> -    pointercal \
> +    pointercal-xinput \
>      matchbox-terminal \
>      matchbox-wm \
>      mini-x-session \
>
> --
> To stop receiving notification emails like this one, please contact
> the administrator of this repository.
> --
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-commits
>

[-- Attachment #2: Type: text/html, Size: 3224 bytes --]

Re: [oe-commits] [openembedded-core] 10/10: packagegroup-core-x11-base.bb: replace pointercal with pointercal-xinput

[Richard Purdie]

On Thu, 2016-08-04 at 22:10 +0200, Martin Jansa wrote:
> NAK pointercal-xinput is useless without xinput-calibrator.
> 
> Just remove pointercal and let x11-common pull xinput-calibrator with
> pointercal-xinupt by RRECOMMENDS.

FWIW the pointercal commits in -next didn't make it into master
deliberately as we know they need some tweaks. One did get in by
accident, I've reverted it so things continue to build until they're
ready.

Cheers,

Richard

Re: [oe-commits] [openembedded-core] 10/10: packagegroup-core-x11-base.bb: replace pointercal with pointercal-xinput

[Maxin B. John]

Hi Martin,

>On Thu, Aug 04, 2016 at 10:10:07PM +0200, Martin Jansa wrote:
>NAK pointercal-xinput is useless without xinput-calibrator.
>
>Just remove pointercal and let x11-common pull xinput-calibrator with pointercal-xinupt by RRECOMMENDS.

Thank you very much for reviewing it. Will update the patches as per your suggestion.

On Thu, Aug 4, 2016 at 9:56 PM, <git@git.openembedded.org> wrote:
>> rpurdie pushed a commit to branch master-next in repository openembedded-core.
>>
>> commit 7242599ff64e40d24383dd1852616a8f99416d0d
>> Author: Maxin B. John <maxin.john@intel.com>
>> AuthorDate: Tue Jul 12 17:07:41 2016 +0300
>> packagegroup-core-x11-base.bb: replace pointercal with pointercal-xinput

Thanks and Regards,
Maxin