[PATCH 0/2] Fixes for Eclipse Qemu debug

[PATCH 0/2] Fixes for Eclipse Qemu debug

[bavery]

This patch set fixes YOCTO #9362.  The busybox resize utility was running on
ssh connections from Eclipse and causing Eclipse to fail to start gdbserver.
Furthermore, the opensftp server wasn't starting up correctly without the
openssh-server.

Thanks go to Max Krummenacher <max.oss.09@gmail.com> for suggesting a good solution
to the serial/ssh connection issue in basefiles:etc/profile!

-Brian



The following changes since commit dfc016fbf13e62f7767edaf7abadf1d1b72680b2:

  maintainers.inc: remove augeas (2016-08-04 20:56:11 +0100)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib bavery/eclipse-resize-fixup
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=bavery/eclipse-resize-fixup

bavery (2):
  packagegroup-core-eclipse-debug: add openssh server to support
    openssh-sftp-server
  base-files: restrict resize to run on serial consoles only  in profile

                              │·

 recipes-core/base-files/base-files/profile                    | 7 ++++---
 recipes-core/packagegroups/packagegroup-core-eclipse-debug.bb | 1 +
 2 files changed, 5 insertions(+), 3 deletions(-)

--
1.9.1

[PATCH 1/2] packagegroup-core-eclipse-debug: add openssh server to support openssh-sftp-server

[bavery]

The openssh-sftp-server was already part of the pakagegroup. Adding the openssh-server
lets the sftp server start up correctly.

YOCTO #9362

Signed-off-by: bavery <brian.avery@intel.com>
---
 recipes-core/packagegroups/packagegroup-core-eclipse-debug.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/recipes-core/packagegroups/packagegroup-core-eclipse-debug.bb b/recipes-core/packagegroups/packagegroup-core-eclipse-debug.bb
index c45463f..c32fef5 100644
--- a/recipes-core/packagegroups/packagegroup-core-eclipse-debug.bb
+++ b/recipes-core/packagegroups/packagegroup-core-eclipse-debug.bb
@@ -6,4 +6,5 @@ RDEPENDS_${PN} = "\
     gdbserver \
     tcf-agent \
     openssh-sftp-server \
+    openssh \
     "
-- 
1.9.1

Re: [PATCH 1/2] packagegroup-core-eclipse-debug: add openssh server to support openssh-sftp-server

[Jacob Kroon]

On 08/08/2016 05:43 AM, bavery wrote:
> The openssh-sftp-server was already part of the pakagegroup. Adding the openssh-server
> lets the sftp server start up correctly.

If openssh-sftp-server cannot run without openssh, shouldn't it RDEPEND 
on it instead ?

>
> YOCTO #9362
>
> Signed-off-by: bavery <brian.avery@intel.com>
> ---
>  recipes-core/packagegroups/packagegroup-core-eclipse-debug.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/recipes-core/packagegroups/packagegroup-core-eclipse-debug.bb b/recipes-core/packagegroups/packagegroup-core-eclipse-debug.bb
> index c45463f..c32fef5 100644
> --- a/recipes-core/packagegroups/packagegroup-core-eclipse-debug.bb
> +++ b/recipes-core/packagegroups/packagegroup-core-eclipse-debug.bb
> @@ -6,4 +6,5 @@ RDEPENDS_${PN} = "\
>      gdbserver \
>      tcf-agent \
>      openssh-sftp-server \
> +    openssh \
>      "
>

Re: [PATCH 1/2] packagegroup-core-eclipse-debug: add openssh server to support openssh-sftp-server

[Jacob Kroon]

On 08/08/2016 08:27 AM, Jacob Kroon wrote:
> On 08/08/2016 05:43 AM, bavery wrote:
>> The openssh-sftp-server was already part of the pakagegroup. Adding
>> the openssh-server
>> lets the sftp server start up correctly.
>
> If openssh-sftp-server cannot run without openssh, shouldn't it RDEPEND
> on it instead ?
>

Or rather, since there are multiple providers of ssh-server(openssh and 
dropbear that I know of), shouldn't there be a 
PREFERRED_PROVIDER_virtual/ssh-server, that openssh-sftp-server could 
RDEPEND on ?

>>
>> YOCTO #9362
>>
>> Signed-off-by: bavery <brian.avery@intel.com>
>> ---
>>  recipes-core/packagegroups/packagegroup-core-eclipse-debug.bb | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git
>> a/recipes-core/packagegroups/packagegroup-core-eclipse-debug.bb
>> b/recipes-core/packagegroups/packagegroup-core-eclipse-debug.bb
>> index c45463f..c32fef5 100644
>> --- a/recipes-core/packagegroups/packagegroup-core-eclipse-debug.bb
>> +++ b/recipes-core/packagegroups/packagegroup-core-eclipse-debug.bb
>> @@ -6,4 +6,5 @@ RDEPENDS_${PN} = "\
>>      gdbserver \
>>      tcf-agent \
>>      openssh-sftp-server \
>> +    openssh \
>>      "
>>
>

Re: [PATCH 1/2] packagegroup-core-eclipse-debug: add openssh server to support openssh-sftp-server

[Richard Purdie]

On Mon, 2016-08-08 at 08:27 +0200, Jacob Kroon wrote:
> On 08/08/2016 05:43 AM, bavery wrote:
> > The openssh-sftp-server was already part of the pakagegroup. Adding
> > the openssh-server
> > lets the sftp server start up correctly.
> 
> If openssh-sftp-server cannot run without openssh, shouldn't it
> RDEPEND 
> on it instead ?

I suspect you are right and that it needs an RDEPENDS if it doesn't
work without it. It also needs a comment explaining the dependency so
someone doesn't remove it.

Cheers,

Richard

Re: [PATCH 1/2] packagegroup-core-eclipse-debug: add openssh server to support openssh-sftp-server

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 879 bytes --]


> On Aug 8, 2016, at 1:04 AM, Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
> 
> On Mon, 2016-08-08 at 08:27 +0200, Jacob Kroon wrote:
>> On 08/08/2016 05:43 AM, bavery wrote:
>>> The openssh-sftp-server was already part of the pakagegroup. Adding
>>> the openssh-server
>>> lets the sftp server start up correctly.
>> 
>> If openssh-sftp-server cannot run without openssh, shouldn't it
>> RDEPEND
>> on it instead ?
> 
> I suspect you are right and that it needs an RDEPENDS if it doesn't
> work without it. It also needs a comment explaining the dependency so
> someone doesn't remove it.

I have been using

> 
> Cheers,
> 
> Richard
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

Re: [PATCH 1/2] packagegroup-core-eclipse-debug: add openssh server to support openssh-sftp-server

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]


> On Aug 8, 2016, at 9:02 AM, Khem Raj <raj.khem@gmail.com> wrote:
> 
> 
>> On Aug 8, 2016, at 1:04 AM, Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
>> 
>> On Mon, 2016-08-08 at 08:27 +0200, Jacob Kroon wrote:
>>> On 08/08/2016 05:43 AM, bavery wrote:
>>>> The openssh-sftp-server was already part of the pakagegroup. Adding
>>>> the openssh-server
>>>> lets the sftp server start up correctly.
>>> 
>>> If openssh-sftp-server cannot run without openssh, shouldn't it
>>> RDEPEND
>>> on it instead ?
>> 
>> I suspect you are right and that it needs an RDEPENDS if it doesn't
>> work without it. It also needs a comment explaining the dependency so
>> someone doesn't remove it.
> 
> I have been using

ignore this wrong thread and sent wrongly.

> 
>> 
>> Cheers,
>> 
>> Richard
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

Re: [PATCH 1/2] packagegroup-core-eclipse-debug: add openssh server to support openssh-sftp-server

[Paul Eggleton]

On Mon, 08 Aug 2016 09:04:20 Richard Purdie wrote:
> On Mon, 2016-08-08 at 08:27 +0200, Jacob Kroon wrote:
> > On 08/08/2016 05:43 AM, bavery wrote:
> > > The openssh-sftp-server was already part of the pakagegroup. Adding
> > > the openssh-server
> > > lets the sftp server start up correctly.
> > 
> > If openssh-sftp-server cannot run without openssh, shouldn't it
> > RDEPEND
> > on it instead ?
> 
> I suspect you are right and that it needs an RDEPENDS if it doesn't
> work without it. It also needs a comment explaining the dependency so
> someone doesn't remove it.

Using openssh-sftp-server with dropbear used to work, so it would be 
interesting to know when it broke and if it's possible to fix it.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [PATCH 1/2] packagegroup-core-eclipse-debug: add openssh server to support openssh-sftp-server

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 921 bytes --]


> On Aug 8, 2016, at 1:45 PM, Paul Eggleton <paul.eggleton@linux.intel.com> wrote:
> 
> On Mon, 08 Aug 2016 09:04:20 Richard Purdie wrote:
>> On Mon, 2016-08-08 at 08:27 +0200, Jacob Kroon wrote:
>>> On 08/08/2016 05:43 AM, bavery wrote:
>>>> The openssh-sftp-server was already part of the pakagegroup. Adding
>>>> the openssh-server
>>>> lets the sftp server start up correctly.
>>> 
>>> If openssh-sftp-server cannot run without openssh, shouldn't it
>>> RDEPEND
>>> on it instead ?
>> 
>> I suspect you are right and that it needs an RDEPENDS if it doesn't
>> work without it. It also needs a comment explaining the dependency so
>> someone doesn't remove it.
> 
> Using openssh-sftp-server with dropbear used to work, so it would be
> interesting to know when it broke and if it's possible to fix it.

yes, in angstrom that is the default combination as well. I think it still
is functional.

[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

Re: [PATCH 1/2] packagegroup-core-eclipse-debug: add openssh server to support openssh-sftp-server

[Brian Avery]

[-- Attachment #1: Type: text/plain, Size: 1580 bytes --]

Hi,

I spent some time today and could not replicate the issues I had with
dropbear+openssh-sftp-server under Eclipse. Since I ran into these issues
while tracking down the busybox/resize issue it could easily have been a
red herring.

So, I'm resending with the openssh-server patch removed.
-brian
an Intel employee


On Mon, Aug 8, 2016 at 2:38 PM, Khem Raj <raj.khem@gmail.com> wrote:

>
> > On Aug 8, 2016, at 1:45 PM, Paul Eggleton <paul.eggleton@linux.intel.com>
> wrote:
> >
> > On Mon, 08 Aug 2016 09:04:20 Richard Purdie wrote:
> >> On Mon, 2016-08-08 at 08:27 +0200, Jacob Kroon wrote:
> >>> On 08/08/2016 05:43 AM, bavery wrote:
> >>>> The openssh-sftp-server was already part of the pakagegroup. Adding
> >>>> the openssh-server
> >>>> lets the sftp server start up correctly.
> >>>
> >>> If openssh-sftp-server cannot run without openssh, shouldn't it
> >>> RDEPEND
> >>> on it instead ?
> >>
> >> I suspect you are right and that it needs an RDEPENDS if it doesn't
> >> work without it. It also needs a comment explaining the dependency so
> >> someone doesn't remove it.
> >
> > Using openssh-sftp-server with dropbear used to work, so it would be
> > interesting to know when it broke and if it's possible to fix it.
>
> yes, in angstrom that is the default combination as well. I think it still
> is functional.
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>

[-- Attachment #2: Type: text/html, Size: 2769 bytes --]

[PATCH 2/2] base-files: restrict resize to run on serial consoles only in profile │·

[bavery]

We don't need/wan't to run resize on an ssh connection. It's useless and
it breaks the Eclipse SSH debug connection. So, we added a check.

YOCTO #9362

Signed-off-by: bavery <brian.avery@intel.com>
---
 recipes-core/base-files/base-files/profile | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/recipes-core/base-files/base-files/profile b/recipes-core/base-files/base-files/profile
index e98e786..ba1b9ba 100644
--- a/recipes-core/base-files/base-files/profile
+++ b/recipes-core/base-files/base-files/profile
@@ -6,7 +6,7 @@ EDITOR="vi"			# needed for packages like cron, git-commit
 test -z "$TERM" && TERM="vt100"	# Basic terminal capab. For screen etc.
 
 if [ ! -e /etc/localtime -a ! -e /etc/TZ ]; then
-	TZ="UTC"		# Time Zone. Look at http://theory.uwinnipeg.ca/gnu/glibc/libc_303.html 
+	TZ="UTC"		# Time Zone. Look at http://theory.uwinnipeg.ca/gnu/glibc/libc_303.html
 				# for an explanation of how to set this to your local timezone.
 	export TZ
 fi
@@ -29,10 +29,11 @@ if [ -d /etc/profile.d ]; then
 fi
 
 if [ -x /usr/bin/resize ];then
-  /usr/bin/resize >/dev/null
+  # Make sure we are on a serial console (i.e. the device used starts with /dev/tty),
+  # otherwise we confuse e.g. the eclipse launcher which tries do use ssh
+  test `tty | cut -c1-8` = "/dev/tty" && resize >/dev/null
 fi
 
 export PATH PS1 OPIEDIR QPEDIR QTDIR EDITOR TERM
 
 umask 022
-
-- 
1.9.1