[PATCH 1/3] gst-player: update the callback for delete-event

[PATCH 1/3] gst-player: update the callback for delete-event

[Maxin B. John]

provide similar behaviour for Media Player's quit and close callback
functions.

[YOCTO #10045]

Signed-off-by: Maxin B. John <maxin.john@intel.com>
---
 ...ovide-similar-behaviour-for-quit-and-clos.patch | 32 ++++++++++++++++++++++
 .../recipes-multimedia/gstreamer/gst-player_git.bb |  1 +
 2 files changed, 33 insertions(+)
 create mode 100644 meta/recipes-multimedia/gstreamer/gst-player/0001-gtk-play-provide-similar-behaviour-for-quit-and-clos.patch

diff --git a/meta/recipes-multimedia/gstreamer/gst-player/0001-gtk-play-provide-similar-behaviour-for-quit-and-clos.patch b/meta/recipes-multimedia/gstreamer/gst-player/0001-gtk-play-provide-similar-behaviour-for-quit-and-clos.patch
new file mode 100644
index 0000000..e3f1c4f
--- /dev/null
+++ b/meta/recipes-multimedia/gstreamer/gst-player/0001-gtk-play-provide-similar-behaviour-for-quit-and-clos.patch
@@ -0,0 +1,32 @@
+From 220c2659a45dd354270a465c45197970dae5f548 Mon Sep 17 00:00:00 2001
+From: "Maxin B. John" <maxin.john@intel.com>
+Date: Fri, 5 Aug 2016 17:52:18 +0300
+Subject: [PATCH] gtk-play: provide similar behaviour for quit and close
+
+In x86 targets, gtk-play just pause rather than quitting the application
+when we click the close button (delete-event). Change the callback function
+to get similar behaviour when we click on "Quit" menu option.
+
+Upstream-Status: Accepted
+
+Signed-off-by: Maxin B. John <maxin.john@intel.com>
+---
+ gtk/gtk-play.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/gtk/gtk-play.c b/gtk/gtk-play.c
+index a520bef..16afc6b 100644
+--- a/gtk/gtk-play.c
++++ b/gtk/gtk-play.c
+@@ -177,7 +177,7 @@ load_from_builder (const gchar * filename, gboolean register_sig_handler,
+ static void
+ delete_event_cb (GtkWidget * widget, GdkEvent * event, GtkPlay * play)
+ {
+-  gst_player_stop (play->player);
++  gtk_widget_destroy (GTK_WIDGET (play));
+ }
+ 
+ static void
+-- 
+2.4.0
+
diff --git a/meta/recipes-multimedia/gstreamer/gst-player_git.bb b/meta/recipes-multimedia/gstreamer/gst-player_git.bb
index b09244b..00ad941 100644
--- a/meta/recipes-multimedia/gstreamer/gst-player_git.bb
+++ b/meta/recipes-multimedia/gstreamer/gst-player_git.bb
@@ -8,6 +8,7 @@ SRC_URI = "git://github.com/sdroege/gst-player.git \
            file://filechooser.patch;apply=0 \
            file://Fix-pause-play.patch;apply=0 \
            file://Add-error-signal-emission-for-missing-plugins.patch;apply=0 \
+           file://0001-gtk-play-provide-similar-behaviour-for-quit-and-clos.patch \
            file://gst-player.desktop"
 
 SRCREV = "ea90e63c1064503f9ba5d59aa4ca604f13ca5def"
-- 
2.4.0

[PATCH 2/3] hdparm: update LICENSE info

[Maxin B. John]

Update hdparm recipe so that LICENSE_wiper is specified in the LICENSE.

[YOCTO #10074]

Signed-off-by: Maxin B. John <maxin.john@intel.com>
---
 meta/recipes-extended/hdparm/hdparm_9.48.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-extended/hdparm/hdparm_9.48.bb b/meta/recipes-extended/hdparm/hdparm_9.48.bb
index ec3d26f..86faf6a 100644
--- a/meta/recipes-extended/hdparm/hdparm_9.48.bb
+++ b/meta/recipes-extended/hdparm/hdparm_9.48.bb
@@ -2,7 +2,7 @@ SUMMARY = "Utility for viewing/manipulating IDE disk drive/driver parameters"
 DESCRIPTION = "hdparm is a Linux shell utility for viewing \
 and manipulating various IDE drive and driver parameters."
 SECTION = "console/utils"
-LICENSE = "BSD"
+LICENSE = "BSD & GPLv2"
 LICENSE_wiper = "GPLv2"
 LIC_FILES_CHKSUM = "file://LICENSE.TXT;md5=910a8a42c962d238619c75fdb78bdb24 \
                     file://debian/copyright;md5=a82d7ba3ade9e8ec902749db98c592f3 \
-- 
2.4.0

Re: [PATCH 2/3] hdparm: update LICENSE info

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

On 8 August 2016 at 12:13, Maxin B. John <maxin.john@intel.com> wrote:

> -LICENSE = "BSD"
> +LICENSE = "BSD & GPLv2"
>  LICENSE_wiper = "GPLv2"
>

I sent a patch for this one last week but forgot to update the bug, sorry.

This isn't quite right as the hdparm utility itself is BSD licensed, so you
also need LICENSE_${PN} = BSD.

That said Markus was saying last week that this behaviour isn't great (and
neither was the original behaviour), so there may be more patches to
improve how LICENSE works.

Ross

[-- Attachment #2: Type: text/html, Size: 1135 bytes --]

Re: [PATCH 2/3] hdparm: update LICENSE info

[Markus Lehtonen]

On Mon, 2016-08-08 at 12:23 +0100, Burton, Ross wrote:
> 
> On 8 August 2016 at 12:13, Maxin B. John <maxin.john@intel.com>
> wrote:
> > -LICENSE = "BSD"
> > +LICENSE = "BSD & GPLv2"
> >  LICENSE_wiper = "GPLv2"
> > 
> I sent a patch for this one last week but forgot to update the bug,
> sorry.
> 
> This isn't quite right as the hdparm utility itself is BSD licensed,
> so you also need LICENSE_${PN} = BSD.
> 
> That said Markus was saying last week that this behaviour isn't great
> (and neither was the original behaviour), so there may be more
> patches to improve how LICENSE works.

I opened a discussion on the architecture list:
http://lists.openembedded.org/pipermail/openembedded-architecture/2016-
August/000218.html

I'll hopefully have some patches after a satisfying solution is found.

Thanks,
  Markus

[PATCH 3/3] nettle: update LICENSE info for version 2.7.1

[Maxin B. John]

LICENSE_${PN} shouldn't contain anything that is not specified in LICENSE.

[YOCTO #10075]

Signed-off-by: Maxin B. John <maxin.john@intel.com>
---
 meta/recipes-support/nettle/nettle_2.7.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-support/nettle/nettle_2.7.1.bb b/meta/recipes-support/nettle/nettle_2.7.1.bb
index d4df0a3..ae8e311 100644
--- a/meta/recipes-support/nettle/nettle_2.7.1.bb
+++ b/meta/recipes-support/nettle/nettle_2.7.1.bb
@@ -1,6 +1,6 @@
 require nettle.inc
 
-LICENSE = "LGPLv2.1 & GPLv2"
+LICENSE = "LGPLv2.1+ & GPLv2"
 LICENSE_${PN} = "LGPLv2.1+"
 
 LIC_FILES_CHKSUM = "file://COPYING.LIB;md5=2d5025d4aa3495befef8f17206a5b0a1 \
-- 
2.4.0