From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Jose Lamego <jose.a.lamego@linux.intel.com>,
openembedded-core@lists.openembedded.org, "Lock,
Joshua" <joshua.g.lock@intel.com>
Subject: Re: [PATCH 00/20] oeqa: Split configuration from the code
Date: Tue, 09 Aug 2016 13:09:26 +0100 [thread overview]
Message-ID: <1470744566.8166.48.camel@linuxfoundation.org> (raw)
In-Reply-To: <cover.1470671417.git.jose.a.lamego@linux.intel.com>
On Mon, 2016-08-08 at 09:22 -0700, Jose Lamego wrote:
> Improve oeqa-selftest capabilities and UX by placing
> test configuration features and variables into a separate
> configuration file.
> Configuration file reading is done through a new library in
> oeqa.utils and specific configuration files for each test are
> stored in a separate directory.
>
> [Yocto 9389]
Looking at these changes, I'm not 100% convinced this is an improvement
in readability or experience. Right now, I can look at the test case
definition and get a reasonable idea of what its doing. After the
change, I have to read two files at once, side by side in order to have
a clue what the test does. Is that an improvement?
I'm open to persuasion on why this patchset is a good idea but the
pieces I looked at didn't seem to help much :/
Cheers,
Richard
prev parent reply other threads:[~2016-08-09 12:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 16:22 [PATCH 00/20] oeqa: Split configuration from the code Jose Lamego
2016-08-08 16:22 ` [PATCH 01/20] oeqa.selftest.archiver: Split configuration from code Jose Lamego
2016-08-08 16:22 ` [PATCH 02/20] oeqa.selftest._sstatetests_noauto: " Jose Lamego
2016-08-08 16:22 ` [PATCH 03/20] oeqa.selftest.bblayers: " Jose Lamego
2016-08-08 16:22 ` [PATCH 04/20] oeqa.selftest.bbtests: " Jose Lamego
2016-08-08 16:22 ` [PATCH 05/20] oeqa.selftest.buildhistory: " Jose Lamego
2016-08-08 16:22 ` [PATCH 06/20] oeqa.selftest.buildoptions: " Jose Lamego
2016-08-08 16:22 ` [PATCH 07/20] oeqa.selftest.devtool: " Jose Lamego
2016-08-08 16:22 ` [PATCH 08/20] oeqa.selftest.imagefeatures: " Jose Lamego
2016-08-08 16:22 ` [PATCH 09/20] oeqa.selftest.layerappend: " Jose Lamego
2016-08-08 16:22 ` [PATCH 10/20] oeqa.selftest.lic-checksum: " Jose Lamego
2016-08-08 16:22 ` [PATCH 11/20] oeqa.selftest.manifest: " Jose Lamego
2016-08-08 16:23 ` [PATCH 12/20] oeqa.selftest.oescripts: " Jose Lamego
2016-08-08 16:23 ` [PATCH 13/20] oeqa.selftest.pkgdata: " Jose Lamego
2016-08-08 16:23 ` [PATCH 14/20] oeqa.selftest.prservice: " Jose Lamego
2016-08-08 16:23 ` [PATCH 15/20] oeqa.selftest.recipetool: " Jose Lamego
2016-08-08 16:23 ` [PATCH 16/20] oeqa.selftest.runtime-test: " Jose Lamego
2016-08-08 16:23 ` [PATCH 17/20] oeqa.selftest.signing: " Jose Lamego
2016-08-08 16:23 ` [PATCH 18/20] oeqa.selftest.sstatetests: " Jose Lamego
2016-08-08 16:23 ` [PATCH 19/20] oeqa.selftest.wic: " Jose Lamego
2016-08-09 7:26 ` Ed Bartosh
2016-08-09 15:20 ` Jose Lamego
2016-08-08 16:23 ` [PATCH 20/20] oeqa.utils.readconfig: Read self-test configuration file Jose Lamego
2016-08-09 9:19 ` Joshua G Lock
2016-08-09 12:09 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470744566.8166.48.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=jose.a.lamego@linux.intel.com \
--cc=joshua.g.lock@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox