* [PATCH] npm: npm.bbclass now adds nodejs to RDEPENDS
@ 2016-08-10 22:15 Henry Bruce
2016-08-10 22:53 ` Christopher Larson
2016-08-10 23:26 ` [PATCH v2] " Henry Bruce
0 siblings, 2 replies; 3+ messages in thread
From: Henry Bruce @ 2016-08-10 22:15 UTC (permalink / raw)
To: openembedded-core
We expect that any package that uses the npm bbclass
will have a runtime dependency on node.js
Signed-off-by: Henry Bruce <henry.bruce@intel.com>
---
meta/classes/npm.bbclass | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/classes/npm.bbclass b/meta/classes/npm.bbclass
index 95be751..541fd3b 100644
--- a/meta/classes/npm.bbclass
+++ b/meta/classes/npm.bbclass
@@ -1,4 +1,5 @@
DEPENDS_prepend = "nodejs-native "
+RDEPENDS_${PN}_prepend += "nodejs "
S = "${WORKDIR}/npmpkg"
NPM_INSTALLDIR = "${D}${libdir}/node_modules/${PN}"
--
2.4.11
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] npm: npm.bbclass now adds nodejs to RDEPENDS
2016-08-10 22:15 [PATCH] npm: npm.bbclass now adds nodejs to RDEPENDS Henry Bruce
@ 2016-08-10 22:53 ` Christopher Larson
2016-08-10 23:26 ` [PATCH v2] " Henry Bruce
1 sibling, 0 replies; 3+ messages in thread
From: Christopher Larson @ 2016-08-10 22:53 UTC (permalink / raw)
To: Henry Bruce; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 912 bytes --]
On Wed, Aug 10, 2016 at 3:15 PM, Henry Bruce <henry.bruce@intel.com> wrote:
> We expect that any package that uses the npm bbclass
> will have a runtime dependency on node.js
>
> Signed-off-by: Henry Bruce <henry.bruce@intel.com>
> ---
> meta/classes/npm.bbclass | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/classes/npm.bbclass b/meta/classes/npm.bbclass
> index 95be751..541fd3b 100644
> --- a/meta/classes/npm.bbclass
> +++ b/meta/classes/npm.bbclass
> @@ -1,4 +1,5 @@
> DEPENDS_prepend = "nodejs-native "
> +RDEPENDS_${PN}_prepend += "nodejs "
>
The += here is pointless. It adds a leading space, which does nothing, and
isn't needed for a prepend anyway. Just use =, the same as is used for
DEPENDS.
--
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
[-- Attachment #2: Type: text/html, Size: 1610 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH v2] npm: npm.bbclass now adds nodejs to RDEPENDS
2016-08-10 22:15 [PATCH] npm: npm.bbclass now adds nodejs to RDEPENDS Henry Bruce
2016-08-10 22:53 ` Christopher Larson
@ 2016-08-10 23:26 ` Henry Bruce
1 sibling, 0 replies; 3+ messages in thread
From: Henry Bruce @ 2016-08-10 23:26 UTC (permalink / raw)
To: openembedded-core
We expect that any package that uses the npm bbclass
will have a runtime dependency on node.js
Signed-off-by: Henry Bruce <henry.bruce@intel.com>
---
meta/classes/npm.bbclass | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/classes/npm.bbclass b/meta/classes/npm.bbclass
index 95be751..55c7c3e 100644
--- a/meta/classes/npm.bbclass
+++ b/meta/classes/npm.bbclass
@@ -1,4 +1,5 @@
DEPENDS_prepend = "nodejs-native "
+RDEPENDS_${PN}_prepend = "nodejs "
S = "${WORKDIR}/npmpkg"
NPM_INSTALLDIR = "${D}${libdir}/node_modules/${PN}"
--
2.4.11
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-10 23:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-10 22:15 [PATCH] npm: npm.bbclass now adds nodejs to RDEPENDS Henry Bruce
2016-08-10 22:53 ` Christopher Larson
2016-08-10 23:26 ` [PATCH v2] " Henry Bruce
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox