[PATCH] ccache.bbclass: don't remove CCACHE_DIR as part of do_clean

[PATCH] ccache.bbclass: don't remove CCACHE_DIR as part of do_clean

[Andre McCurdy]

Removing the ccache directory as part of do_clean is unnecessarily
conservative and defeats many of the benefits of ccache.

The original justification for this behaviour was to avoid confusion
in the corner case that the ccache directory becomes corrupted.
However the standard approach for dealing with such highly unlikely
corner cases (ie manually removing tmp) would also recover from
corruption of the ccache directories, without the negative impact of
defeating ccache during normal development.

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
 meta/classes/ccache.bbclass | 2 --
 1 file changed, 2 deletions(-)

diff --git a/meta/classes/ccache.bbclass b/meta/classes/ccache.bbclass
index 2cdce46..2e9837c 100644
--- a/meta/classes/ccache.bbclass
+++ b/meta/classes/ccache.bbclass
@@ -4,5 +4,3 @@ CCACHE_DISABLE[unexport] = "1"
 
 do_configure[dirs] =+ "${CCACHE_DIR}"
 do_kernel_configme[dirs] =+ "${CCACHE_DIR}"
-
-do_clean[cleandirs] += "${CCACHE_DIR}"
-- 
1.9.1

Re: [PATCH] ccache.bbclass: don't remove CCACHE_DIR as part of do_clean

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1582 bytes --]


> On Aug 11, 2016, at 1:38 AM, Andre McCurdy <armccurdy@gmail.com> wrote:
> 
> Removing the ccache directory as part of do_clean is unnecessarily
> conservative and defeats many of the benefits of ccache.
> 
> The original justification for this behaviour was to avoid confusion
> in the corner case that the ccache directory becomes corrupted.
> However the standard approach for dealing with such highly unlikely
> corner cases (ie manually removing tmp) would also recover from
> corruption of the ccache directories, without the negative impact of
> defeating ccache during normal development.

perhaps a good know-how on this if someone runs into this case would
justify this patch. Since this can still break the case where someone
is doing -cclean* operations and other tasks are run individually for
such broken case.

> 
> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
> ---
> meta/classes/ccache.bbclass | 2 --
> 1 file changed, 2 deletions(-)
> 
> diff --git a/meta/classes/ccache.bbclass b/meta/classes/ccache.bbclass
> index 2cdce46..2e9837c 100644
> --- a/meta/classes/ccache.bbclass
> +++ b/meta/classes/ccache.bbclass
> @@ -4,5 +4,3 @@ CCACHE_DISABLE[unexport] = "1"
> 
> do_configure[dirs] =+ "${CCACHE_DIR}"
> do_kernel_configme[dirs] =+ "${CCACHE_DIR}"
> -
> -do_clean[cleandirs] += "${CCACHE_DIR}"
> --
> 1.9.1
> 
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]