[PATCH] kernel.bbclass: include signing keys when copying files required for module builds

[PATCH] kernel.bbclass: include signing keys when copying files required for module builds

[Waldo Mattias]

The absence of certs/signing_key.* in $kerneldir made signing of
out-of-tree kernel modules fail (silently). Add copying of these files
during the shared_workdir task.

Signed-off-by: Mattias Waldo <mattias.waldo@saabgroup.com>
---
 meta/classes/kernel.bbclass | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 6e3e81e..2bfd65c 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -295,6 +295,8 @@ do_shared_workdir () {
        cp .config $kerneldir/
        mkdir -p $kerneldir/include/config
        cp include/config/kernel.release $kerneldir/include/config/kernel.release
+       mkdir -p $kerneldir/certs
+       cp certs/signing_key.* $kerneldir/certs

        # We can also copy over all the generated files and avoid special cases
        # like version.h, but we've opted to keep this small until file creep starts
--
2.9.2

Re: [PATCH] kernel.bbclass: include signing keys when copying files required for module builds

[Jianxun Zhang]

Bruce,
Ping~~~
Could you or anyone have a look on this patch? It is for https://bugzilla.yoctoproject.org/show_bug.cgi?id=9805

Thanks


> On Aug 12, 2016, at 7:10 AM, Waldo Mattias <Mattias.Waldo@saabgroup.com> wrote:
> 
> The absence of certs/signing_key.* in $kerneldir made signing of
> out-of-tree kernel modules fail (silently). Add copying of these files
> during the shared_workdir task.
> 
> Signed-off-by: Mattias Waldo <mattias.waldo@saabgroup.com>
> ---
> meta/classes/kernel.bbclass | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 6e3e81e..2bfd65c 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -295,6 +295,8 @@ do_shared_workdir () {
>        cp .config $kerneldir/
>        mkdir -p $kerneldir/include/config
>        cp include/config/kernel.release $kerneldir/include/config/kernel.release
> +       mkdir -p $kerneldir/certs
> +       cp certs/signing_key.* $kerneldir/certs
> 
>        # We can also copy over all the generated files and avoid special cases
>        # like version.h, but we've opted to keep this small until file creep starts
> --
> 2.9.2
> 
> 
> 
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH] kernel.bbclass: include signing keys when copying files required for module builds

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 339 bytes --]

On 12 August 2016 at 15:10, Waldo Mattias <Mattias.Waldo@saabgroup.com>
wrote:

> The absence of certs/signing_key.* in $kerneldir made signing of
> out-of-tree kernel modules fail (silently). Add copying of these files
> during the shared_workdir task.
>

This doesn't apply to current master, can you rebase and resend?

Ross

[-- Attachment #2: Type: text/html, Size: 756 bytes --]

Re: [PATCH] kernel.bbclass: include signing keys when copying files required for module builds

[Waldo Mattias]

[-- Attachment #1: Type: text/plain, Size: 935 bytes --]

Hi!

I’ve rebased successfully and resubmitted v2 of the patch – it doesn’t seem to have changed much, though – perhaps I misunderstood your intent? (Please bear with me, this is my first patch ever, so I may miss some obvious things...)

Regards,

Mattias

From: Burton, Ross [mailto:ross.burton@intel.com]
Sent: den 24 augusti 2016 23:06
To: Waldo Mattias <Mattias.Waldo@saabgroup.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] kernel.bbclass: include signing keys when copying files required for module builds


On 12 August 2016 at 15:10, Waldo Mattias <Mattias.Waldo@saabgroup.com<mailto:Mattias.Waldo@saabgroup.com>> wrote:
The absence of certs/signing_key.* in $kerneldir made signing of
out-of-tree kernel modules fail (silently). Add copying of these files
during the shared_workdir task.

This doesn't apply to current master, can you rebase and resend?

Ross

[-- Attachment #2: Type: text/html, Size: 4709 bytes --]