[PATCH 1/1] useradd: do not delete users and groups during configure

[PATCH 1/1] useradd: do not delete users and groups during configure

[Joe Slater]

If two recipes both create the same users and groups, the
second recipe can delete items created by the first causing
things like "chown" to fail for the first recipe.

Signed-off-by: Joe Slater <jslater@windriver.com>
---
 meta/classes/useradd.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/useradd.bbclass b/meta/classes/useradd.bbclass
index 8d51fb5..6df9822 100644
--- a/meta/classes/useradd.bbclass
+++ b/meta/classes/useradd.bbclass
@@ -129,7 +129,7 @@ useradd_sysroot_sstate () {
 
 userdel_sysroot_sstate () {
 if test "x${STAGING_DIR_TARGET}" != "x"; then
-    if [ "${BB_CURRENTTASK}" = "configure" -o "${BB_CURRENTTASK}" = "clean" ]; then
+    if [ "${BB_CURRENTTASK}" = "clean" ]; then
         export PSEUDO="${FAKEROOTENV} PSEUDO_LOCALSTATEDIR=${STAGING_DIR_TARGET}${localstatedir}/pseudo ${STAGING_DIR_NATIVE}${bindir_native}/pseudo"
         OPT="--root ${STAGING_DIR_TARGET}"
 
-- 
1.7.9.5

Re: [PATCH 1/1] useradd: do not delete users and groups during configure

[Randy MacLeod]

On 2016-08-16 02:16 PM, Joe Slater wrote:
> If two recipes both create the same users and groups, the
> second recipe can delete items created by the first causing
> things like "chown" to fail for the first recipe.
>
> Signed-off-by: Joe Slater <jslater@windriver.com>
> ---
>  meta/classes/useradd.bbclass |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/useradd.bbclass b/meta/classes/useradd.bbclass
> index 8d51fb5..6df9822 100644
> --- a/meta/classes/useradd.bbclass
> +++ b/meta/classes/useradd.bbclass
> @@ -129,7 +129,7 @@ useradd_sysroot_sstate () {
>
>  userdel_sysroot_sstate () {
>  if test "x${STAGING_DIR_TARGET}" != "x"; then
> -    if [ "${BB_CURRENTTASK}" = "configure" -o "${BB_CURRENTTASK}" = "clean" ]; then
> +    if [ "${BB_CURRENTTASK}" = "clean" ]; then
>          export PSEUDO="${FAKEROOTENV} PSEUDO_LOCALSTATEDIR=${STAGING_DIR_TARGET}${localstatedir}/pseudo ${STAGING_DIR_NATIVE}${bindir_native}/pseudo"
>          OPT="--root ${STAGING_DIR_TARGET}"
>
>


I don't see this in oe-core/master[-next] yet.

Is there a better solution or should the recipes
that create the user (ftp in this case), be modified some how?

-- 
# Randy MacLeod. SMTS, Linux, Wind River
Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON, 
Canada, K2K 2W5

Re: [PATCH 1/1] useradd: do not delete users and groups during configure

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

On 24 August 2016 at 16:29, Randy MacLeod <randy.macleod@windriver.com>
wrote:

> I don't see this in oe-core/master[-next] yet.
>

It's in mut so assuming it doesn't break anything may be in master next
week.

Ross

[-- Attachment #2: Type: text/html, Size: 650 bytes --]