[PATCH v4] kernel.bbclass: include signing keys when copying files required for module builds

[PATCH v4] kernel.bbclass: include signing keys when copying files required for module builds

[Mattias Waldo]

The absence of certs/signing_key.* in $kerneldir made signing of
out-of-tree kernel modules fail (silently). Add copying of these
files during the shared_workdir task.

Signed-off-by: Mattias Waldo <mattias.waldo@saabgroup.com>
---
 meta/classes/kernel.bbclass | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index db42744..07761e7 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -364,6 +364,8 @@ do_shared_workdir () {
 	cp .config $kerneldir/
 	mkdir -p $kerneldir/include/config
 	cp include/config/kernel.release $kerneldir/include/config/kernel.release
+	mkdir -p $kerneldir/certs
+	cp certs/signing_key.* $kerneldir/certs
 
 	# We can also copy over all the generated files and avoid special cases
 	# like version.h, but we've opted to keep this small until file creep starts
-- 
1.9.1

Re: [PATCH v4] kernel.bbclass: include signing keys when copying files required for module builds

[Richard Purdie]

On Fri, 2016-08-26 at 20:58 +0200, Mattias Waldo wrote:
> The absence of certs/signing_key.* in $kerneldir made signing of
> out-of-tree kernel modules fail (silently). Add copying of these
> files during the shared_workdir task.
> 
> Signed-off-by: Mattias Waldo <mattias.waldo@saabgroup.com>
> ---
>  meta/classes/kernel.bbclass | 2 ++
>  1 file changed, 2 insertions(+)

Sadly this breaks the build when you don't have any keys:

e.g.: https://autobuilder.yoctoproject.org/main/builders/build-applianc
e/builds/892/steps/BuildImages_1/logs/stdio

but there were many many other failures :(

Cheers,

Richard

Re: [PATCH v4] kernel.bbclass: include signing keys when copying files required for module builds

[Mattias Waldo]

[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]

Hi!

I just submitted version 5 of the patch, which hopefully doesn't break the
build. In addition it should handle both 4.1 and 4.4 versions of the Linux
kernel, which use different locations for their signing key files.

Regards,

Mattias

On Wed, Aug 31, 2016 at 12:45 AM, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Fri, 2016-08-26 at 20:58 +0200, Mattias Waldo wrote:
> > The absence of certs/signing_key.* in $kerneldir made signing of
> > out-of-tree kernel modules fail (silently). Add copying of these
> > files during the shared_workdir task.
> >
> > Signed-off-by: Mattias Waldo <mattias.waldo@saabgroup.com>
> > ---
> >  meta/classes/kernel.bbclass | 2 ++
> >  1 file changed, 2 insertions(+)
>
> Sadly this breaks the build when you don't have any keys:
>
> e.g.: https://autobuilder.yoctoproject.org/main/builders/build-applianc
> e/builds/892/steps/BuildImages_1/logs/stdio
>
> but there were many many other failures :(
>
> Cheers,
>
> Richard
>

[-- Attachment #2: Type: text/html, Size: 1672 bytes --]