[PATCH] provide better error message when runqemu-ifup fails

[PATCH] provide better error message when runqemu-ifup fails

[Stephano Cetola]

If runqemu-ifup fails hen running testimage, a rather cryptic error
regarding "no tty present" is displayed. If this step fails, we
should at least point the user at runqemu-gen-tapdevs. A quick search
of this term in the manual will lead them to "Enabling Runtime Tests
on QEMU" which should give them all the info they need.

Signed-off-by: Stephano Cetola <stephano.cetola@linux.intel.com>
---
 scripts/runqemu-internal | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/runqemu-internal b/scripts/runqemu-internal
index d10466d..3d728c0 100755
--- a/scripts/runqemu-internal
+++ b/scripts/runqemu-internal
@@ -153,6 +153,7 @@ else
             if [ $? -ne 0 ]; then
                 # Re-run standalone to see verbose errors
                 sudo $QEMUIFUP $USERID $GROUPID $OECORE_NATIVE_SYSROOT
+                echo "ERROR: Failed to setup tap device. Run runqemu-gen-tapdevs to manually create."
                 return 1
             fi
             LOCKFILE="$LOCKDIR/$tap"
-- 
2.9.3

Re: [PATCH] provide better error message when runqemu-ifup fails

[Richard Purdie]

On Mon, 2016-08-29 at 15:24 -0700, Stephano Cetola wrote:
> If runqemu-ifup fails hen running testimage, a rather cryptic error
> regarding "no tty present" is displayed. If this step fails, we
> should at least point the user at runqemu-gen-tapdevs. A quick search
> of this term in the manual will lead them to "Enabling Runtime Tests
> on QEMU" which should give them all the info they need.
> 
> Signed-off-by: Stephano Cetola <stephano.cetola@linux.intel.com>
> ---
>  scripts/runqemu-internal | 1 +
>  1 file changed, 1 insertion(+)

The shortlog needs a prefix, e.g. "scripts/runqemu:" and this patch
will likely need adapting on top of Robert's changes (see master-next).

Cheers,

Richard