From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Marek Vasut <marex@denx.de>, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] u-boot: Factor out common bits
Date: Mon, 05 Sep 2016 12:02:34 +0100 [thread overview]
Message-ID: <1473073354.20226.9.camel@linuxfoundation.org> (raw)
In-Reply-To: <00e9ef55-2e08-5c92-0a5a-32e9ce1f61fa@denx.de>
On Mon, 2016-09-05 at 00:33 +0200, Marek Vasut wrote:
> On 09/05/2016 12:23 AM, Marek Vasut wrote:
> > On 09/05/2016 12:11 AM, Richard Purdie wrote:
> > > On Sun, 2016-09-04 at 23:49 +0200, Marek Vasut wrote:
> > > > On 09/04/2016 11:28 PM, Richard Purdie wrote:
> > > > > On Sun, 2016-09-04 at 18:21 +0200, Marek Vasut wrote:
> > > > Yes, except when new version of U-Boot comes out and we want to
> > > > perform
> > > > update of the u-boot{,mkimage,fw-utils} recipes, with this
> > > > current
> > > > patch
> > > > as is, we'd only have to rename these recipes and change the
> > > > version
> > > > in
> > > > u-boot-common.inc . With your proposal, we'd have to not only
> > > > rename
> > > > the
> > > > recipes and tweak u-boot-common.inc, but also edit their
> > > > content and
> > > > change the "require u-boot-common_20yy.mm.inc" bit, which adds
> > > > some
> > > > toil.
> > > Unless its:
> > >
> > > require u-boot-common_${PV}.inc
> > >
> > > since it should be able to extract PV from the filename...
> > Ah right, thanks :)
> >
> > I'll rebuild/retest and send a V2 .
> >
> I was a bit hasty, the u-boot.inc includes u-boot-common.inc without
> having PV set. Any idea how to deal with that ?
Just put includes in the versioned files rather than from u-boot.inc?
Cheers,
Richard
next prev parent reply other threads:[~2016-09-05 11:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-04 16:21 [PATCH 1/2] u-boot: Factor out common bits Marek Vasut
2016-09-04 16:21 ` [PATCH 2/2] u-boot: Update to 2016.07 release Marek Vasut
2016-09-14 8:48 ` Alexander Kanavin
2016-09-04 21:28 ` [PATCH 1/2] u-boot: Factor out common bits Richard Purdie
2016-09-04 21:49 ` Marek Vasut
2016-09-04 22:11 ` Richard Purdie
2016-09-04 22:23 ` Marek Vasut
2016-09-04 22:33 ` Marek Vasut
2016-09-05 11:02 ` Richard Purdie [this message]
2016-09-05 11:04 ` Marek Vasut
2016-09-05 13:51 ` Otavio Salvador
2016-09-05 16:16 ` Marek Vasut
2016-09-05 16:22 ` Otavio Salvador
2016-09-05 16:24 ` Marek Vasut
2016-09-05 16:26 ` Otavio Salvador
2016-09-05 19:33 ` Richard Purdie
2016-09-05 19:47 ` Marek Vasut
2016-09-05 19:52 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473073354.20226.9.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=marex@denx.de \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox