From: Marek Vasut <marex@denx.de>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] u-boot: Factor out common bits
Date: Sun, 4 Sep 2016 23:49:45 +0200 [thread overview]
Message-ID: <9f3a5dfd-8303-b6d0-cd5e-07f2aac7c588@denx.de> (raw)
In-Reply-To: <1473024487.20226.3.camel@linuxfoundation.org>
On 09/04/2016 11:28 PM, Richard Purdie wrote:
> On Sun, 2016-09-04 at 18:21 +0200, Marek Vasut wrote:
>> The u-boot recipes share a couple of common variables, which makes
>> updating of the recipes error prone and a toil. Factor those common
>> bits into u-boot-common.inc so that they are in one place.
>>
>> No functional change.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> ---
>> meta/recipes-bsp/u-boot/u-boot-common.inc | 16
>> ++++++++++++++++
>> meta/recipes-bsp/u-boot/u-boot-fw-utils_2016.03.bb | 16 ++--------
>> ------
>> meta/recipes-bsp/u-boot/u-boot-mkimage_2016.03.bb | 17 ++--------
>> -------
>> meta/recipes-bsp/u-boot/u-boot.inc | 10 ++--------
>> meta/recipes-bsp/u-boot/u-boot_2016.03.bb | 7 -------
>> 5 files changed, 22 insertions(+), 44 deletions(-)
>> create mode 100644 meta/recipes-bsp/u-boot/u-boot-common.inc
>>
>> diff --git a/meta/recipes-bsp/u-boot/u-boot-common.inc
>> b/meta/recipes-bsp/u-boot/u-boot-common.inc
>> new file mode 100644
>> index 0000000..403e316
>> --- /dev/null
>> +++ b/meta/recipes-bsp/u-boot/u-boot-common.inc
>> @@ -0,0 +1,16 @@
>> +HOMEPAGE = "http://www.denx.de/wiki/U-Boot/WebHome"
>> +SECTION = "bootloaders"
>> +
>> +LICENSE = "GPLv2+"
>> +LIC_FILES_CHKSUM =
>> "file://Licenses/README;md5=a2c678cfd4a4d97135585cad908541c6"
>> +
>> +# This revision corresponds to the tag "v2016.03"
>> +# We use the revision in order to avoid having to fetch it from the
>> +# repo during parse
>> +SRCREV = "df61a74e6845ec9bdcdd48d2aff5e9c2c6debeaa"
>> +
>> +PV = "v2016.03+git${SRCPV}"
>> +
>> +SRC_URI = "git://git.denx.de/u-boot.git;branch=master"
>> +
>> +S = "${WORKDIR}/git"
>
> Since the common file you're creating is 2016.03 version specific, I'd
> be tempted to call it u-boot-common_2016.03.inc and then its clear its
> version specific...
Yes, except when new version of U-Boot comes out and we want to perform
update of the u-boot{,mkimage,fw-utils} recipes, with this current patch
as is, we'd only have to rename these recipes and change the version in
u-boot-common.inc . With your proposal, we'd have to not only rename the
recipes and tweak u-boot-common.inc, but also edit their content and
change the "require u-boot-common_20yy.mm.inc" bit, which adds some toil.
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-09-04 21:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-04 16:21 [PATCH 1/2] u-boot: Factor out common bits Marek Vasut
2016-09-04 16:21 ` [PATCH 2/2] u-boot: Update to 2016.07 release Marek Vasut
2016-09-14 8:48 ` Alexander Kanavin
2016-09-04 21:28 ` [PATCH 1/2] u-boot: Factor out common bits Richard Purdie
2016-09-04 21:49 ` Marek Vasut [this message]
2016-09-04 22:11 ` Richard Purdie
2016-09-04 22:23 ` Marek Vasut
2016-09-04 22:33 ` Marek Vasut
2016-09-05 11:02 ` Richard Purdie
2016-09-05 11:04 ` Marek Vasut
2016-09-05 13:51 ` Otavio Salvador
2016-09-05 16:16 ` Marek Vasut
2016-09-05 16:22 ` Otavio Salvador
2016-09-05 16:24 ` Marek Vasut
2016-09-05 16:26 ` Otavio Salvador
2016-09-05 19:33 ` Richard Purdie
2016-09-05 19:47 ` Marek Vasut
2016-09-05 19:52 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f3a5dfd-8303-b6d0-cd5e-07f2aac7c588@denx.de \
--to=marex@denx.de \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox