[PATCH] classes/populate_sdk_ext: exclude image tasks from locked signatures

[PATCH] classes/populate_sdk_ext: exclude image tasks from locked signatures

[Amarnath Valluri]

Tasks for image recipes cannot be locked and should be excluded from eSDK
generated locked-sigs.inc. get_sdk_install_targets() was not returning right
image targets to be excluded incase of 'minimal' sdk. This change fixes the issue.

Signed-off-by: Amarnath Valluri <amarnath.valluri@intel.com>
---
 meta/classes/populate_sdk_ext.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/populate_sdk_ext.bbclass b/meta/classes/populate_sdk_ext.bbclass
index d8d123a..1a15d2a 100644
--- a/meta/classes/populate_sdk_ext.bbclass
+++ b/meta/classes/populate_sdk_ext.bbclass
@@ -43,7 +43,7 @@ SDK_TARGETS ?= "${PN}"
 
 def get_sdk_install_targets(d, images_only=False):
     sdk_install_targets = ''
-    if d.getVar('SDK_EXT_TYPE', True) != 'minimal':
+    if images_only or d.getVar('SDK_EXT_TYPE', True) != 'minimal':
         sdk_install_targets = d.getVar('SDK_TARGETS', True)
 
         depd = d.getVar('BB_TASKDEPDATA', False)
-- 
2.5.0

---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

Re: [PATCH] classes/populate_sdk_ext: exclude image tasks from locked signatures

[Paul Eggleton]

On Tue, 06 Sep 2016 16:13:06 Amarnath Valluri wrote:
> Tasks for image recipes cannot be locked and should be excluded from eSDK
> generated locked-sigs.inc. get_sdk_install_targets() was not returning right
> image targets to be excluded incase of 'minimal' sdk. This change fixes the
> issue.
> 
> Signed-off-by: Amarnath Valluri <amarnath.valluri@intel.com>
> ---
>  meta/classes/populate_sdk_ext.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/populate_sdk_ext.bbclass
> b/meta/classes/populate_sdk_ext.bbclass index d8d123a..1a15d2a 100644
> --- a/meta/classes/populate_sdk_ext.bbclass
> +++ b/meta/classes/populate_sdk_ext.bbclass
> @@ -43,7 +43,7 @@ SDK_TARGETS ?= "${PN}"
> 
>  def get_sdk_install_targets(d, images_only=False):
>      sdk_install_targets = ''
> -    if d.getVar('SDK_EXT_TYPE', True) != 'minimal':
> +    if images_only or d.getVar('SDK_EXT_TYPE', True) != 'minimal':
>          sdk_install_targets = d.getVar('SDK_TARGETS', True)
> 
>          depd = d.getVar('BB_TASKDEPDATA', False)

Acked-by: Paul Eggleton <paul.eggleton@linux.intel.com>

(The original naming of the parameter probably makes this a little confusing 
now, but we can tidy that up later.)

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre