* [PATCH] x264: add textrel to INSANE_SKIP for cyclone5 machine
@ 2016-09-12 6:13 Sujith H
2016-09-14 23:11 ` Burton, Ross
0 siblings, 1 reply; 5+ messages in thread
From: Sujith H @ 2016-09-12 6:13 UTC (permalink / raw)
To: openembedded-core
From: Fahad Usman <fahad_usman@mentor.com>
This change help fix the warning message:
x264/r2491+gitAUTOINC+c8a773ebfc-r0/packages-split/x264/usr/lib/libx264.so.144' has relocations in .text [textrel]
Adding textrel to INSANE_SKIP resolves this issue.
Signed-off-by: Fahad Usman <fahad_usman@mentor.com>
---
meta/recipes-multimedia/x264/x264_git.bb | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-multimedia/x264/x264_git.bb b/meta/recipes-multimedia/x264/x264_git.bb
index fa44f9c..379961a 100644
--- a/meta/recipes-multimedia/x264/x264_git.bb
+++ b/meta/recipes-multimedia/x264/x264_git.bb
@@ -48,6 +48,7 @@ do_install() {
oe_runmake install DESTDIR=${D}
}
-# PIC can't be enabled for 32-bit x86
+# PIC can't be enabled for 32-bit x86 and cyclone5
INSANE_SKIP_${PN}_append_x86 = " textrel"
+INSANE_SKIP_${PN}_append_cyclone5 = " textrel"
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] x264: add textrel to INSANE_SKIP for cyclone5 machine
2016-09-12 6:13 [PATCH] x264: add textrel to INSANE_SKIP for cyclone5 machine Sujith H
@ 2016-09-14 23:11 ` Burton, Ross
2016-09-15 4:43 ` sujith h
0 siblings, 1 reply; 5+ messages in thread
From: Burton, Ross @ 2016-09-14 23:11 UTC (permalink / raw)
To: Sujith H; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 390 bytes --]
On 12 September 2016 at 07:13, Sujith H <sujith.h@gmail.com> wrote:
> +# PIC can't be enabled for 32-bit x86 and cyclone5
> INSANE_SKIP_${PN}_append_x86 = " textrel"
> +INSANE_SKIP_${PN}_append_cyclone5 = " textrel"
>
Can this be generalised or is it absolutely specific to cyclone5? If it
can't be generalised then I feel that this should belong in the cyclone5
BSP.
Ross
[-- Attachment #2: Type: text/html, Size: 876 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] x264: add textrel to INSANE_SKIP for cyclone5 machine
2016-09-14 23:11 ` Burton, Ross
@ 2016-09-15 4:43 ` sujith h
2016-09-15 6:45 ` sujith h
0 siblings, 1 reply; 5+ messages in thread
From: sujith h @ 2016-09-15 4:43 UTC (permalink / raw)
To: Burton, Ross; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 841 bytes --]
On Thu, Sep 15, 2016 at 4:41 AM, Burton, Ross <ross.burton@intel.com> wrote:
>
> On 12 September 2016 at 07:13, Sujith H <sujith.h@gmail.com> wrote:
>
>> +# PIC can't be enabled for 32-bit x86 and cyclone5
>> INSANE_SKIP_${PN}_append_x86 = " textrel"
>> +INSANE_SKIP_${PN}_append_cyclone5 = " textrel"
>>
>
> Can this be generalised or is it absolutely specific to cyclone5? If it
> can't be generalised then I feel that this should belong in the cyclone5
> BSP.
>
We found this with cyclone5 BSP. I will try to figure out how if we can see
it with qemuarm or other BSP's too.
>
> Ross
>
--
സുജിത് ഹരിദാസന്
Bangalore
<Project>Contributor to KDE project
<Project>Contributor to Yocto project
http://fci.wikia.com/wiki/Anti-DRM-Campaign
<Blog> http://sujithh.info
C-x C-c
[-- Attachment #2: Type: text/html, Size: 2118 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] x264: add textrel to INSANE_SKIP for cyclone5 machine
2016-09-15 4:43 ` sujith h
@ 2016-09-15 6:45 ` sujith h
2016-09-15 8:00 ` sujith h
0 siblings, 1 reply; 5+ messages in thread
From: sujith h @ 2016-09-15 6:45 UTC (permalink / raw)
To: Burton, Ross; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 1421 bytes --]
On Thu, Sep 15, 2016 at 10:13 AM, sujith h <sujith.h@gmail.com> wrote:
>
>
> On Thu, Sep 15, 2016 at 4:41 AM, Burton, Ross <ross.burton@intel.com>
> wrote:
>
>>
>> On 12 September 2016 at 07:13, Sujith H <sujith.h@gmail.com> wrote:
>>
>>> +# PIC can't be enabled for 32-bit x86 and cyclone5
>>> INSANE_SKIP_${PN}_append_x86 = " textrel"
>>> +INSANE_SKIP_${PN}_append_cyclone5 = " textrel"
>>>
>>
>> Can this be generalised or is it absolutely specific to cyclone5? If it
>> can't be generalised then I feel that this should belong in the cyclone5
>> BSP.
>>
>
> We found this with cyclone5 BSP. I will try to figure out how if we can
> see it with qemuarm or other BSP's too.
>
I tried with qemuarm, it wasn't reproducible. But with imx6qsabresd from
meta-fsl-arm, it was reproducible. So I believe we can generalize this
patch. I will send the updated one shortly. Thanks for the pointer Ross.
>
>>
>> Ross
>>
>
>
>
> --
> സുജിത് ഹരിദാസന്
> Bangalore
> <Project>Contributor to KDE project
> <Project>Contributor to Yocto project
> http://fci.wikia.com/wiki/Anti-DRM-Campaign
> <Blog> http://sujithh.info
> C-x C-c
>
--
സുജിത് ഹരിദാസന്
Bangalore
<Project>Contributor to KDE project
<Project>Contributor to Yocto project
http://fci.wikia.com/wiki/Anti-DRM-Campaign
<Blog> http://sujithh.info
C-x C-c
[-- Attachment #2: Type: text/html, Size: 3656 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] x264: add textrel to INSANE_SKIP for cyclone5 machine
2016-09-15 6:45 ` sujith h
@ 2016-09-15 8:00 ` sujith h
0 siblings, 0 replies; 5+ messages in thread
From: sujith h @ 2016-09-15 8:00 UTC (permalink / raw)
To: Burton, Ross; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 2027 bytes --]
On Thu, Sep 15, 2016 at 12:15 PM, sujith h <sujith.h@gmail.com> wrote:
>
>
> On Thu, Sep 15, 2016 at 10:13 AM, sujith h <sujith.h@gmail.com> wrote:
>
>>
>>
>> On Thu, Sep 15, 2016 at 4:41 AM, Burton, Ross <ross.burton@intel.com>
>> wrote:
>>
>>>
>>> On 12 September 2016 at 07:13, Sujith H <sujith.h@gmail.com> wrote:
>>>
>>>> +# PIC can't be enabled for 32-bit x86 and cyclone5
>>>> INSANE_SKIP_${PN}_append_x86 = " textrel"
>>>> +INSANE_SKIP_${PN}_append_cyclone5 = " textrel"
>>>>
>>>
>>> Can this be generalised or is it absolutely specific to cyclone5? If it
>>> can't be generalised then I feel that this should belong in the cyclone5
>>> BSP.
>>>
>>
>> We found this with cyclone5 BSP. I will try to figure out how if we can
>> see it with qemuarm or other BSP's too.
>>
>
> I tried with qemuarm, it wasn't reproducible. But with imx6qsabresd from
> meta-fsl-arm, it was reproducible. So I believe we can generalize this
> patch. I will send the updated one shortly. Thanks for the pointer Ross.
>
I forgot to mention that I posted this change in meta-altera for review. I
got the feedback from meta-altera to post the change for review here:
https://github.com/kraj/meta-altera/pull/37. Sharing this for the reference.
>
>>
>>>
>>> Ross
>>>
>>
>>
>>
>> --
>> സുജിത് ഹരിദാസന്
>> Bangalore
>> <Project>Contributor to KDE project
>> <Project>Contributor to Yocto project
>> http://fci.wikia.com/wiki/Anti-DRM-Campaign
>> <Blog> http://sujithh.info
>> C-x C-c
>>
>
>
>
> --
> സുജിത് ഹരിദാസന്
> Bangalore
> <Project>Contributor to KDE project
> <Project>Contributor to Yocto project
> http://fci.wikia.com/wiki/Anti-DRM-Campaign
> <Blog> http://sujithh.info
> C-x C-c
>
--
സുജിത് ഹരിദാസന്
Bangalore
<Project>Contributor to KDE project
<Project>Contributor to Yocto project
http://fci.wikia.com/wiki/Anti-DRM-Campaign
<Blog> http://sujithh.info
C-x C-c
[-- Attachment #2: Type: text/html, Size: 5127 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-09-15 8:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-12 6:13 [PATCH] x264: add textrel to INSANE_SKIP for cyclone5 machine Sujith H
2016-09-14 23:11 ` Burton, Ross
2016-09-15 4:43 ` sujith h
2016-09-15 6:45 ` sujith h
2016-09-15 8:00 ` sujith h
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox