Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Beth 'pidge' Flanagan <pidge@toganlabs.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] classes/license: copy licenses even if there are no checksummed files
Date: Wed, 02 Nov 2016 22:42:33 +0000	[thread overview]
Message-ID: <1478126553.32080.27.camel@toganlabs.com> (raw)
In-Reply-To: <CAJTo0LZ-LDz2_=g73WRQQCg3Hv32CYONnu-WbzDrOOJKmRa4hQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1067 bytes --]

On Wed, 2016-11-02 at 20:22 +0000, Burton, Ross wrote:
> 
> On 2 November 2016 at 18:37, Beth 'pidge' Flanagan 
> om> wrote:
> > It's been a bit since I've looked at license.bbclass, but I guess
> > my
> > question here is this seems to take out all notification that a
> > recipe
> > doesn't have a LIC_FILES_CHKSUM, correct?
> > 
> > I'd rather we maybe kept the note in and maybe whitelisted recipes
> > that
> > did interesting things so that didn't appear than just ignored when
> > a
> > recipe was missing it. 
> > 
> > Because if we don't at least bb.note it, I can see people just
> > ignoring
> > it entirely (which would be bad in a lot of ways)
> > 
> No, this check was belt-and-braces (the other check is a
> bb.error()).  Also bb.note() from tasks don't appear in the user-
> visible log by default, you've got to dig into the task log to see
> them which is buried in the work directories.
Ah, correct (I generally see them since I'm piping most of the time).
Ok, in that case then yes, that makes sense.
-b
> > Ross
> 

[-- Attachment #2: Type: text/html, Size: 1598 bytes --]

  reply	other threads:[~2016-11-02 23:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-02 15:07 [PATCH] classes/license: copy licenses even if there are no checksummed files Ross Burton
2016-11-02 18:37 ` Beth 'pidge' Flanagan
2016-11-02 20:22   ` Burton, Ross
2016-11-02 22:42     ` Beth 'pidge' Flanagan [this message]
2016-11-02 20:42 ` Burton, Ross
  -- strict thread matches above, loose matches on Subject: below --
2016-11-02 22:58 Ross Burton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478126553.32080.27.camel@toganlabs.com \
    --to=pidge@toganlabs.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox