Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Phil Blundell <pb@pbcl.net>
To: Khem Raj <raj.khem@gmail.com>, Li Zhou <li.zhou@windriver.com>,
	 openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] db: disable the ARM assembler mutex code
Date: Sat, 05 Nov 2016 00:01:37 +0000	[thread overview]
Message-ID: <1478304097.3662.25.camel@pbcl.net> (raw)
In-Reply-To: <3ceaa47d-7f30-4b0a-f554-eb193a10f82a@gmail.com>

On Fri, 2016-11-04 at 16:55 -0700, Khem Raj wrote:
> 
> yes I meant <= v5, it should work usually, I am just thinking its a
> untested
> option, it may not be as bad as I think but some testing might be
> useful

Well, I admit I haven't looked at the actual code, but from the
comments in the patch I get the impression that it just causes db to
use the same code (i.e. pthread_mutex_xx) on ARM as it already was
doing on every other architecture.  I think it's safe to say that
pthread_mutex_lock() on ARM probably does work, otherwise any number of
programs would be broken, and db probably does work with
pthread_mutex_lock generically otherwise it would be broken on x86 and
so on.

You're right of course that this specific combination could do with
some testing but all in all it seems like a fairly low-risk change.

p.



  reply	other threads:[~2016-11-05  0:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-04  9:07 [PATCH] db: disable the ARM assembler mutex code Li Zhou
2016-11-04  9:43 ` Zhou, Li
2016-11-04 16:12 ` Leonardo Sandoval
2016-11-04 18:18   ` Mark Hatle
2016-11-04 18:22 ` Khem Raj
2016-11-04 20:29   ` Burton, Ross
     [not found]     ` <CAMKF1sp=ZHOP4aY7r11kvURBymq4+uknmeiSGQyP9BUpW_WXBQ@mail.gmail.com>
2016-11-04 21:47       ` Khem Raj
2016-11-04 23:14   ` Phil Blundell
2016-11-04 23:55     ` Khem Raj
2016-11-05  0:01       ` Phil Blundell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-11-04  9:12 Li Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478304097.3662.25.camel@pbcl.net \
    --to=pb@pbcl.net \
    --cc=li.zhou@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox