Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: Li Zhou <li.zhou@windriver.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] db: disable the ARM assembler mutex code
Date: Fri, 4 Nov 2016 11:22:31 -0700	[thread overview]
Message-ID: <b3c8d5de-1d26-b37b-e28c-f8cca01c9ba3@gmail.com> (raw)
In-Reply-To: <20161104090719.30795-1-li.zhou@windriver.com>


[-- Attachment #1.1: Type: text/plain, Size: 1533 bytes --]



On 11/4/16 2:07 AM, Li Zhou wrote:
> The swpb in macro MUTEX_SET will cause "undefined instruction" error
> on the new arm arches which don't support this assembly instruction
> any more. If use ldrex/strex to replace swpb, the old arm arches don't
> support them. So to avoid this issue, just disable the ARM assembler
> mutex code, and use the default pthreads mutex.
> 
> Signed-off-by: Li Zhou <li.zhou@windriver.com>
> ---
>  meta/recipes-support/db/db_6.0.30.bb | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/meta/recipes-support/db/db_6.0.30.bb b/meta/recipes-support/db/db_6.0.30.bb
> index 50a469b..2d08b5e 100644
> --- a/meta/recipes-support/db/db_6.0.30.bb
> +++ b/meta/recipes-support/db/db_6.0.30.bb
> @@ -74,15 +74,6 @@ DB6_CONFIG ?= "--enable-o_direct --disable-cryptography --disable-queue --disabl
>  
>  EXTRA_OECONF = "${DB6_CONFIG} --enable-shared --enable-cxx --with-sysroot"
>  
> -# Override the MUTEX setting here, the POSIX library is
> -# the default - "POSIX/pthreads/library".
> -# Don't ignore the nice SWP instruction on the ARM:
> -# These enable the ARM assembler mutex code
> -ARM_MUTEX = "--with-mutex=ARM/gcc-assembly"
> -MUTEX = ""
> -MUTEX_arm = "${ARM_MUTEX}"
> -MUTEX_armeb = "${ARM_MUTEX}"
> -EXTRA_OECONF += "${MUTEX}"

it would be good to keep this for older < armv5 arches

>  EXTRA_OEMAKE_class-target = "LIBTOOL=${STAGING_BINDIR_CROSS}/${HOST_SYS}-libtool"
>  
>  # Cancel the site stuff - it's set for db3 and destroys the
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

  parent reply	other threads:[~2016-11-04 18:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-04  9:07 [PATCH] db: disable the ARM assembler mutex code Li Zhou
2016-11-04  9:43 ` Zhou, Li
2016-11-04 16:12 ` Leonardo Sandoval
2016-11-04 18:18   ` Mark Hatle
2016-11-04 18:22 ` Khem Raj [this message]
2016-11-04 20:29   ` Burton, Ross
     [not found]     ` <CAMKF1sp=ZHOP4aY7r11kvURBymq4+uknmeiSGQyP9BUpW_WXBQ@mail.gmail.com>
2016-11-04 21:47       ` Khem Raj
2016-11-04 23:14   ` Phil Blundell
2016-11-04 23:55     ` Khem Raj
2016-11-05  0:01       ` Phil Blundell
  -- strict thread matches above, loose matches on Subject: below --
2016-11-04  9:12 Li Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b3c8d5de-1d26-b37b-e28c-f8cca01c9ba3@gmail.com \
    --to=raj.khem@gmail.com \
    --cc=li.zhou@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox