* [PATCH] added recipe for libdbus-c++
@ 2016-11-15 13:46 Thilo Cestonaro
2016-11-15 14:05 ` Alexander Kanavin
2016-11-15 14:23 ` Burton, Ross
0 siblings, 2 replies; 4+ messages in thread
From: Thilo Cestonaro @ 2016-11-15 13:46 UTC (permalink / raw)
To: openembedded-core
Signed-off-by: Thilo Cestonaro <thilo.cestonaro@ts.fujitsu.com>
---
.../fix-missing-unistd.h-include.patch | 12 +
.../remove-CXX_FOR_BUILD-stuff.patch | 257 +++++++++++++++++++++
meta/recipes-core/dbus/libdbus-c++_0.9.0.bb | 24 ++
3 files changed, 293 insertions(+)
create mode 100644 meta/recipes-core/dbus/libdbus-c++-0.9.0/fix-missing-unistd.h-include.patch
create mode 100644 meta/recipes-core/dbus/libdbus-c++-0.9.0/remove-CXX_FOR_BUILD-stuff.patch
create mode 100644 meta/recipes-core/dbus/libdbus-c++_0.9.0.bb
diff --git a/meta/recipes-core/dbus/libdbus-c++-0.9.0/fix-missing-unistd.h-include.patch b/meta/recipes-core/dbus/libdbus-c++-0.9.0/fix-missing-unistd.h-include.patch
new file mode 100644
index 0000000..5cb8096
--- /dev/null
+++ b/meta/recipes-core/dbus/libdbus-c++-0.9.0/fix-missing-unistd.h-include.patch
@@ -0,0 +1,12 @@
+diff --git a/include/dbus-c++/eventloop-integration.h b/include/dbus-c++/eventloop-integration.h
+index 1b0302e..3e44304 100644
+--- a/include/dbus-c++/eventloop-integration.h
++++ b/include/dbus-c++/eventloop-integration.h
+@@ -26,6 +26,7 @@
+ #define __DBUSXX_EVENTLOOP_INTEGRATION_H
+
+ #include <errno.h>
++#include <unistd.h>
+ #include "api.h"
+ #include "dispatcher.h"
+ #include "util.h"
diff --git a/meta/recipes-core/dbus/libdbus-c++-0.9.0/remove-CXX_FOR_BUILD-stuff.patch b/meta/recipes-core/dbus/libdbus-c++-0.9.0/remove-CXX_FOR_BUILD-stuff.patch
new file mode 100644
index 0000000..af87174
--- /dev/null
+++ b/meta/recipes-core/dbus/libdbus-c++-0.9.0/remove-CXX_FOR_BUILD-stuff.patch
@@ -0,0 +1,257 @@
+diff -Naur libdbus-c++-0.9.0.ori/configure libdbus-c++-0.9.0/configure
+--- libdbus-c++-0.9.0.ori/configure 2016-11-15 14:25:36.085882774 +0100
++++ libdbus-c++-0.9.0/configure 2016-11-15 14:27:55.402913346 +0100
+@@ -800,7 +800,6 @@
+ GREP
+ SED
+ LIBTOOL
+-CXX_FOR_BUILD
+ am__fastdepCXX_FALSE
+ am__fastdepCXX_TRUE
+ CXXDEPMODE
+@@ -5233,8 +5232,6 @@
+
+
+
+-CXX_FOR_BUILD=${CXX_FOR_BUILD-${CXX}}
+-
+
+ case `pwd` in
+ *\ * | *\ *)
+diff -Naur libdbus-c++-0.9.0.ori/configure.ac libdbus-c++-0.9.0/configure.ac
+--- libdbus-c++-0.9.0.ori/configure.ac 2016-11-15 14:25:36.085882774 +0100
++++ libdbus-c++-0.9.0/configure.ac 2016-11-15 14:27:08.814568717 +0100
+@@ -64,9 +64,6 @@
+ AC_PROG_CC
+ AC_PROG_CXX
+
+-CXX_FOR_BUILD=${CXX_FOR_BUILD-${CXX}}
+-AC_SUBST(CXX_FOR_BUILD)
+-
+ AM_PROG_LIBTOOL
+
+ PKG_PROG_PKG_CONFIG
+diff -Naur libdbus-c++-0.9.0.ori/data/Makefile.in libdbus-c++-0.9.0/data/Makefile.in
+--- libdbus-c++-0.9.0.ori/data/Makefile.in 2016-11-15 14:25:36.085882774 +0100
++++ libdbus-c++-0.9.0/data/Makefile.in 2016-11-15 14:26:59.746501637 +0100
+@@ -66,7 +66,6 @@
+ CXXCPP = @CXXCPP@
+ CXXDEPMODE = @CXXDEPMODE@
+ CXXFLAGS = @CXXFLAGS@
+-CXX_FOR_BUILD = @CXX_FOR_BUILD@
+ CYGPATH_W = @CYGPATH_W@
+ DEFS = @DEFS@
+ DEPDIR = @DEPDIR@
+diff -Naur libdbus-c++-0.9.0.ori/doc/Makefile.in libdbus-c++-0.9.0/doc/Makefile.in
+--- libdbus-c++-0.9.0.ori/doc/Makefile.in 2016-11-15 14:25:36.085882774 +0100
++++ libdbus-c++-0.9.0/doc/Makefile.in 2016-11-15 14:27:33.790753474 +0100
+@@ -67,7 +67,6 @@
+ CXXCPP = @CXXCPP@
+ CXXDEPMODE = @CXXDEPMODE@
+ CXXFLAGS = @CXXFLAGS@
+-CXX_FOR_BUILD = @CXX_FOR_BUILD@
+ CYGPATH_W = @CYGPATH_W@
+ DEFS = @DEFS@
+ DEPDIR = @DEPDIR@
+diff -Naur libdbus-c++-0.9.0.ori/examples/echo/Makefile.in libdbus-c++-0.9.0/examples/echo/Makefile.in
+--- libdbus-c++-0.9.0.ori/examples/echo/Makefile.in 2016-11-15 14:25:36.089882803 +0100
++++ libdbus-c++-0.9.0/examples/echo/Makefile.in 2016-11-15 14:26:28.722272141 +0100
+@@ -105,7 +105,6 @@
+ CXXCPP = @CXXCPP@
+ CXXDEPMODE = @CXXDEPMODE@
+ CXXFLAGS = @CXXFLAGS@
+-CXX_FOR_BUILD = @CXX_FOR_BUILD@
+ CYGPATH_W = @CYGPATH_W@
+ DEFS = @DEFS@
+ DEPDIR = @DEPDIR@
+diff -Naur libdbus-c++-0.9.0.ori/examples/echo_ecore/Makefile.in libdbus-c++-0.9.0/examples/echo_ecore/Makefile.in
+--- libdbus-c++-0.9.0.ori/examples/echo_ecore/Makefile.in 2016-11-15 14:25:36.089882803 +0100
++++ libdbus-c++-0.9.0/examples/echo_ecore/Makefile.in 2016-11-15 14:26:41.446366266 +0100
+@@ -110,7 +110,6 @@
+ CXXCPP = @CXXCPP@
+ CXXDEPMODE = @CXXDEPMODE@
+ CXXFLAGS = @CXXFLAGS@
+-CXX_FOR_BUILD = @CXX_FOR_BUILD@
+ CYGPATH_W = @CYGPATH_W@
+ DEFS = @DEFS@
+ DEPDIR = @DEPDIR@
+diff -Naur libdbus-c++-0.9.0.ori/examples/ecore/Makefile.in libdbus-c++-0.9.0/examples/ecore/Makefile.in
+--- libdbus-c++-0.9.0.ori/examples/ecore/Makefile.in 2016-11-15 14:25:36.089882803 +0100
++++ libdbus-c++-0.9.0/examples/ecore/Makefile.in 2016-11-15 14:26:37.074333925 +0100
+@@ -100,7 +100,6 @@
+ CXXCPP = @CXXCPP@
+ CXXDEPMODE = @CXXDEPMODE@
+ CXXFLAGS = @CXXFLAGS@
+-CXX_FOR_BUILD = @CXX_FOR_BUILD@
+ CYGPATH_W = @CYGPATH_W@
+ DEFS = @DEFS@
+ DEPDIR = @DEPDIR@
+diff -Naur libdbus-c++-0.9.0.ori/examples/glib/Makefile.in libdbus-c++-0.9.0/examples/glib/Makefile.in
+--- libdbus-c++-0.9.0.ori/examples/glib/Makefile.in 2016-11-15 14:25:36.089882803 +0100
++++ libdbus-c++-0.9.0/examples/glib/Makefile.in 2016-11-15 14:26:33.630308448 +0100
+@@ -99,7 +99,6 @@
+ CXXCPP = @CXXCPP@
+ CXXDEPMODE = @CXXDEPMODE@
+ CXXFLAGS = @CXXFLAGS@
+-CXX_FOR_BUILD = @CXX_FOR_BUILD@
+ CYGPATH_W = @CYGPATH_W@
+ DEFS = @DEFS@
+ DEPDIR = @DEPDIR@
+diff -Naur libdbus-c++-0.9.0.ori/examples/hal/Makefile.in libdbus-c++-0.9.0/examples/hal/Makefile.in
+--- libdbus-c++-0.9.0.ori/examples/hal/Makefile.in 2016-11-15 14:25:36.089882803 +0100
++++ libdbus-c++-0.9.0/examples/hal/Makefile.in 2016-11-15 14:26:55.014466633 +0100
+@@ -96,7 +96,6 @@
+ CXXCPP = @CXXCPP@
+ CXXDEPMODE = @CXXDEPMODE@
+ CXXFLAGS = @CXXFLAGS@
+-CXX_FOR_BUILD = @CXX_FOR_BUILD@
+ CYGPATH_W = @CYGPATH_W@
+ DEFS = @DEFS@
+ DEPDIR = @DEPDIR@
+diff -Naur libdbus-c++-0.9.0.ori/examples/Makefile.in libdbus-c++-0.9.0/examples/Makefile.in
+--- libdbus-c++-0.9.0.ori/examples/Makefile.in 2016-11-15 14:25:36.089882803 +0100
++++ libdbus-c++-0.9.0/examples/Makefile.in 2016-11-15 14:26:46.122400856 +0100
+@@ -106,7 +106,6 @@
+ CXXCPP = @CXXCPP@
+ CXXDEPMODE = @CXXDEPMODE@
+ CXXFLAGS = @CXXFLAGS@
+-CXX_FOR_BUILD = @CXX_FOR_BUILD@
+ CYGPATH_W = @CYGPATH_W@
+ DEFS = @DEFS@
+ DEPDIR = @DEPDIR@
+diff -Naur libdbus-c++-0.9.0.ori/examples/properties/Makefile.in libdbus-c++-0.9.0/examples/properties/Makefile.in
+--- libdbus-c++-0.9.0.ori/examples/properties/Makefile.in 2016-11-15 14:25:36.089882803 +0100
++++ libdbus-c++-0.9.0/examples/properties/Makefile.in 2016-11-15 14:26:50.818435594 +0100
+@@ -99,7 +99,6 @@
+ CXXCPP = @CXXCPP@
+ CXXDEPMODE = @CXXDEPMODE@
+ CXXFLAGS = @CXXFLAGS@
+-CXX_FOR_BUILD = @CXX_FOR_BUILD@
+ CYGPATH_W = @CYGPATH_W@
+ DEFS = @DEFS@
+ DEPDIR = @DEPDIR@
+diff -Naur libdbus-c++-0.9.0.ori/Makefile.in libdbus-c++-0.9.0/Makefile.in
+--- libdbus-c++-0.9.0.ori/Makefile.in 2016-11-15 14:25:36.085882774 +0100
++++ libdbus-c++-0.9.0/Makefile.in 2016-11-15 14:27:02.834524481 +0100
+@@ -155,7 +155,6 @@
+ CXXCPP = @CXXCPP@
+ CXXDEPMODE = @CXXDEPMODE@
+ CXXFLAGS = @CXXFLAGS@
+-CXX_FOR_BUILD = @CXX_FOR_BUILD@
+ CYGPATH_W = @CYGPATH_W@
+ DEFS = @DEFS@
+ DEPDIR = @DEPDIR@
+diff -Naur libdbus-c++-0.9.0.ori/src/integration/ecore/Makefile.in libdbus-c++-0.9.0/src/integration/ecore/Makefile.in
+--- libdbus-c++-0.9.0.ori/src/integration/ecore/Makefile.in 2016-11-15 14:25:36.089882803 +0100
++++ libdbus-c++-0.9.0/src/integration/ecore/Makefile.in 2016-11-15 14:27:21.206660385 +0100
+@@ -122,7 +122,6 @@
+ CXXCPP = @CXXCPP@
+ CXXDEPMODE = @CXXDEPMODE@
+ CXXFLAGS = @CXXFLAGS@
+-CXX_FOR_BUILD = @CXX_FOR_BUILD@
+ CYGPATH_W = @CYGPATH_W@
+ DEFS = @DEFS@
+ DEPDIR = @DEPDIR@
+diff -Naur libdbus-c++-0.9.0.ori/src/integration/glib/Makefile.in libdbus-c++-0.9.0/src/integration/glib/Makefile.in
+--- libdbus-c++-0.9.0.ori/src/integration/glib/Makefile.in 2016-11-15 14:25:36.089882803 +0100
++++ libdbus-c++-0.9.0/src/integration/glib/Makefile.in 2016-11-15 14:27:17.274631299 +0100
+@@ -123,7 +123,6 @@
+ CXXCPP = @CXXCPP@
+ CXXDEPMODE = @CXXDEPMODE@
+ CXXFLAGS = @CXXFLAGS@
+-CXX_FOR_BUILD = @CXX_FOR_BUILD@
+ CYGPATH_W = @CYGPATH_W@
+ DEFS = @DEFS@
+ DEPDIR = @DEPDIR@
+diff -Naur libdbus-c++-0.9.0.ori/src/integration/Makefile.in libdbus-c++-0.9.0/src/integration/Makefile.in
+--- libdbus-c++-0.9.0.ori/src/integration/Makefile.in 2016-11-15 14:25:36.089882803 +0100
++++ libdbus-c++-0.9.0/src/integration/Makefile.in 2016-11-15 14:27:23.698678820 +0100
+@@ -106,7 +106,6 @@
+ CXXCPP = @CXXCPP@
+ CXXDEPMODE = @CXXDEPMODE@
+ CXXFLAGS = @CXXFLAGS@
+-CXX_FOR_BUILD = @CXX_FOR_BUILD@
+ CYGPATH_W = @CYGPATH_W@
+ DEFS = @DEFS@
+ DEPDIR = @DEPDIR@
+diff -Naur libdbus-c++-0.9.0.ori/src/Makefile.in libdbus-c++-0.9.0/src/Makefile.in
+--- libdbus-c++-0.9.0.ori/src/Makefile.in 2016-11-15 14:25:36.089882803 +0100
++++ libdbus-c++-0.9.0/src/Makefile.in 2016-11-15 14:27:12.270594283 +0100
+@@ -172,7 +172,6 @@
+ CXXCPP = @CXXCPP@
+ CXXDEPMODE = @CXXDEPMODE@
+ CXXFLAGS = @CXXFLAGS@
+-CXX_FOR_BUILD = @CXX_FOR_BUILD@
+ CYGPATH_W = @CYGPATH_W@
+ DEFS = @DEFS@
+ DEPDIR = @DEPDIR@
+diff -Naur libdbus-c++-0.9.0.ori/test/functional/Makefile.in libdbus-c++-0.9.0/test/functional/Makefile.in
+--- libdbus-c++-0.9.0.ori/test/functional/Makefile.in 2016-11-15 14:25:36.085882774 +0100
++++ libdbus-c++-0.9.0/test/functional/Makefile.in 2016-11-15 14:26:15.126171567 +0100
+@@ -106,7 +106,6 @@
+ CXXCPP = @CXXCPP@
+ CXXDEPMODE = @CXXDEPMODE@
+ CXXFLAGS = @CXXFLAGS@
+-CXX_FOR_BUILD = @CXX_FOR_BUILD@
+ CYGPATH_W = @CYGPATH_W@
+ DEFS = @DEFS@
+ DEPDIR = @DEPDIR@
+diff -Naur libdbus-c++-0.9.0.ori/test/functional/Test1/Makefile.in libdbus-c++-0.9.0/test/functional/Test1/Makefile.in
+--- libdbus-c++-0.9.0.ori/test/functional/Test1/Makefile.in 2016-11-15 14:25:36.085882774 +0100
++++ libdbus-c++-0.9.0/test/functional/Test1/Makefile.in 2016-11-15 14:26:11.670146002 +0100
+@@ -105,7 +105,6 @@
+ CXXCPP = @CXXCPP@
+ CXXDEPMODE = @CXXDEPMODE@
+ CXXFLAGS = @CXXFLAGS@
+-CXX_FOR_BUILD = @CXX_FOR_BUILD@
+ CYGPATH_W = @CYGPATH_W@
+ DEFS = @DEFS@
+ DEPDIR = @DEPDIR@
+diff -Naur libdbus-c++-0.9.0.ori/test/generator/Makefile.in libdbus-c++-0.9.0/test/generator/Makefile.in
+--- libdbus-c++-0.9.0.ori/test/generator/Makefile.in 2016-11-15 14:25:36.085882774 +0100
++++ libdbus-c++-0.9.0/test/generator/Makefile.in 2016-11-15 14:26:02.622079070 +0100
+@@ -114,7 +114,6 @@
+ CXXCPP = @CXXCPP@
+ CXXDEPMODE = @CXXDEPMODE@
+ CXXFLAGS = @CXXFLAGS@
+-CXX_FOR_BUILD = @CXX_FOR_BUILD@
+ CYGPATH_W = @CYGPATH_W@
+ DEFS = @DEFS@
+ DEPDIR = @DEPDIR@
+diff -Naur libdbus-c++-0.9.0.ori/test/Makefile.in libdbus-c++-0.9.0/test/Makefile.in
+--- libdbus-c++-0.9.0.ori/test/Makefile.in 2016-11-15 14:25:36.085882774 +0100
++++ libdbus-c++-0.9.0/test/Makefile.in 2016-11-15 14:26:07.770117152 +0100
+@@ -106,7 +106,6 @@
+ CXXCPP = @CXXCPP@
+ CXXDEPMODE = @CXXDEPMODE@
+ CXXFLAGS = @CXXFLAGS@
+-CXX_FOR_BUILD = @CXX_FOR_BUILD@
+ CYGPATH_W = @CYGPATH_W@
+ DEFS = @DEFS@
+ DEPDIR = @DEPDIR@
+diff -Naur libdbus-c++-0.9.0.ori/tools/Makefile.am libdbus-c++-0.9.0/tools/Makefile.am
+--- libdbus-c++-0.9.0.ori/tools/Makefile.am 2016-11-15 14:25:36.089882803 +0100
++++ libdbus-c++-0.9.0/tools/Makefile.am 2016-11-15 14:26:19.454203583 +0100
+@@ -1,7 +1,5 @@
+ # hacky, but ...
+
+-CXX = $(CXX_FOR_BUILD)
+-
+ AM_CPPFLAGS = \
+ $(dbus_CFLAGS) \
+ $(xml_CFLAGS) \
+diff -Naur libdbus-c++-0.9.0.ori/tools/Makefile.in libdbus-c++-0.9.0/tools/Makefile.in
+--- libdbus-c++-0.9.0.ori/tools/Makefile.in 2016-11-15 14:25:36.089882803 +0100
++++ libdbus-c++-0.9.0/tools/Makefile.in 2016-11-15 14:27:44.306831265 +0100
+@@ -101,11 +101,9 @@
+ CFLAGS = @CFLAGS@
+ CPP = @CPP@
+ CPPFLAGS = @CPPFLAGS@
+-CXX = $(CXX_FOR_BUILD)
+ CXXCPP = @CXXCPP@
+ CXXDEPMODE = @CXXDEPMODE@
+ CXXFLAGS = @CXXFLAGS@
+-CXX_FOR_BUILD = @CXX_FOR_BUILD@
+ CYGPATH_W = @CYGPATH_W@
+ DEFS = @DEFS@
+ DEPDIR = @DEPDIR@
diff --git a/meta/recipes-core/dbus/libdbus-c++_0.9.0.bb b/meta/recipes-core/dbus/libdbus-c++_0.9.0.bb
new file mode 100644
index 0000000..7edaffc
--- /dev/null
+++ b/meta/recipes-core/dbus/libdbus-c++_0.9.0.bb
@@ -0,0 +1,24 @@
+SUMMARY = "DBus-C++ Library"
+DESCRIPTION = "DBus-c++ attempts to provide a C++ API for D-BUS. The library has a glib and an Ecore mainloop integration. It also offers an optional own main loop."
+HOMEPAGE = "http://dbus-cplusplus.sourceforge.net"
+SECTION = "base"
+LICENSE = "LGPLv2.1"
+LIC_FILES_CHKSUM = "file://COPYING;md5=fbc093901857fcd118f065f900982c24"
+DEPENDS = "dbus glib-2.0 libpcre"
+
+SRC_URI = "${SOURCEFORGE_MIRROR}/project/dbus-cplusplus/dbus-c++/${PV}/${BPN}-${PV}.tar.gz \
+ file://fix-missing-unistd.h-include.patch \
+ file://remove-CXX_FOR_BUILD-stuff.patch"
+SRC_URI[md5sum] = "e752116f523fa88ef041e63d3dee4de2"
+SRC_URI[sha256sum] = "bc11ac297b3cb010be904c72789695543ee3fdf3d75cdc8225fd371385af4e61"
+
+EXTRA_OECONF = "--disable-ecore --disable-examples --disable-tests"
+
+inherit autotools pkgconfig
+
+PACKAGES += "${PN}-tools"
+
+FILES_${PN} = "${libdir}"
+FILES_${PN}-tools = "${bindir}"
+
+BBCLASSEXTEND = "native"
--
2.10.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] added recipe for libdbus-c++
2016-11-15 13:46 [PATCH] added recipe for libdbus-c++ Thilo Cestonaro
@ 2016-11-15 14:05 ` Alexander Kanavin
2016-11-15 14:23 ` Burton, Ross
1 sibling, 0 replies; 4+ messages in thread
From: Alexander Kanavin @ 2016-11-15 14:05 UTC (permalink / raw)
To: openembedded-core
On 11/15/2016 03:46 PM, Thilo Cestonaro wrote:
> Signed-off-by: Thilo Cestonaro <thilo.cestonaro@ts.fujitsu.com>
> ---
> .../fix-missing-unistd.h-include.patch | 12 +
> .../remove-CXX_FOR_BUILD-stuff.patch | 257 +++++++++++++++++++++
> meta/recipes-core/dbus/libdbus-c++_0.9.0.bb | 24 ++
The whole thing should go to meta-openembedded (mailing list
openembedded-devel). Patches are missing description of what they are
for, and Upstream-Status, and Signed-off-by lines. Follow this please:
http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Alex
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] added recipe for libdbus-c++
2016-11-15 13:46 [PATCH] added recipe for libdbus-c++ Thilo Cestonaro
2016-11-15 14:05 ` Alexander Kanavin
@ 2016-11-15 14:23 ` Burton, Ross
2016-11-15 15:27 ` thilo.cestonaro
1 sibling, 1 reply; 4+ messages in thread
From: Burton, Ross @ 2016-11-15 14:23 UTC (permalink / raw)
To: Thilo Cestonaro; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]
On 15 November 2016 at 13:46, Thilo Cestonaro <
thilo.cestonaro@ts.fujitsu.com> wrote:
> Signed-off-by: Thilo Cestonaro <thilo.cestonaro@ts.fujitsu.com>
>
As Alex said, please submit this to meta-oe as there's no strong rationale
to keep it in oe-core, especially considering it's abandoned.
The remove_CXX_FOR_BUILD-stuff patch can be trimmed to just modify
configure.ac and tools/Makefile.am, the other files will be regenerated at
do_configure and patching them can cause conflicts if upstream ever makes a
new release.
Also please explain clearly why that has to be removed in the patch header
because usually we need to patch *in* the _FOR_BUILD macros: I was curious
and ended up looking at the build to understand why. AFAICT it's because
upstream if cross-compiling it refuses to build target tools and will only
build host tools so the test suite can run, but disabling the tests and
patching out CXX_FOR_BUILD we can build target tools. The downside is that
we have no test suite, which is useful (see the ptest class).
Thank you for being the first person in a long time to actually submit the
recipe to the community!
Ross
[-- Attachment #2: Type: text/html, Size: 1868 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] added recipe for libdbus-c++
2016-11-15 14:23 ` Burton, Ross
@ 2016-11-15 15:27 ` thilo.cestonaro
0 siblings, 0 replies; 4+ messages in thread
From: thilo.cestonaro @ 2016-11-15 15:27 UTC (permalink / raw)
To: ross.burton@intel.com; +Cc: openembedded-core@lists.openembedded.org
[-- Attachment #1: Type: text/plain, Size: 1366 bytes --]
Am Dienstag, den 15.11.2016, 14:23 +0000 schrieb Burton, Ross:
>
> On 15 November 2016 at 13:46, Thilo Cestonaro <thilo.cestonaro@ts.fujitsu.com> wrote:
> > Signed-off-by: Thilo Cestonaro <thilo.cestonaro@ts.fujitsu.com>
> >
>
> As Alex said, please submit this to meta-oe as there's no strong rationale to keep it in oe-core, especially considering it's abandoned.
>
> The remove_CXX_FOR_BUILD-stuff patch can be trimmed to just modify configure.ac and tools/Makefile.am, the other files will be regenerated at do_configure and patching them can cause conflicts if
> upstream ever makes a new release.
>
> Also please explain clearly why that has to be removed in the patch header because usually we need to patch *in* the _FOR_BUILD macros: I was curious and ended up looking at the build to understand
> why. AFAICT it's because upstream if cross-compiling it refuses to build target tools and will only build host tools so the test suite can run, but disabling the tests and patching out CXX_FOR_BUILD
> we can build target tools. The downside is that we have no test suite, which is useful (see the ptest class).
Perhaps I will add ptest in another patch later. Will need to look into it.
Thanks for your comments!
>
> Thank you for being the first person in a long time to actually submit the recipe to the community!
>
> Ross
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3847 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-15 15:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-15 13:46 [PATCH] added recipe for libdbus-c++ Thilo Cestonaro
2016-11-15 14:05 ` Alexander Kanavin
2016-11-15 14:23 ` Burton, Ross
2016-11-15 15:27 ` thilo.cestonaro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox