Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] targetloader.py: drop test for ClassType
@ 2016-12-10 17:21 Juro Bystricky
  0 siblings, 0 replies; only message in thread
From: Juro Bystricky @ 2016-12-10 17:21 UTC (permalink / raw)
  To: openembedded-core; +Cc: richard.purdie

ClassType was removed from python3.
The code testing for ClassType kept throwing AttributeError exceptions:

    module 'types' has no attribute 'ClassType'

The exceptions prevented loading of any dynamically resolved target
controllers.

Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
---
 meta/lib/oeqa/controllers/testtargetloader.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/meta/lib/oeqa/controllers/testtargetloader.py b/meta/lib/oeqa/controllers/testtargetloader.py
index a1b7b1d..b51d04b 100644
--- a/meta/lib/oeqa/controllers/testtargetloader.py
+++ b/meta/lib/oeqa/controllers/testtargetloader.py
@@ -61,8 +61,6 @@ class TestTargetLoader:
             obj = getattr(module, target)
             if obj: 
                 from oeqa.targetcontrol import BaseTarget
-                if (not isinstance(obj, (type, types.ClassType))):
-                    bb.warn("Target {0} found, but not of type Class".format(target))
                 if( not issubclass(obj, BaseTarget)):
                     bb.warn("Target {0} found, but subclass is not BaseTarget".format(target))
         except:
-- 
2.7.4



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-12-10 17:24 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-10 17:21 [PATCH] targetloader.py: drop test for ClassType Juro Bystricky

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox