[PATCH] zlib: update SRC_URI to fix fetching

[PATCH] zlib: update SRC_URI to fix fetching

[Joshua Lock]

Upstream have removed the file from zlib.net as a new version has
been released, switch to fetching from the official sourceforge
mirror.

[YOCTO #10879]

Signed-off-by: Joshua Lock <joshua.g.lock@intel.com>
---
 meta/recipes-core/zlib/zlib_1.2.8.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/zlib/zlib_1.2.8.bb b/meta/recipes-core/zlib/zlib_1.2.8.bb
index 9470adb..913c703 100644
--- a/meta/recipes-core/zlib/zlib_1.2.8.bb
+++ b/meta/recipes-core/zlib/zlib_1.2.8.bb
@@ -6,7 +6,7 @@ SECTION = "libs"
 LICENSE = "Zlib"
 LIC_FILES_CHKSUM = "file://zlib.h;beginline=4;endline=23;md5=fde612df1e5933c428b73844a0c494fd"
 
-SRC_URI = "http://www.zlib.net/${BPN}-${PV}.tar.xz \
+SRC_URI = "${SOURCEFORGE_MIRROR}/libpng/${BPN}/${PV}/${BPN}-${PV}.tar.xz \
            file://remove.ldconfig.call.patch \
            file://Makefile-runtests.patch \
            file://ldflags-tests.patch \
-- 
2.9.3

Re: [PATCH] zlib: update SRC_URI to fix fetching

[Alexander Kanavin]

On 01/05/2017 06:34 PM, Joshua Lock wrote:
> Upstream have removed the file from zlib.net as a new version has
> been released, switch to fetching from the official sourceforge
> mirror.
>
> [YOCTO #10879]

If a new version has been released, you should also update to that 
version. Also, does upstream version check (-c checkpkg) still work with 
the new SRC_URI?

Alex

Re: [PATCH] zlib: update SRC_URI to fix fetching

[Alexander Kanavin]

On 01/09/2017 02:56 PM, Alexander Kanavin wrote:
> On 01/05/2017 06:34 PM, Joshua Lock wrote:
>> Upstream have removed the file from zlib.net as a new version has
>> been released, switch to fetching from the official sourceforge
>> mirror.
>>
>> [YOCTO #10879]
>
> If a new version has been released, you should also update to that
> version. Also, does upstream version check (-c checkpkg) still work with
> the new SRC_URI?

Actually it doesn't, accordingly we have no way of knowing if zlib has a 
new version upstream. Please do check these things when you update SRC_URI.

Alex

Re: [PATCH] zlib: update SRC_URI to fix fetching

[Joshua Lock]

> On Fri, 2017-01-13 at 15:00 +0200, Alexander Kanavin wrote:
> On 01/09/2017 02:56 PM, Alexander Kanavin wrote:
> > On 01/05/2017 06:34 PM, Joshua Lock wrote:
> > > Upstream have removed the file from zlib.net as a new version has
> > > been released, switch to fetching from the official sourceforge
> > > mirror.
> > > 
> > > [YOCTO #10879]
> > 
> > If a new version has been released, you should also update to that
> > version. Also, does upstream version check (-c checkpkg) still work
> > with
> > the new SRC_URI?
> 
> Actually it doesn't, accordingly we have no way of knowing if zlib
> has a 
> new version upstream. Please do check these things when you update
> SRC_URI.

Noted, thanks. Do we maintain a list of things we'd like people to
check, and how to do it, when making updates to recipes?

checkpkg isn't available by default (had to add distrodata to INHERITS)
and it took me a while to realise the results are written to a file I
have to check. If we expect people to run these checks before
submitting updates we'd best make it as easy as possible to know what
the checks are and how to run them.

The only reference I can find to checkpkg on the OE and YP wikis is
here:

https://wiki.yoctoproject.org/wiki/How_do_I#Q:_How_do_I_ensure_that_I_a
m_using_the_latest_upstream_version_of_the_package.3F

Joshua

Re: [PATCH] zlib: update SRC_URI to fix fetching

[Alexander Kanavin]

On 01/13/2017 03:51 PM, Lock, Joshua G wrote:

> Noted, thanks. Do we maintain a list of things we'd like people to
> check, and how to do it, when making updates to recipes?

I don't think there's such a list, perhaps we should make one and place 
it in patch guidelines wiki.

> checkpkg isn't available by default (had to add distrodata to INHERITS)
> and it took me a while to realise the results are written to a file I
> have to check. If we expect people to run these checks before
> submitting updates we'd best make it as easy as possible to know what
> the checks are and how to run them.

I think this particular check should be automated and run in package_qa, 
if it's okay to access the network in that step. Is it?

Alternatively, if checkuri is regularly run somewhere, then checkpkg 
should be as well.


Alex

Re: [PATCH] zlib: update SRC_URI to fix fetching

[Joshua Lock]

On Fri, 2017-01-13 at 16:18 +0200, Alexander Kanavin wrote:
> On 01/13/2017 03:51 PM, Lock, Joshua G wrote:
> 
> > Noted, thanks. Do we maintain a list of things we'd like people to
> > check, and how to do it, when making updates to recipes?
> 
> I don't think there's such a list, perhaps we should make one and
> place 
> it in patch guidelines wiki.

I think we should, yes please.

> > checkpkg isn't available by default (had to add distrodata to
> > INHERITS)
> > and it took me a while to realise the results are written to a file
> > I
> > have to check. If we expect people to run these checks before
> > submitting updates we'd best make it as easy as possible to know
> > what
> > the checks are and how to run them.
> 
> I think this particular check should be automated and run in
> package_qa, 
> if it's okay to access the network in that step. Is it?

I don't think we should be accessing the network during package_qa.

> Alternatively, if checkuri is regularly run somewhere, then checkpkg 
> should be as well.

We run checkuri on the autobuilders and checkpkg is used by the recipe
report tool, though that's run less frequently. 

Running checkpkg on the autobuilders won't really help as the
autobuilders rely on the bitbake invocation returning a non-zero exit
code to determine whether to mark the build step as failed, and that's
not the case when checkpkg doesn't find an update version.

If we regularly run checkpkg on the autobuilders how should we detect
that a SRC_URI change has caused the upstream version check to fail?

Joshua

Re: [PATCH] zlib: update SRC_URI to fix fetching

[Alexander Kanavin]

On 01/13/2017 05:36 PM, Joshua Lock wrote:

> Running checkpkg on the autobuilders won't really help as the
> autobuilders rely on the bitbake invocation returning a non-zero exit
> code to determine whether to mark the build step as failed, and that's
> not the case when checkpkg doesn't find an update version.
>
> If we regularly run checkpkg on the autobuilders how should we detect
> that a SRC_URI change has caused the upstream version check to fail?

- run bitbake -c checkpkg world
- inspect tmp/log/checkpkg.csv for lines with 'UNKNOWN' upstream status, 
make a list of recipes that have it
- compare that list against a stored list of exceptions (currently it 
would have about 32 entries), if the lists don't match exactly, the 
upstream version check has failed.

All of this can be wrapped in poky/scripts/upstream-check-all perhaps.

Alex

Re: [PATCH] zlib: update SRC_URI to fix fetching

[Joshua Lock]

On Fri, 2017-01-13 at 17:53 +0200, Alexander Kanavin wrote:
> On 01/13/2017 05:36 PM, Joshua Lock wrote:
> 
> > Running checkpkg on the autobuilders won't really help as the
> > autobuilders rely on the bitbake invocation returning a non-zero
> > exit
> > code to determine whether to mark the build step as failed, and
> > that's
> > not the case when checkpkg doesn't find an update version.
> > 
> > If we regularly run checkpkg on the autobuilders how should we
> > detect
> > that a SRC_URI change has caused the upstream version check to
> > fail?
> 
> - run bitbake -c checkpkg world
> - inspect tmp/log/checkpkg.csv for lines with 'UNKNOWN' upstream
> status, 
> make a list of recipes that have it
> - compare that list against a stored list of exceptions (currently
> it 
> would have about 32 entries), if the lists don't match exactly, the 
> upstream version check has failed.
> 
> All of this can be wrapped in poky/scripts/upstream-check-all
> perhaps.

Thanks, I've filed a bug to track implementing this feature:

https://bugzilla.yoctoproject.org/show_bug.cgi?id=11031

Joshua