Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH v2] cryptodev: Fix changed mm interface in Kernel 4.9
@ 2017-01-26 10:15 Daniel Schultz
  2017-01-26 12:27 ` Burton, Ross
  2017-01-26 15:24 ` ✗ patchtest: failure for cryptodev: Fix changed mm interface in Kernel 4.9 (rev2) Patchwork
  0 siblings, 2 replies; 3+ messages in thread
From: Daniel Schultz @ 2017-01-26 10:15 UTC (permalink / raw)
  To: openembedded-core

The memory management interface has changed in Kernel 4.9.

This patch adds a patch which fixes the paramter of the function call.

Backport from https://github.com/cryptodev-linux/cryptodev-linux
Based on commit f126e4837e6334d0464540995df7426fedf6b175

Upstream-Status: Backport

Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
---
 meta/recipes-kernel/cryptodev/cryptodev.inc        |  3 +-
 ...st-to-another-change-in-the-user-page-API.patch | 38 ++++++++++++++++++++++
 2 files changed, 40 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-kernel/cryptodev/files/0001-Adjust-to-another-change-in-the-user-page-API.patch

diff --git a/meta/recipes-kernel/cryptodev/cryptodev.inc b/meta/recipes-kernel/cryptodev/cryptodev.inc
index 160ab30..6241238 100644
--- a/meta/recipes-kernel/cryptodev/cryptodev.inc
+++ b/meta/recipes-kernel/cryptodev/cryptodev.inc
@@ -5,7 +5,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
 SRC_URI = "http://download.gna.org/cryptodev-linux/cryptodev-linux-${PV}.tar.gz \
            file://06d6b560c6e45dc317dae47c74706fa43f4a31d8.patch \
-           file://cb186f682679383e8b5806240927903730ce85d9.patch"
+           file://cb186f682679383e8b5806240927903730ce85d9.patch \
+           file://0001-Adjust-to-another-change-in-the-user-page-API.patch"
 
 SRC_URI[md5sum] = "02644cc4cd02301e0b503a332eb2f0b5"
 SRC_URI[sha256sum] = "67fabde9fb67b286a96c4f45b594b0eccd0f761b495705c18f2ae9461b831376"
diff --git a/meta/recipes-kernel/cryptodev/files/0001-Adjust-to-another-change-in-the-user-page-API.patch b/meta/recipes-kernel/cryptodev/files/0001-Adjust-to-another-change-in-the-user-page-API.patch
new file mode 100644
index 0000000..c001b6f
--- /dev/null
+++ b/meta/recipes-kernel/cryptodev/files/0001-Adjust-to-another-change-in-the-user-page-API.patch
@@ -0,0 +1,38 @@
+From f126e4837e6334d0464540995df7426fedf6b175 Mon Sep 17 00:00:00 2001
+From: Michael Weiser <michael.weiser@gmx.de>
+Date: Fri, 11 Nov 2016 18:09:32 +0100
+Subject: [PATCH] Adjust to another change in the user page API
+
+4.9.0 will replace the write and force flags of get_user_pages_remote()
+with a gup_flags parameter[1]. Distinguish the two APIs based on kernel
+version we're compiling for.
+
+[1] https://github.com/torvalds/linux/commit/9beae1ea89305a9667ceaab6d0bf46a045ad71e7
+
+Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
+---
+ zc.c | 8 +++++++-
+ 1 file changed, 7 insertions(+), 1 deletion(-)
+
+diff --git a/zc.c b/zc.c
+index a97b49f..e766ee3 100644
+--- a/zc.c
++++ b/zc.c
+@@ -65,7 +65,13 @@ int __get_userbuf(uint8_t __user *addr, uint32_t len, int write,
+ 	ret = get_user_pages(
+ #endif
+ 			task, mm,
+-			(unsigned long)addr, pgcount, write, 0, pg, NULL);
++			(unsigned long)addr, pgcount,
++#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4, 9, 0))
++			write ? FOLL_WRITE : 0,
++#else
++			write, 0,
++#endif
++			pg, NULL);
+ 	up_read(&mm->mmap_sem);
+ 	if (ret != pgcount)
+ 		return -EINVAL;
+-- 
+1.9.1
+
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] cryptodev: Fix changed mm interface in Kernel 4.9
  2017-01-26 10:15 [PATCH v2] cryptodev: Fix changed mm interface in Kernel 4.9 Daniel Schultz
@ 2017-01-26 12:27 ` Burton, Ross
  2017-01-26 15:24 ` ✗ patchtest: failure for cryptodev: Fix changed mm interface in Kernel 4.9 (rev2) Patchwork
  1 sibling, 0 replies; 3+ messages in thread
From: Burton, Ross @ 2017-01-26 12:27 UTC (permalink / raw)
  To: Daniel Schultz; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

On 26 January 2017 at 10:15, Daniel Schultz <d.schultz@phytec.de> wrote:

> Upstream-Status: Backport
>

This needs to go in the header of the patch you apply, not the commit
message.

Ross

[-- Attachment #2: Type: text/html, Size: 604 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* ✗ patchtest: failure for cryptodev: Fix changed mm interface in Kernel 4.9 (rev2)
  2017-01-26 10:15 [PATCH v2] cryptodev: Fix changed mm interface in Kernel 4.9 Daniel Schultz
  2017-01-26 12:27 ` Burton, Ross
@ 2017-01-26 15:24 ` Patchwork
  1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2017-01-26 15:24 UTC (permalink / raw)
  To: Daniel Schultz; +Cc: openembedded-core

== Series Details ==

Series: cryptodev: Fix changed mm interface in Kernel 4.9 (rev2)
Revision: 2
URL   : https://patchwork.openembedded.org/series/4970/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Added patch file is missing Upstream-Status in the header [test_upstream_status_presence] 
  Suggested fix    Add Upstream-Status: <status> to the header of meta/recipes-kernel/cryptodev/files/0001-Adjust-to-another-change-in-the-user-page-API.patch (possible values: Pending, Submitted, Accepted, Backport, Denied, Inappropriate)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-01-26 15:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-26 10:15 [PATCH v2] cryptodev: Fix changed mm interface in Kernel 4.9 Daniel Schultz
2017-01-26 12:27 ` Burton, Ross
2017-01-26 15:24 ` ✗ patchtest: failure for cryptodev: Fix changed mm interface in Kernel 4.9 (rev2) Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox