* [PATCH] uboot-extlinux-config.bbclass: add support for timeout & default
@ 2017-02-09 16:09 Dalon Westergreen
2017-02-09 20:25 ` Fabio Berton
0 siblings, 1 reply; 4+ messages in thread
From: Dalon Westergreen @ 2017-02-09 16:09 UTC (permalink / raw)
To: openembedded-core
When multible targets are defined it is useful to allow for
a default target along with a timeout. After timeout, the
default target will be selected.
Signed-off-by: Dalon Westergreen <dwesterg@gmail.com>
---
meta/classes/uboot-extlinux-config.bbclass | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/meta/classes/uboot-extlinux-config.bbclass b/meta/classes/uboot-extlinux-config.bbclass
index ec5fffb..96b5a2e 100644
--- a/meta/classes/uboot-extlinux-config.bbclass
+++ b/meta/classes/uboot-extlinux-config.bbclass
@@ -16,6 +16,10 @@
# concatenate and use as an initrd (optional).
# UBOOT_EXTLINUX_MENU_DESCRIPTION - Name to use as description.
# UBOOT_EXTLINUX_ROOT - Root kernel cmdline.
+# UBOOT_EXTLINUX_TIMEOUT - Timeout before DEFAULT selection is made.
+# Measured in 1/10 of a second.
+# UBOOT_EXTLINUX_DEFAULT_LABEL - Target to be selected by default after
+# the timeout period
#
# If there's only one label system will boot automatically and menu won't be
# created. If you want to use more than one labels, e.g linux and alternate,
@@ -25,6 +29,9 @@
#
# UBOOT_EXTLINUX_LABELS ??= "default fallback"
#
+# UBOOT_EXTLINUX_DEFAULT_LABEL ??= "Linux Default"
+# UBOOT_EXTLINUX_TIMEOUT ??= "30"
+#
# UBOOT_EXTLINUX_KERNEL_IMAGE_default ??= "../zImage"
# UBOOT_EXTLINUX_MENU_DESCRIPTION_default ??= "Linux Default"
#
@@ -34,6 +41,8 @@
# Results:
#
# menu title Select the boot mode
+# TIMEOUT 30
+# DEFAULT Linux Default
# LABEL Linux Default
# KERNEL ../zImage
# FDTDIR ../
@@ -82,6 +91,15 @@ python create_extlinux_config() {
if len(labels.split()) > 1:
cfgfile.write('menu title Select the boot mode\n')
+ timeout = localdata.getVar('UBOOT_EXTLINUX_TIMEOUT')
+ if timeout:
+ cfgfile.write('TIMEOUT %s\n' % (timeout))
+
+ if len(labels.split()) > 1:
+ default = localdata.getVar('UBOOT_EXTLINUX_DEFAULT_LABEL')
+ if default:
+ cfgfile.write('DEFAULT %s\n' % (default))
+
for label in labels.split():
localdata = bb.data.createCopy(d)
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] uboot-extlinux-config.bbclass: add support for timeout & default
2017-02-09 16:09 [PATCH] uboot-extlinux-config.bbclass: add support for timeout & default Dalon Westergreen
@ 2017-02-09 20:25 ` Fabio Berton
2017-02-09 21:02 ` Dalon Westergreen
0 siblings, 1 reply; 4+ messages in thread
From: Fabio Berton @ 2017-02-09 20:25 UTC (permalink / raw)
To: Dalon Westergreen; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 2998 bytes --]
I get this error:
Exception: UnboundLocalError: local variable 'localdata' referenced before
assignment
You are using localdata.getVar('UBOOT_EXTLINUX_TIMEOUT') before localdata =
bb.data.createCopy(d).
On Thu, Feb 9, 2017 at 2:09 PM, Dalon Westergreen <dwesterg@gmail.com>
wrote:
> When multible targets are defined it is useful to allow for
> a default target along with a timeout. After timeout, the
> default target will be selected.
>
> Signed-off-by: Dalon Westergreen <dwesterg@gmail.com>
> ---
> meta/classes/uboot-extlinux-config.bbclass | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/meta/classes/uboot-extlinux-config.bbclass
> b/meta/classes/uboot-extlinux-config.bbclass
> index ec5fffb..96b5a2e 100644
> --- a/meta/classes/uboot-extlinux-config.bbclass
> +++ b/meta/classes/uboot-extlinux-config.bbclass
> @@ -16,6 +16,10 @@
> # concatenate and use as an initrd
> (optional).
> # UBOOT_EXTLINUX_MENU_DESCRIPTION - Name to use as description.
> # UBOOT_EXTLINUX_ROOT - Root kernel cmdline.
> +# UBOOT_EXTLINUX_TIMEOUT - Timeout before DEFAULT selection is
> made.
> +# Measured in 1/10 of a second.
> +# UBOOT_EXTLINUX_DEFAULT_LABEL - Target to be selected by default
> after
> +# the timeout period
> #
> # If there's only one label system will boot automatically and menu won't
> be
> # created. If you want to use more than one labels, e.g linux and
> alternate,
> @@ -25,6 +29,9 @@
> #
> # UBOOT_EXTLINUX_LABELS ??= "default fallback"
> #
> +# UBOOT_EXTLINUX_DEFAULT_LABEL ??= "Linux Default"
> +# UBOOT_EXTLINUX_TIMEOUT ??= "30"
> +#
> # UBOOT_EXTLINUX_KERNEL_IMAGE_default ??= "../zImage"
> # UBOOT_EXTLINUX_MENU_DESCRIPTION_default ??= "Linux Default"
> #
> @@ -34,6 +41,8 @@
> # Results:
> #
> # menu title Select the boot mode
> +# TIMEOUT 30
> +# DEFAULT Linux Default
> # LABEL Linux Default
> # KERNEL ../zImage
> # FDTDIR ../
> @@ -82,6 +91,15 @@ python create_extlinux_config() {
> if len(labels.split()) > 1:
> cfgfile.write('menu title Select the boot mode\n')
>
> + timeout = localdata.getVar('UBOOT_EXTLINUX_TIMEOUT')
> + if timeout:
> + cfgfile.write('TIMEOUT %s\n' % (timeout))
> +
> + if len(labels.split()) > 1:
> + default = localdata.getVar('UBOOT_
> EXTLINUX_DEFAULT_LABEL')
> + if default:
> + cfgfile.write('DEFAULT %s\n' % (default))
> +
> for label in labels.split():
> localdata = bb.data.createCopy(d)
>
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
[-- Attachment #2: Type: text/html, Size: 4236 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] uboot-extlinux-config.bbclass: add support for timeout & default
2017-02-09 20:25 ` Fabio Berton
@ 2017-02-09 21:02 ` Dalon Westergreen
0 siblings, 0 replies; 4+ messages in thread
From: Dalon Westergreen @ 2017-02-09 21:02 UTC (permalink / raw)
To: Fabio Berton; +Cc: Patches and discussions about the oe-core layer
On Thu, 2017-02-09 at 18:25 -0200, Fabio Berton wrote:
> I get this error:
>
> Exception: UnboundLocalError: local variable 'localdata' referenced before
> assignment
>
> You are using localdata.getVar('UBOOT_EXTLINUX_TIMEOUT') before localdata =
> bb.data.createCopy(d).
>
thanks.
> On Thu, Feb 9, 2017 at 2:09 PM, Dalon Westergreen <dwesterg@gmail.com> wrote:
> > When multible targets are defined it is useful to allow for
> > a default target along with a timeout. After timeout, the
> > default target will be selected.
> >
> > Signed-off-by: Dalon Westergreen <dwesterg@gmail.com>
> > ---
> > meta/classes/uboot-extlinux-config.bbclass | 18 ++++++++++++++++++
> > 1 file changed, 18 insertions(+)
> >
> > diff --git a/meta/classes/uboot-extlinux-config.bbclass
> > b/meta/classes/uboot-extlinux-config.bbclass
> > index ec5fffb..96b5a2e 100644
> > --- a/meta/classes/uboot-extlinux-config.bbclass
> > +++ b/meta/classes/uboot-extlinux-config.bbclass
> > @@ -16,6 +16,10 @@
> > # concatenate and use as an initrd
> > (optional).
> > # UBOOT_EXTLINUX_MENU_DESCRIPTION - Name to use as description.
> > # UBOOT_EXTLINUX_ROOT - Root kernel cmdline.
> > +# UBOOT_EXTLINUX_TIMEOUT - Timeout before DEFAULT selection is
> > made.
> > +# Measured in 1/10 of a second.
> > +# UBOOT_EXTLINUX_DEFAULT_LABEL - Target to be selected by default after
> > +# the timeout period
> > #
> > # If there's only one label system will boot automatically and menu won't
> > be
> > # created. If you want to use more than one labels, e.g linux and
> > alternate,
> > @@ -25,6 +29,9 @@
> > #
> > # UBOOT_EXTLINUX_LABELS ??= "default fallback"
> > #
> > +# UBOOT_EXTLINUX_DEFAULT_LABEL ??= "Linux Default"
> > +# UBOOT_EXTLINUX_TIMEOUT ??= "30"
> > +#
> > # UBOOT_EXTLINUX_KERNEL_IMAGE_default ??= "../zImage"
> > # UBOOT_EXTLINUX_MENU_DESCRIPTION_default ??= "Linux Default"
> > #
> > @@ -34,6 +41,8 @@
> > # Results:
> > #
> > # menu title Select the boot mode
> > +# TIMEOUT 30
> > +# DEFAULT Linux Default
> > # LABEL Linux Default
> > # KERNEL ../zImage
> > # FDTDIR ../
> > @@ -82,6 +91,15 @@ python create_extlinux_config() {
> > if len(labels.split()) > 1:
> > cfgfile.write('menu title Select the boot mode\n')
> >
> > + timeout = localdata.getVar('UBOOT_EXTLINUX_TIMEOUT')
> > + if timeout:
> > + cfgfile.write('TIMEOUT %s\n' % (timeout))
> > +
> > + if len(labels.split()) > 1:
> > + default = localdata.getVar('UBOOT_EXTLINUX_DEFAULT_LABEL')
> > + if default:
> > + cfgfile.write('DEFAULT %s\n' % (default))
> > +
> > for label in labels.split():
> > localdata = bb.data.createCopy(d)
> >
> > --
> > 2.7.4
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] uboot-extlinux-config.bbclass: add support for timeout & default
@ 2017-02-07 23:46 Dalon Westergreen
0 siblings, 0 replies; 4+ messages in thread
From: Dalon Westergreen @ 2017-02-07 23:46 UTC (permalink / raw)
To: openembedded-core
When multible targets are defined it is useful to allow for
a default target along with a timeout. After timeout, the
default target will be selected.
Signed-off-by: Dalon Westergreen <dwesterg@gmail.com>
---
meta/classes/uboot-extlinux-config.bbclass | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/meta/classes/uboot-extlinux-config.bbclass b/meta/classes/uboot-extlinux-config.bbclass
index ec5fffb..96b5a2e 100644
--- a/meta/classes/uboot-extlinux-config.bbclass
+++ b/meta/classes/uboot-extlinux-config.bbclass
@@ -16,6 +16,10 @@
# concatenate and use as an initrd (optional).
# UBOOT_EXTLINUX_MENU_DESCRIPTION - Name to use as description.
# UBOOT_EXTLINUX_ROOT - Root kernel cmdline.
+# UBOOT_EXTLINUX_TIMEOUT - Timeout before DEFAULT selection is made.
+# Measured in 1/10 of a second.
+# UBOOT_EXTLINUX_DEFAULT_LABEL - Target to be selected by default after
+# the timeout period
#
# If there's only one label system will boot automatically and menu won't be
# created. If you want to use more than one labels, e.g linux and alternate,
@@ -25,6 +29,9 @@
#
# UBOOT_EXTLINUX_LABELS ??= "default fallback"
#
+# UBOOT_EXTLINUX_DEFAULT_LABEL ??= "Linux Default"
+# UBOOT_EXTLINUX_TIMEOUT ??= "30"
+#
# UBOOT_EXTLINUX_KERNEL_IMAGE_default ??= "../zImage"
# UBOOT_EXTLINUX_MENU_DESCRIPTION_default ??= "Linux Default"
#
@@ -34,6 +41,8 @@
# Results:
#
# menu title Select the boot mode
+# TIMEOUT 30
+# DEFAULT Linux Default
# LABEL Linux Default
# KERNEL ../zImage
# FDTDIR ../
@@ -82,6 +91,15 @@ python create_extlinux_config() {
if len(labels.split()) > 1:
cfgfile.write('menu title Select the boot mode\n')
+ timeout = localdata.getVar('UBOOT_EXTLINUX_TIMEOUT')
+ if timeout:
+ cfgfile.write('TIMEOUT %s\n' % (timeout))
+
+ if len(labels.split()) > 1:
+ default = localdata.getVar('UBOOT_EXTLINUX_DEFAULT_LABEL')
+ if default:
+ cfgfile.write('DEFAULT %s\n' % (default))
+
for label in labels.split():
localdata = bb.data.createCopy(d)
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-09 21:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-09 16:09 [PATCH] uboot-extlinux-config.bbclass: add support for timeout & default Dalon Westergreen
2017-02-09 20:25 ` Fabio Berton
2017-02-09 21:02 ` Dalon Westergreen
-- strict thread matches above, loose matches on Subject: below --
2017-02-07 23:46 Dalon Westergreen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox