From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Joe Slater <jslater@windriver.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] build-compare: add date to PV
Date: Wed, 15 Mar 2017 21:43:39 +0000 [thread overview]
Message-ID: <1489614219.13980.74.camel@linuxfoundation.org> (raw)
In-Reply-To: <1489601805-20482-1-git-send-email-jslater@windriver.com>
On Wed, 2017-03-15 at 11:16 -0700, Joe Slater wrote:
> We want PV values to be easily ordered, so
> use the latest entry in build-compare.changes which
> will also match the date of SRCREV.
>
> Signed-off-by: Joe Slater <jslater@windriver.com>
> ---
> .../build-compare/build-compare_git.bb | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/build-compare/build-compare_git.bb
> b/meta/recipes-devtools/build-compare/build-compare_git.bb
> index eb12e40..c80ebd4 100644
> --- a/meta/recipes-devtools/build-compare/build-compare_git.bb
> +++ b/meta/recipes-devtools/build-compare/build-compare_git.bb
> @@ -17,8 +17,10 @@ SRC_URI = "git://github.com/openSUSE/build-
> compare.git \
> file://functions.sh-improve-deb-and-ipk-checking.patch \
> "
>
> +# Date matches entry in build-compare.changes and date of SRCREV.
> +#
> SRCREV = "c5352c054c6ef15735da31b76d6d88620f4aff0a"
> -PV = "git+${SRCPV}"
> +PV = "2015.02.10+git"
I think you either want:
"2015.02.10"
or
"2015.02.10+git${SRCPV}"
but not the one above! :)
(since this matches the style in the other git recipes)
Cheers,
Richard
prev parent reply other threads:[~2017-03-15 21:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 18:16 [PATCH 1/1] build-compare: add date to PV Joe Slater
2017-03-15 21:43 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489614219.13980.74.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=jslater@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox