Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 1/1] build-compare: add date to PV
@ 2017-03-15 18:16 Joe Slater
  2017-03-15 21:43 ` Richard Purdie
  0 siblings, 1 reply; 2+ messages in thread
From: Joe Slater @ 2017-03-15 18:16 UTC (permalink / raw)
  To: openembedded-core

We want PV values to be easily ordered, so
use the latest entry in build-compare.changes which
will also match the date of SRCREV.

Signed-off-by: Joe Slater <jslater@windriver.com>
---
 .../build-compare/build-compare_git.bb             |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/build-compare/build-compare_git.bb b/meta/recipes-devtools/build-compare/build-compare_git.bb
index eb12e40..c80ebd4 100644
--- a/meta/recipes-devtools/build-compare/build-compare_git.bb
+++ b/meta/recipes-devtools/build-compare/build-compare_git.bb
@@ -17,8 +17,10 @@ SRC_URI = "git://github.com/openSUSE/build-compare.git \
            file://functions.sh-improve-deb-and-ipk-checking.patch \
            "
 
+# Date matches entry in build-compare.changes and date of SRCREV.
+#
 SRCREV = "c5352c054c6ef15735da31b76d6d88620f4aff0a"
-PV = "git+${SRCPV}"
+PV = "2015.02.10+git"
 
 S = "${WORKDIR}/git"
 
-- 
1.7.9.5



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] build-compare: add date to PV
  2017-03-15 18:16 [PATCH 1/1] build-compare: add date to PV Joe Slater
@ 2017-03-15 21:43 ` Richard Purdie
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Purdie @ 2017-03-15 21:43 UTC (permalink / raw)
  To: Joe Slater, openembedded-core

On Wed, 2017-03-15 at 11:16 -0700, Joe Slater wrote:
> We want PV values to be easily ordered, so
> use the latest entry in build-compare.changes which
> will also match the date of SRCREV.
> 
> Signed-off-by: Joe Slater <jslater@windriver.com>
> ---
>  .../build-compare/build-compare_git.bb             |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/build-compare/build-compare_git.bb 
> b/meta/recipes-devtools/build-compare/build-compare_git.bb
> index eb12e40..c80ebd4 100644
> --- a/meta/recipes-devtools/build-compare/build-compare_git.bb
> +++ b/meta/recipes-devtools/build-compare/build-compare_git.bb
> @@ -17,8 +17,10 @@ SRC_URI = "git://github.com/openSUSE/build-
> compare.git \
>             file://functions.sh-improve-deb-and-ipk-checking.patch \
>             "
>  
> +# Date matches entry in build-compare.changes and date of SRCREV.
> +#
>  SRCREV = "c5352c054c6ef15735da31b76d6d88620f4aff0a"
> -PV = "git+${SRCPV}"
> +PV = "2015.02.10+git"

I think you either want:

"2015.02.10"
or
"2015.02.10+git${SRCPV}"

but not the one above! :)

(since this matches the style in the other git recipes)

Cheers,

Richard






^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-03-15 21:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-15 18:16 [PATCH 1/1] build-compare: add date to PV Joe Slater
2017-03-15 21:43 ` Richard Purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox