* [PATCH 1/3] subversion: remove useless comment
@ 2017-03-14 9:37 leonardo.sandoval.gonzalez
2017-03-14 9:37 ` [PATCH 2/3] uninative.bbclass: split long command leonardo.sandoval.gonzalez
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: leonardo.sandoval.gonzalez @ 2017-03-14 9:37 UTC (permalink / raw)
To: openembedded-core
From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
Remove auto-builder comment shown on the recipe because it does not add something
useful.
Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
---
meta/recipes-devtools/subversion/subversion_1.9.5.bb | 5 -----
1 file changed, 5 deletions(-)
diff --git a/meta/recipes-devtools/subversion/subversion_1.9.5.bb b/meta/recipes-devtools/subversion/subversion_1.9.5.bb
index 05fba67..5871b84 100644
--- a/meta/recipes-devtools/subversion/subversion_1.9.5.bb
+++ b/meta/recipes-devtools/subversion/subversion_1.9.5.bb
@@ -47,9 +47,4 @@ do_configure_prepend () {
sed -i -e 's:with_sasl="/usr/local":with_sasl="${STAGING_DIR}":' ${S}/build/ac-macros/sasl.m4
}
-#| x86_64-linux-libtool: install: warning: `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-qa-logrotate/build/build/tmp/work/x86_64-linux/subversion-native/1.8.9-r0/build/subversion/libsvn_ra_local/libsvn_ra_local-1.la' has not been installed in `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-qa-logrotate/build/build/tmp/sysroots/x86_64-linux/usr/lib'| x86_64-linux-libtool: install: warning: `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-qa-logrotate/build/build/tmp/work/x86_64-linux/subversion-native/1.8.9-r0/build/subversion/libsvn_repos/libsvn_repos-1.la' has not been installed in `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-qa-logrotate/build/build/tmp/sysroots/x86_64-linux/usr/lib'| /usr/bin/ld: cannot find -lsvn_delta-1| collect2: ld returned 1 exit status| x86_64-linux-libtool: install: warning: `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-qa-logrotate/build/build/tmp/work/x86_64-linux/subversion-native/1.8.9-r0/build/subversion/libsvn_ra_svn/libsvn_ra_svn-1.la' has not been installed in `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-qa-logrotate/build/build/tmp/sysroots/x86_64-linux/usr/lib'| x86_64-linux-libtool: install: warning: `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-qa-logrotate/build/build/tmp/work/x86_64-linux/subversion-native/1.8.9-r0/build/subversion/libsvn_ra_serf/libsvn_ra_serf-1.la' has not been installed in `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-qa-logrotate/build/build/tmp/sysroots/x86_64-linux/usr/lib'
-#| x86_64-linux-libtool: install: error: relink `libsvn_ra_serf-1.la' with the above command before installing it
-#| x86_64-linux-libtool: install: warning: `../../subversion/libsvn_repos/libsvn_repos-1.la' has not been installed in `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-qa-logrotate/build/build/tmp/sysroots/x86_64-linux/usr/lib'
-#| /home/pokybuild/yocto-autobuilder/yocto-worker/nightly-qa-logrotate/build/build/tmp/work/x86_64-linux/subversion-native/1.8.9-r0/subversion-1.8.9/build-outputs.mk:1090: recipe for target 'install-serf-lib' failed
-#| make: *** [install-serf-lib] Error 1
PARALLEL_MAKEINST = ""
--
2.10.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/3] uninative.bbclass: split long command
2017-03-14 9:37 [PATCH 1/3] subversion: remove useless comment leonardo.sandoval.gonzalez
@ 2017-03-14 9:37 ` leonardo.sandoval.gonzalez
2017-03-14 9:37 ` [PATCH 3/3] gettext: split recipe's description leonardo.sandoval.gonzalez
2017-03-21 20:52 ` [PATCH 1/3] subversion: remove useless comment Richard Purdie
2 siblings, 0 replies; 5+ messages in thread
From: leonardo.sandoval.gonzalez @ 2017-03-14 9:37 UTC (permalink / raw)
To: openembedded-core
From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
Single long commands are difficult to read and maintain. Split it to make
it more human-friendly.
Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
---
meta/classes/uninative.bbclass | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/meta/classes/uninative.bbclass b/meta/classes/uninative.bbclass
index ee4ab20..b578031 100644
--- a/meta/classes/uninative.bbclass
+++ b/meta/classes/uninative.bbclass
@@ -59,7 +59,16 @@ python uninative_event_fetchloader() {
if localpath != tarballpath and os.path.exists(localpath) and not os.path.exists(tarballpath):
os.symlink(localpath, tarballpath)
- cmd = d.expand("mkdir -p ${UNINATIVE_STAGING_DIR}-uninative; cd ${UNINATIVE_STAGING_DIR}-uninative; tar -xjf ${UNINATIVE_DLDIR}/%s/${UNINATIVE_TARBALL}; ${UNINATIVE_STAGING_DIR}-uninative/relocate_sdk.py ${UNINATIVE_STAGING_DIR}-uninative/${BUILD_ARCH}-linux ${UNINATIVE_LOADER} ${UNINATIVE_LOADER} ${UNINATIVE_STAGING_DIR}-uninative/${BUILD_ARCH}-linux/${bindir_native}/patchelf-uninative ${UNINATIVE_STAGING_DIR}-uninative/${BUILD_ARCH}-linux${base_libdir_native}/libc*.so" % chksum)
+ cmd = d.expand("\
+mkdir -p ${UNINATIVE_STAGING_DIR}-uninative; \
+cd ${UNINATIVE_STAGING_DIR}-uninative; \
+tar -xjf ${UNINATIVE_DLDIR}/%s/${UNINATIVE_TARBALL}; \
+${UNINATIVE_STAGING_DIR}-uninative/relocate_sdk.py \
+ ${UNINATIVE_STAGING_DIR}-uninative/${BUILD_ARCH}-linux \
+ ${UNINATIVE_LOADER} \
+ ${UNINATIVE_LOADER} \
+ ${UNINATIVE_STAGING_DIR}-uninative/${BUILD_ARCH}-linux/${bindir_native}/patchelf-uninative \
+ ${UNINATIVE_STAGING_DIR}-uninative/${BUILD_ARCH}-linux${base_libdir_native}/libc*.so" % chksum)
subprocess.check_output(cmd, shell=True)
with open(loaderchksum, "w") as f:
--
2.10.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 3/3] gettext: split recipe's description
2017-03-14 9:37 [PATCH 1/3] subversion: remove useless comment leonardo.sandoval.gonzalez
2017-03-14 9:37 ` [PATCH 2/3] uninative.bbclass: split long command leonardo.sandoval.gonzalez
@ 2017-03-14 9:37 ` leonardo.sandoval.gonzalez
2017-03-21 20:52 ` [PATCH 1/3] subversion: remove useless comment Richard Purdie
2 siblings, 0 replies; 5+ messages in thread
From: leonardo.sandoval.gonzalez @ 2017-03-14 9:37 UTC (permalink / raw)
To: openembedded-core
From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
Split long recipe description into multiple lines.
Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
---
meta/recipes-core/gettext/gettext_0.19.8.1.bb | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-core/gettext/gettext_0.19.8.1.bb b/meta/recipes-core/gettext/gettext_0.19.8.1.bb
index 557bf68..83edffe 100644
--- a/meta/recipes-core/gettext/gettext_0.19.8.1.bb
+++ b/meta/recipes-core/gettext/gettext_0.19.8.1.bb
@@ -1,5 +1,8 @@
SUMMARY = "Utilities and libraries for producing multi-lingual messages"
-DESCRIPTION = "GNU gettext is a set of tools that provides a framework to help other programs produce multi-lingual messages. These tools include a set of conventions about how programs should be written to support message catalogs, a directory and file naming organization for the message catalogs themselves, a runtime library supporting the retrieval of translated messages, and a few stand-alone programs to massage in various ways the sets of translatable and already translated strings."
+DESCRIPTION = "GNU gettext is a set of tools that provides a framework to help other programs produce multi-lingual messages. \
+These tools include a set of conventions about how programs should be written to support message catalogs, a directory and file \
+naming organization for the message catalogs themselves, a runtime library supporting the retrieval of translated messages, and \
+a few stand-alone programs to massage in various ways the sets of translatable and already translated strings."
HOMEPAGE = "http://www.gnu.org/software/gettext/gettext.html"
SECTION = "libs"
LICENSE = "GPLv3+ & LGPL-2.1+"
--
2.10.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/3] subversion: remove useless comment
2017-03-14 9:37 [PATCH 1/3] subversion: remove useless comment leonardo.sandoval.gonzalez
2017-03-14 9:37 ` [PATCH 2/3] uninative.bbclass: split long command leonardo.sandoval.gonzalez
2017-03-14 9:37 ` [PATCH 3/3] gettext: split recipe's description leonardo.sandoval.gonzalez
@ 2017-03-21 20:52 ` Richard Purdie
2017-03-21 21:15 ` Leonardo Sandoval
2 siblings, 1 reply; 5+ messages in thread
From: Richard Purdie @ 2017-03-21 20:52 UTC (permalink / raw)
To: leonardo.sandoval.gonzalez, openembedded-core
On Tue, 2017-03-14 at 09:37 +0000,
leonardo.sandoval.gonzalez@linux.intel.com wrote:
> From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
>
> Remove auto-builder comment shown on the recipe because it does not
> add something
> useful.
I disagree, it explains the error seen which caused parallel make
install to be disabled in the first place. I suggest wrapping the
comment rather than branding it "useless". You could also replace out
"/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-qa-
logrotate/build/build/tmp" with TMPDIR.
All too often we see things like parallel make disabled with no idea
why.
Cheers,
Richard
>
> Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.in
> tel.com>
> ---
> meta/recipes-devtools/subversion/subversion_1.9.5.bb | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/meta/recipes-devtools/subversion/subversion_1.9.5.bb
> b/meta/recipes-devtools/subversion/subversion_1.9.5.bb
> index 05fba67..5871b84 100644
> --- a/meta/recipes-devtools/subversion/subversion_1.9.5.bb
> +++ b/meta/recipes-devtools/subversion/subversion_1.9.5.bb
> @@ -47,9 +47,4 @@ do_configure_prepend () {
> sed -i -e
> 's:with_sasl="/usr/local":with_sasl="${STAGING_DIR}":' ${S}/build/ac-
> macros/sasl.m4
> }
>
> -#| x86_64-linux-libtool: install: warning: `/home/pokybuild/yocto-
> autobuilder/yocto-worker/nightly-qa-
> logrotate/build/build/tmp/work/x86_64-linux/subversion-native/1.8.9-
> r0/build/subversion/libsvn_ra_local/libsvn_ra_local-1.la' has not
> been installed in `/home/pokybuild/yocto-autobuilder/yocto-
> worker/nightly-qa-logrotate/build/build/tmp/sysroots/x86_64-
> linux/usr/lib'| x86_64-linux-libtool: install: warning:
> `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-qa-
> logrotate/build/build/tmp/work/x86_64-linux/subversion-native/1.8.9-
> r0/build/subversion/libsvn_repos/libsvn_repos-1.la' has not been
> installed in `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-
> qa-logrotate/build/build/tmp/sysroots/x86_64-linux/usr/lib'|
> /usr/bin/ld: cannot find -lsvn_delta-1| collect2: ld returned 1 exit
> status| x86_64-linux-libtool: install: warning:
> `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-qa-
> logrotate/build/build/tmp/work/x86_64-linux/subversion-native/1.8.9-
> r0/build/sub
> version/libsvn_ra_svn/libsvn_ra_svn-1.la' has not been installed in
> `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-qa-
> logrotate/build/build/tmp/sysroots/x86_64-linux/usr/lib'| x86_64-
> linux-libtool: install: warning: `/home/pokybuild/yocto-
> autobuilder/yocto-worker/nightly-qa-
> logrotate/build/build/tmp/work/x86_64-linux/subversion-native/1.8.9-
> r0/build/subversion/libsvn_ra_serf/libsvn_ra_serf-1.la' has not been
> installed in `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-
> qa-logrotate/build/build/tmp/sysroots/x86_64-linux/usr/lib'
> -#| x86_64-linux-libtool: install: error: relink `libsvn_ra_serf-
> 1.la' with the above command before installing it
> -#| x86_64-linux-libtool: install: warning:
> `../../subversion/libsvn_repos/libsvn_repos-1.la' has not been
> installed in `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-
> qa-logrotate/build/build/tmp/sysroots/x86_64-linux/usr/lib'
> -#| /home/pokybuild/yocto-autobuilder/yocto-worker/nightly-qa-
> logrotate/build/build/tmp/work/x86_64-linux/subversion-native/1.8.9-
> r0/subversion-1.8.9/build-outputs.mk:1090: recipe for target
> 'install-serf-lib' failed
> -#| make: *** [install-serf-lib] Error 1
> PARALLEL_MAKEINST = ""
> --
> 2.10.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/3] subversion: remove useless comment
2017-03-21 20:52 ` [PATCH 1/3] subversion: remove useless comment Richard Purdie
@ 2017-03-21 21:15 ` Leonardo Sandoval
0 siblings, 0 replies; 5+ messages in thread
From: Leonardo Sandoval @ 2017-03-21 21:15 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
On Tue, 2017-03-21 at 20:52 +0000, Richard Purdie wrote:
> On Tue, 2017-03-14 at 09:37 +0000,
> leonardo.sandoval.gonzalez@linux.intel.com wrote:
> > From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
> >
> > Remove auto-builder comment shown on the recipe because it does not
> > add something
> > useful.
>
> I disagree, it explains the error seen which caused parallel make
> install to be disabled in the first place. I suggest wrapping the
> comment rather than branding it "useless". You could also replace out
> "/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-qa-
> logrotate/build/build/tmp" with TMPDIR.
>
With your explanation, it makes sense but in the recipe is just the log,
nothing more. Yes, pathnames should be shorter, so we do not have a line
with almost 500 chars.
Leo
> All too often we see things like parallel make disabled with no idea
> why.
>
> Cheers,
>
> Richard
>
> >
> > Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.in
> > tel.com>
> > ---
> > meta/recipes-devtools/subversion/subversion_1.9.5.bb | 5 -----
> > 1 file changed, 5 deletions(-)
> >
> > diff --git a/meta/recipes-devtools/subversion/subversion_1.9.5.bb
> > b/meta/recipes-devtools/subversion/subversion_1.9.5.bb
> > index 05fba67..5871b84 100644
> > --- a/meta/recipes-devtools/subversion/subversion_1.9.5.bb
> > +++ b/meta/recipes-devtools/subversion/subversion_1.9.5.bb
> > @@ -47,9 +47,4 @@ do_configure_prepend () {
> > sed -i -e
> > 's:with_sasl="/usr/local":with_sasl="${STAGING_DIR}":' ${S}/build/ac-
> > macros/sasl.m4
> > }
> >
> > -#| x86_64-linux-libtool: install: warning: `/home/pokybuild/yocto-
> > autobuilder/yocto-worker/nightly-qa-
> > logrotate/build/build/tmp/work/x86_64-linux/subversion-native/1.8.9-
> > r0/build/subversion/libsvn_ra_local/libsvn_ra_local-1.la' has not
> > been installed in `/home/pokybuild/yocto-autobuilder/yocto-
> > worker/nightly-qa-logrotate/build/build/tmp/sysroots/x86_64-
> > linux/usr/lib'| x86_64-linux-libtool: install: warning:
> > `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-qa-
> > logrotate/build/build/tmp/work/x86_64-linux/subversion-native/1.8.9-
> > r0/build/subversion/libsvn_repos/libsvn_repos-1.la' has not been
> > installed in `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-
> > qa-logrotate/build/build/tmp/sysroots/x86_64-linux/usr/lib'|
> > /usr/bin/ld: cannot find -lsvn_delta-1| collect2: ld returned 1 exit
> > status| x86_64-linux-libtool: install: warning:
> > `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-qa-
> > logrotate/build/build/tmp/work/x86_64-linux/subversion-native/1.8.9-
> > r0/build/sub
> > version/libsvn_ra_svn/libsvn_ra_svn-1.la' has not been installed in
> > `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-qa-
> > logrotate/build/build/tmp/sysroots/x86_64-linux/usr/lib'| x86_64-
> > linux-libtool: install: warning: `/home/pokybuild/yocto-
> > autobuilder/yocto-worker/nightly-qa-
> > logrotate/build/build/tmp/work/x86_64-linux/subversion-native/1.8.9-
> > r0/build/subversion/libsvn_ra_serf/libsvn_ra_serf-1.la' has not been
> > installed in `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-
> > qa-logrotate/build/build/tmp/sysroots/x86_64-linux/usr/lib'
> > -#| x86_64-linux-libtool: install: error: relink `libsvn_ra_serf-
> > 1.la' with the above command before installing it
> > -#| x86_64-linux-libtool: install: warning:
> > `../../subversion/libsvn_repos/libsvn_repos-1.la' has not been
> > installed in `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-
> > qa-logrotate/build/build/tmp/sysroots/x86_64-linux/usr/lib'
> > -#| /home/pokybuild/yocto-autobuilder/yocto-worker/nightly-qa-
> > logrotate/build/build/tmp/work/x86_64-linux/subversion-native/1.8.9-
> > r0/subversion-1.8.9/build-outputs.mk:1090: recipe for target
> > 'install-serf-lib' failed
> > -#| make: *** [install-serf-lib] Error 1
> > PARALLEL_MAKEINST = ""
> > --
> > 2.10.2
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-03-21 21:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-14 9:37 [PATCH 1/3] subversion: remove useless comment leonardo.sandoval.gonzalez
2017-03-14 9:37 ` [PATCH 2/3] uninative.bbclass: split long command leonardo.sandoval.gonzalez
2017-03-14 9:37 ` [PATCH 3/3] gettext: split recipe's description leonardo.sandoval.gonzalez
2017-03-21 20:52 ` [PATCH 1/3] subversion: remove useless comment Richard Purdie
2017-03-21 21:15 ` Leonardo Sandoval
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox