Re: [PATCH v2] libxslt: Add PACKAGECONFIG support for python

["Patel, Vedang" <vedang.patel@intel.com>]

On Thu, 2017-03-23 at 12:55 -0700, Randy Witt wrote:
> Hi Patel,
> 
> On 03/22/2017 06:05 PM, Vedang Patel wrote:
> > 
> > Add support to enable python bindings for libxslt using
> > PACKAGECONFIG.
> > This will include --with-python argument while compiling the
> > package.
> > The support is disabled by default.
> > 
> > Signed-off-by: Vedang Patel <vedang.patel@intel.com>
> > ---
> >  meta/recipes-support/libxslt/libxslt_1.1.29.bb | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> > b/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> > index be747e608d9d..1e00306207c5 100644
> > --- a/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> > +++ b/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> > @@ -22,7 +22,7 @@ S = "${WORKDIR}/libxslt-${PV}"
> > 
> >  BINCONFIG = "${bindir}/xslt-config"
> > 
> > -inherit autotools pkgconfig binconfig-disabled lib_package
> > +inherit autotools pkgconfig binconfig-disabled lib_package
> > distutils-common-base
> > 
> >  # We don't DEPEND on binutils for ansidecl.h so ensure we don't
> > use the header
> >  do_configure_prepend () {
> > @@ -33,7 +33,9 @@ do_configure_prepend () {
> >  	touch ${S}/doc/xsltproc.1
> >  }
> > 
> > -EXTRA_OECONF = "--without-python --without-debug --without-mem-
> > debug --without-crypto"
> > +EXTRA_OECONF = "--without-debug --without-mem-debug --without-
> > crypto"
> > +PACKAGECONFIG[libxslt-python] = "--with-
> > python=${PYTHON_BASE_VERSION}, --without-python"
> > +
> You kept "libxslt-python", and I think you meant to change it to
> "python".
> 
Yeah I totally missed that... Will fix it in the next version.

-Vedang
> > 
> >  # older versions of this recipe had ${PN}-utils
> >  RPROVIDES_${PN}-bin += "${PN}-utils"
> >  RCONFLICTS_${PN}-bin += "${PN}-utils"
> >