Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Randy Witt <randy.e.witt@linux.intel.com>
To: Vedang Patel <vedang.patel@intel.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2] libxslt: Add PACKAGECONFIG support for python
Date: Thu, 23 Mar 2017 12:55:06 -0700	[thread overview]
Message-ID: <ee7db60c-985e-49a5-8e64-0632e40d2db2@linux.intel.com> (raw)
In-Reply-To: <1490231158-6151-1-git-send-email-vedang.patel@intel.com>

Hi Patel,

On 03/22/2017 06:05 PM, Vedang Patel wrote:
> Add support to enable python bindings for libxslt using PACKAGECONFIG.
> This will include --with-python argument while compiling the package.
> The support is disabled by default.
>
> Signed-off-by: Vedang Patel <vedang.patel@intel.com>
> ---
>  meta/recipes-support/libxslt/libxslt_1.1.29.bb | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-support/libxslt/libxslt_1.1.29.bb b/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> index be747e608d9d..1e00306207c5 100644
> --- a/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> +++ b/meta/recipes-support/libxslt/libxslt_1.1.29.bb
> @@ -22,7 +22,7 @@ S = "${WORKDIR}/libxslt-${PV}"
>
>  BINCONFIG = "${bindir}/xslt-config"
>
> -inherit autotools pkgconfig binconfig-disabled lib_package
> +inherit autotools pkgconfig binconfig-disabled lib_package distutils-common-base
>
>  # We don't DEPEND on binutils for ansidecl.h so ensure we don't use the header
>  do_configure_prepend () {
> @@ -33,7 +33,9 @@ do_configure_prepend () {
>  	touch ${S}/doc/xsltproc.1
>  }
>
> -EXTRA_OECONF = "--without-python --without-debug --without-mem-debug --without-crypto"
> +EXTRA_OECONF = "--without-debug --without-mem-debug --without-crypto"
> +PACKAGECONFIG[libxslt-python] = "--with-python=${PYTHON_BASE_VERSION}, --without-python"
> +
You kept "libxslt-python", and I think you meant to change it to "python".

>  # older versions of this recipe had ${PN}-utils
>  RPROVIDES_${PN}-bin += "${PN}-utils"
>  RCONFLICTS_${PN}-bin += "${PN}-utils"
>



  reply	other threads:[~2017-03-23 19:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-21  0:31 [PATCH] libxslt: Add PACKAGECONFIG support Vedang Patel
2017-03-21  8:36 ` Jussi Kukkonen
2017-03-22 20:17   ` Patel, Vedang
2017-03-22 20:19     ` Burton, Ross
2017-03-22 22:16       ` Patel, Vedang
2017-03-22 22:18         ` Burton, Ross
2017-03-22 23:33           ` Patel, Vedang
2017-03-23  1:05             ` [PATCH v2] libxslt: Add PACKAGECONFIG support for python Vedang Patel
2017-03-23 19:55               ` Randy Witt [this message]
2017-03-23 21:56                 ` Patel, Vedang
2017-03-24  0:00                   ` [PATCH] " Vedang Patel
2017-03-24  1:39                     ` Andre McCurdy
2017-03-29  0:29                       ` Patel, Vedang
2017-03-23  7:37     ` [PATCH] libxslt: Add PACKAGECONFIG support Jussi Kukkonen
2017-03-23  7:41       ` Jussi Kukkonen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee7db60c-985e-49a5-8e64-0632e40d2db2@linux.intel.com \
    --to=randy.e.witt@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=vedang.patel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox