[PATCH] insane.bbclass: fix override handling in RDEPENDS QA

[PATCH] insane.bbclass: fix override handling in RDEPENDS QA

[Gan, Yau Wai]

The package_qa_check_rdepends() in insane.bbclass has
incorrectly replace its localdata OVERRIDES value with
the package name. Fixing it by appending the package name
to the existing OVERRIDES value. This resolves RDEPENDS QA
error when setting PACKAGECONFIG using a pn- override at
local.conf.

[YOCTO #11374]

Signed-off-by: Gan, Yau Wai <yau.wai.gan@intel.com>
---
 meta/classes/insane.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index dc1c2f8..5a3d017 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -867,7 +867,7 @@ def package_qa_check_rdepends(pkg, pkgdest, skip, taskdeps, packages, d):
 
     if not "-dbg" in pkg and not "packagegroup-" in pkg and not "-image" in pkg:
         localdata = bb.data.createCopy(d)
-        localdata.setVar('OVERRIDES', pkg)
+        localdata.setVar('OVERRIDES', localdata.getVar('OVERRIDES') + ':' + pkg)
 
         # Now check the RDEPENDS
         rdepends = bb.utils.explode_deps(localdata.getVar('RDEPENDS') or "")
-- 
2.7.4

Re: [PATCH] insane.bbclass: fix override handling in RDEPENDS QA

[Leonardo Sandoval]

On Wed, 2017-05-31 at 17:24 -0700, Gan, Yau Wai wrote:
> The package_qa_check_rdepends() in insane.bbclass has
> incorrectly replace its localdata OVERRIDES value with
> the package name. Fixing it by appending the package name
> to the existing OVERRIDES value. This resolves RDEPENDS QA
> error when setting PACKAGECONFIG using a pn- override at
> local.conf.
> 
> [YOCTO #11374]
> 
> Signed-off-by: Gan, Yau Wai <yau.wai.gan@intel.com>
> ---
>  meta/classes/insane.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> index dc1c2f8..5a3d017 100644
> --- a/meta/classes/insane.bbclass
> +++ b/meta/classes/insane.bbclass
> @@ -867,7 +867,7 @@ def package_qa_check_rdepends(pkg, pkgdest, skip, taskdeps, packages, d):
>  
>      if not "-dbg" in pkg and not "packagegroup-" in pkg and not "-image" in pkg:
>          localdata = bb.data.createCopy(d)
> -        localdata.setVar('OVERRIDES', pkg)
> +        localdata.setVar('OVERRIDES', localdata.getVar('OVERRIDES') + ':' + pkg)

you may use localdata.appendVar instead of setting the value again.

>  
>          # Now check the RDEPENDS
>          rdepends = bb.utils.explode_deps(localdata.getVar('RDEPENDS') or "")
> -- 
> 2.7.4
>