Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Valluri, Amarnath" <amarnath.valluri@intel.com>
To: "richard.purdie@linuxfoundation.org"
	<richard.purdie@linuxfoundation.org>,
	 "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v4 1/7] bitbake.conf: support for merged usr with DISTRO_FEATURE usrmerge
Date: Wed, 14 Jun 2017 13:00:41 +0000	[thread overview]
Message-ID: <1497445289.39827.15.camel@intel.com> (raw)
In-Reply-To: <1497440938.3942.48.camel@linuxfoundation.org>

On Wed, 2017-06-14 at 12:48 +0100, Richard Purdie wrote:
> On Wed, 2017-06-14 at 14:30 +0300, Amarnath Valluri wrote:
> > 
> > A new configuration variable ${root_prefix} added, which shall be
> > used by all
> > base_{lib,bin,sbin}dir variables. When usrmerge DISTRO_FEATURE is
> > enabled
> > ${root_prefix} points to ${exec_prefix} otherwise to ${base_prefix}
> > 
> > Signed-off-by: Amarnath Valluri <amarnath.valluri@intel.com>
> > ---
> >  meta/conf/bitbake.conf | 10 ++++++----
> >  1 file changed, 6 insertions(+), 4 deletions(-)
> > 
> > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> > index 5d5ddec..8c497fd 100644
> > --- a/meta/conf/bitbake.conf
> > +++ b/meta/conf/bitbake.conf
> > @@ -17,11 +17,13 @@ export base_prefix = ""
> >  export prefix = "/usr"
> >  export exec_prefix = "${prefix}"
> >  
> > +export root_prefix = "${@bb.utils.contains('DISTRO_FEATURES',
> > 'usrmerge', '${exec_prefix}', '${base_prefix}', d)}"
> > +
> This is a really small nitpick but with changes to the core files we
> need to get this right. Could you drop the "export " above please?
Sure, I will send the revised patch.

- Amarnath

  reply	other threads:[~2017-06-14 13:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-14 11:30 [PATCH v4 0/7] Fix for #7040 - Support for /usr merge Amarnath Valluri
2017-06-14 11:30 ` [PATCH v4 1/7] bitbake.conf: support for merged usr with DISTRO_FEATURE usrmerge Amarnath Valluri
2017-06-14 11:48   ` Richard Purdie
2017-06-14 13:00     ` Valluri, Amarnath [this message]
2017-06-14 13:05     ` [PATCH v5] " Amarnath Valluri
2017-06-14 11:30 ` [PATCH v4 2/7] cross.bbclass: merged /usr support Amarnath Valluri
2017-06-14 11:30 ` [PATCH v4 3/7] systemd: changes to support merged /usr Amarnath Valluri
2017-06-14 11:30 ` [PATCH v4 4/7] image: create symlinks needed for " Amarnath Valluri
2017-06-14 11:30 ` [PATCH v4 5/7] insane.bbclass: Add package QA check " Amarnath Valluri
2017-06-14 11:30 ` [PATCH v4 6/7] meta/lib/oe/sdk.py: support added for executing pre-target commands Amarnath Valluri
2017-06-14 11:30 ` [PATCH v4 7/7] image.bbclass: create root symlinks in nativesdk target sysroot Amarnath Valluri
2017-06-14 13:37   ` Peter Kjellerstedt
2017-06-15  8:32     ` [PATCH v5] " Amarnath Valluri
2017-06-15  9:32       ` Peter Kjellerstedt
2017-06-15 10:28         ` Valluri, Amarnath
2017-06-15 10:32         ` [PATCH v6] " Amarnath Valluri
2017-06-30  7:03 ` [PATCH v4 0/7] Fix for #7040 - Support for /usr merge Valluri, Amarnath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1497445289.39827.15.camel@intel.com \
    --to=amarnath.valluri@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox