Re: [PATCH v5] image.bbclass: create root symlinks in nativesdk target sysroot

["Valluri, Amarnath" <amarnath.valluri@intel.com>]

On Thu, 2017-06-15 at 09:32 +0000, Peter Kjellerstedt wrote:
> > 
> > -----Original Message-----
> > From: openembedded-core-bounces@lists.openembedded.org
> > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf
> > Of
> > Amarnath Valluri
> > Sent: den 15 juni 2017 10:33
> > To: openembedded-core@lists.openembedded.org
> > Subject: [OE-core] [PATCH v5] image.bbclass: create root symlinks
> > in
> > nativesdk target sysroot
> > 
> > To match with the target image, the generated nativesdk's target
> > sysroot also
> > should have the root symlinks(/lib*, /bin/, /sbin). So, extended
> > the
> > 'create_merged_usr_symlinks' to reuse symlink creation part even
> > for nativesdk
> > using POPULATE_SDK_PRE_TARGET_COMMAND.
> > 
> > Signed-off-by: Amarnath Valluri <amarnath.valluri@intel.com>
> > ---
> >  meta/classes/image.bbclass | 29 ++++++++++++++++++++---------
> >  1 file changed, 20 insertions(+), 9 deletions(-)
> > 
> > diff --git a/meta/classes/image.bbclass
> > b/meta/classes/image.bbclass
> > index 2a3c1e3..7c5cfc5 100644
> > --- a/meta/classes/image.bbclass
> > +++ b/meta/classes/image.bbclass
> > @@ -620,21 +620,32 @@ addtask bundle_initramfs after
> > do_image_complete
> > 
> >  # Prepare the root links to point to the /usr counterparts.
> >  create_merged_usr_symlinks() {
> > -    install -d ${IMAGE_ROOTFS}${base_bindir}
> > ${IMAGE_ROOTFS}${base_sbindir} ${IMAGE_ROOTFS}${base_libdir}
> > -    lnr ${IMAGE_ROOTFS}${base_bindir} ${IMAGE_ROOTFS}/bin
> > -    lnr ${IMAGE_ROOTFS}${base_sbindir} ${IMAGE_ROOTFS}/sbin
> > -    lnr ${IMAGE_ROOTFS}${base_libdir} ${IMAGE_ROOTFS}/${baselib}
> > +    root="$1"
> > +    install -d $root${base_bindir} $root${base_sbindir}
> > $root${base_libdir}
> > +    lnr $root${base_bindir} $root/bin
> > +    lnr $root${base_sbindir} $root/sbin
> > +    lnr $root${base_libdir} $root/${baselib}
> > 
> >      if [ "${nonarch_base_libdir}" != "${base_libdir}" ]; then
> > -       install -d ${IMAGE_ROOTFS}${nonarch_base_libdir}
> > -       lnr ${IMAGE_ROOTFS}${nonarch_base_libdir}
> > ${IMAGE_ROOTFS}/lib
> > +       install -m 0755 -d $root${nonarch_base_libdir}
> Meh, missed this the first time, but you reintroduce an unnecessary
> -m 0755 here.
OOps!!! there went something wrong while rebasing my changes, i will
resend the patch, thansk for pointing.

- Amarnath