Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: "Burton, Ross" <ross.burton@intel.com>,
	Ed Bartosh <ed.bartosh@linux.intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] image_types.bbclass: get rid of IMAGE_DEPENDS
Date: Thu, 15 Jun 2017 14:27:29 +0100	[thread overview]
Message-ID: <1497533249.3942.94.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAJTo0LbEz_8uDR0xqSiyD4ZvcxRX4bFCS2Fyx1qn8g_xKTbsaw@mail.gmail.com>

On Thu, 2017-06-15 at 14:25 +0100, Burton, Ross wrote:
> 
> On 15 June 2017 at 12:59, Ed Bartosh <ed.bartosh@linux.intel.com>
> wrote:
> > The IMAGE_DEPENDS variable can be overriden to add dependencies for
> > individual image types.  Those dependencies are added to the
> > do_rootfs
> > task, while they really should be added to the specific image type
> > tasks.
> > 
> Other layers such as meta-raspberrypi use IMAGE_DEPENDS, should we
> move oe-core to use [depends] but handle IMAGE_DEPENDS (with a
> deprecation warning) for some of the 2.4 cycle?

Yes, a fatal error if IMAGE_DEPENDS is set and telling the user what to
change it to would be best IMO.

Cheers,

Richard


  reply	other threads:[~2017-06-15 13:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-15 11:59 [PATCH] image_types.bbclass: get rid of IMAGE_DEPENDS Ed Bartosh
2017-06-15 13:25 ` Burton, Ross
2017-06-15 13:27   ` Richard Purdie [this message]
2017-06-15 16:19     ` [PATCH v2] " Ed Bartosh
2017-06-15 16:51       ` Leonardo Sandoval
2017-06-15 16:47         ` Burton, Ross
2017-06-15 17:07           ` Leonardo Sandoval
2017-06-16  8:40         ` [PATCH v3] " Ed Bartosh
2017-06-16  8:52           ` Richard Purdie
2017-06-16 14:15             ` [PATCH v4] " Ed Bartosh
2017-06-16 14:41               ` Richard Purdie
2017-06-16 15:21                 ` [PATCH v5] " Ed Bartosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1497533249.3942.94.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=ed.bartosh@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox