Re: [PATCH v3] image_types.bbclass: get rid of IMAGE_DEPENDS

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Fri, 2017-06-16 at 11:40 +0300, Ed Bartosh wrote:
> The IMAGE_DEPENDS variable can be overriden to add dependencies for
> individual image types.  Those dependencies are added to the
> do_rootfs
> task, while they really should be added to the specific image type
> tasks.
> 
> Also, the IMAGE_DEPENDS variable is not documented anywhere.
> 
> Replaced usage of IMAGE_DEPENDS with explicitly added
> dependencies to do_image_<image type> tasks.
> 
> [YOCTO #11302]
> 
> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> ---
>  meta/classes/image_types.bbclass | 41 +++++++++++++++++++-----------
> ----------
>  1 file changed, 19 insertions(+), 22 deletions(-)
> 
> diff --git a/meta/classes/image_types.bbclass
> b/meta/classes/image_types.bbclass
> index 7749b00..0d7c27e 100644
> --- a/meta/classes/image_types.bbclass
> +++ b/meta/classes/image_types.bbclass
> @@ -29,12 +29,6 @@ def imagetypes_getdepends(d):
>      deps = set()
>      for typestring in fstypes:
>          basetype, resttypes = split_types(typestring)
> -        adddep(d.getVar('IMAGE_DEPENDS_%s' % basetype) , deps)
> -
> -        for typedepends in (d.getVar("IMAGE_TYPEDEP_%s" % basetype)
> or "").split():
> -            base, rest = split_types(typedepends)
> -            adddep(d.getVar('IMAGE_DEPENDS_%s' % base) , deps)

You need to do the compatibility checking here I'm afraid
since d.getVar('IMAGE_DEPENDS') is not the same thing
as d.getVar('IMAGE_DEPENDS_%s' % base.

Cheers,

Richard