[RFC][PATCH] tclibc-musl: use musl's virtual/gettext implementation

[RFC][PATCH] tclibc-musl: use musl's virtual/gettext implementation

[André Draszik]

From: André Draszik <adraszik@tycoint.com>

musl implements the GNU gettext API version 1 and 2
  http://www.openwall.com/lists/musl/2015/04/16/3

Generally, there should be no need need for the
actual GNU/gettext in systems using musl, so with
this change systems using musl can avoid a needless
dependency on a GPLv3+ tool.

If an application ever appears that needs
GNU/gettext API version 3, we can think about a way
to support it at that time.

Signed-off-by: André Draszik <adraszik@tycoint.com>
Acked-by: Sylvain Lemieux <slemieux@tycoint.com>
---
 meta/conf/distro/include/tclibc-musl.inc | 1 +
 meta/recipes-core/musl/musl_git.bb       | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/conf/distro/include/tclibc-musl.inc b/meta/conf/distro/include/tclibc-musl.inc
index 3d3f6ac4f4..172b09ab20 100644
--- a/meta/conf/distro/include/tclibc-musl.inc
+++ b/meta/conf/distro/include/tclibc-musl.inc
@@ -13,6 +13,7 @@ PREFERRED_PROVIDER_virtual/libiconv ?= "musl"
 PREFERRED_PROVIDER_virtual/libintl ?= "musl"
 PREFERRED_PROVIDER_virtual/nativesdk-libintl ?= "nativesdk-glibc"
 PREFERRED_PROVIDER_virtual/nativesdk-libiconv ?= "nativesdk-glibc"
+PREFERRED_PROVIDER_virtual/gettext ?= "musl"
 
 #USE_NLS ?= "no"
 
diff --git a/meta/recipes-core/musl/musl_git.bb b/meta/recipes-core/musl/musl_git.bb
index fba47096f5..9cf097d067 100644
--- a/meta/recipes-core/musl/musl_git.bb
+++ b/meta/recipes-core/musl/musl_git.bb
@@ -15,7 +15,7 @@ SRC_URI = "git://git.musl-libc.org/musl \
 
 S = "${WORKDIR}/git"
 
-PROVIDES += "virtual/libc virtual/${TARGET_PREFIX}libc-for-gcc virtual/libiconv virtual/libintl"
+PROVIDES += "virtual/libc virtual/${TARGET_PREFIX}libc-for-gcc virtual/gettext virtual/libiconv virtual/libintl"
 
 DEPENDS = "virtual/${TARGET_PREFIX}binutils \
            virtual/${TARGET_PREFIX}gcc-initial \
-- 
2.11.0

Re: [RFC][PATCH] tclibc-musl: use musl's virtual/gettext implementation

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 2346 bytes --]

On Monday, June 19, 2017, André Draszik <git@andred.net> wrote:

> From: André Draszik <adraszik@tycoint.com <javascript:;>>
>
> musl implements the GNU gettext API version 1 and 2
>   http://www.openwall.com/lists/musl/2015/04/16/3
>
> Generally, there should be no need need for the
> actual GNU/gettext in systems using musl, so with
> this change systems using musl can avoid a needless
> dependency on a GPLv3+ tool.
>
> If an application ever appears that needs
> GNU/gettext API version 3, we can think about a way
> to support it at that time.


Thanks for doing this it has been pending for long time
We have to run through some extended builds e.g. Using meta OE
Layers and see for any major regressions

I will cherry pick this into my master and see how it does

>
> Signed-off-by: André Draszik <adraszik@tycoint.com <javascript:;>>
> Acked-by: Sylvain Lemieux <slemieux@tycoint.com <javascript:;>>
> ---
>  meta/conf/distro/include/tclibc-musl.inc | 1 +
>  meta/recipes-core/musl/musl_git.bb       | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/conf/distro/include/tclibc-musl.inc
> b/meta/conf/distro/include/tclibc-musl.inc
> index 3d3f6ac4f4..172b09ab20 100644
> --- a/meta/conf/distro/include/tclibc-musl.inc
> +++ b/meta/conf/distro/include/tclibc-musl.inc
> @@ -13,6 +13,7 @@ PREFERRED_PROVIDER_virtual/libiconv ?= "musl"
>  PREFERRED_PROVIDER_virtual/libintl ?= "musl"
>  PREFERRED_PROVIDER_virtual/nativesdk-libintl ?= "nativesdk-glibc"
>  PREFERRED_PROVIDER_virtual/nativesdk-libiconv ?= "nativesdk-glibc"
> +PREFERRED_PROVIDER_virtual/gettext ?= "musl"
>
>  #USE_NLS ?= "no"
>
> diff --git a/meta/recipes-core/musl/musl_git.bb b/meta/recipes-core/musl/
> musl_git.bb
> index fba47096f5..9cf097d067 100644
> --- a/meta/recipes-core/musl/musl_git.bb
> +++ b/meta/recipes-core/musl/musl_git.bb
> @@ -15,7 +15,7 @@ SRC_URI = "git://git.musl-libc.org/musl \
>
>  S = "${WORKDIR}/git"
>
> -PROVIDES += "virtual/libc virtual/${TARGET_PREFIX}libc-for-gcc
> virtual/libiconv virtual/libintl"
> +PROVIDES += "virtual/libc virtual/${TARGET_PREFIX}libc-for-gcc
> virtual/gettext virtual/libiconv virtual/libintl"
>
>  DEPENDS = "virtual/${TARGET_PREFIX}binutils \
>             virtual/${TARGET_PREFIX}gcc-initial \
> --
> 2.11.0
>
>

[-- Attachment #2: Type: text/html, Size: 3635 bytes --]

Re: [RFC][PATCH] tclibc-musl: use musl's virtual/gettext implementation

[Jussi Kukkonen]

[-- Attachment #1: Type: text/plain, Size: 2551 bytes --]

$ bitbake -k core-image-minimal core-image-full-cmdline core-image-sato
world
That seems to fail with musl on the autobuilder with "Nothing RPROVIDES
'gettext-runtime' "

https://autobuilder.yocto.io/builders/nightly-musl/builds/313/steps/BuildImages/logs/stdio

Cheers,
Jussi

On 19 June 2017 at 13:19, André Draszik <git@andred.net> wrote:
>
> From: André Draszik <adraszik@tycoint.com>
>
> musl implements the GNU gettext API version 1 and 2
>   http://www.openwall.com/lists/musl/2015/04/16/3
>
> Generally, there should be no need need for the
> actual GNU/gettext in systems using musl, so with
> this change systems using musl can avoid a needless
> dependency on a GPLv3+ tool.
>
> If an application ever appears that needs
> GNU/gettext API version 3, we can think about a way
> to support it at that time.
>
> Signed-off-by: André Draszik <adraszik@tycoint.com>
> Acked-by: Sylvain Lemieux <slemieux@tycoint.com>
> ---
>  meta/conf/distro/include/tclibc-musl.inc | 1 +
>  meta/recipes-core/musl/musl_git.bb       | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/conf/distro/include/tclibc-musl.inc
b/meta/conf/distro/include/tclibc-musl.inc
> index 3d3f6ac4f4..172b09ab20 100644
> --- a/meta/conf/distro/include/tclibc-musl.inc
> +++ b/meta/conf/distro/include/tclibc-musl.inc
> @@ -13,6 +13,7 @@ PREFERRED_PROVIDER_virtual/libiconv ?= "musl"
>  PREFERRED_PROVIDER_virtual/libintl ?= "musl"
>  PREFERRED_PROVIDER_virtual/nativesdk-libintl ?= "nativesdk-glibc"
>  PREFERRED_PROVIDER_virtual/nativesdk-libiconv ?= "nativesdk-glibc"
> +PREFERRED_PROVIDER_virtual/gettext ?= "musl"
>
>  #USE_NLS ?= "no"
>
> diff --git a/meta/recipes-core/musl/musl_git.bb b/meta/recipes-core/musl/
musl_git.bb
> index fba47096f5..9cf097d067 100644
> --- a/meta/recipes-core/musl/musl_git.bb
> +++ b/meta/recipes-core/musl/musl_git.bb
> @@ -15,7 +15,7 @@ SRC_URI = "git://git.musl-libc.org/musl \
>
>  S = "${WORKDIR}/git"
>
> -PROVIDES += "virtual/libc virtual/${TARGET_PREFIX}libc-for-gcc
virtual/libiconv virtual/libintl"
> +PROVIDES += "virtual/libc virtual/${TARGET_PREFIX}libc-for-gcc
virtual/gettext virtual/libiconv virtual/libintl"
>
>  DEPENDS = "virtual/${TARGET_PREFIX}binutils \
>             virtual/${TARGET_PREFIX}gcc-initial \
> --
> 2.11.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

[-- Attachment #2: Type: text/html, Size: 3961 bytes --]

Re: [RFC][PATCH] tclibc-musl: use musl's virtual/gettext implementation

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 3032 bytes --]

On Wed, Jun 21, 2017 at 6:27 AM Jussi Kukkonen <jussi.kukkonen@intel.com>
wrote:

> $ bitbake -k core-image-minimal core-image-full-cmdline core-image-sato
> world
> That seems to fail with musl on the autobuilder with "Nothing RPROVIDES
> 'gettext-runtime' "
>
>
> https://autobuilder.yocto.io/builders/nightly-musl/builds/313/steps/BuildImages/logs/stdio
>

Andre can you take care of adding it

>
> Cheers,
> Jussi
>
>
> On 19 June 2017 at 13:19, André Draszik <git@andred.net> wrote:
> >
> > From: André Draszik <adraszik@tycoint.com>
> >
> > musl implements the GNU gettext API version 1 and 2
> >   http://www.openwall.com/lists/musl/2015/04/16/3
> >
> > Generally, there should be no need need for the
> > actual GNU/gettext in systems using musl, so with
> > this change systems using musl can avoid a needless
> > dependency on a GPLv3+ tool.
> >
> > If an application ever appears that needs
> > GNU/gettext API version 3, we can think about a way
> > to support it at that time.
> >
> > Signed-off-by: André Draszik <adraszik@tycoint.com>
> > Acked-by: Sylvain Lemieux <slemieux@tycoint.com>
> > ---
> >  meta/conf/distro/include/tclibc-musl.inc | 1 +
> >  meta/recipes-core/musl/musl_git.bb       | 2 +-
> >  2 files changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/conf/distro/include/tclibc-musl.inc
> b/meta/conf/distro/include/tclibc-musl.inc
> > index 3d3f6ac4f4..172b09ab20 100644
> > --- a/meta/conf/distro/include/tclibc-musl.inc
> > +++ b/meta/conf/distro/include/tclibc-musl.inc
> > @@ -13,6 +13,7 @@ PREFERRED_PROVIDER_virtual/libiconv ?= "musl"
> >  PREFERRED_PROVIDER_virtual/libintl ?= "musl"
> >  PREFERRED_PROVIDER_virtual/nativesdk-libintl ?= "nativesdk-glibc"
> >  PREFERRED_PROVIDER_virtual/nativesdk-libiconv ?= "nativesdk-glibc"
> > +PREFERRED_PROVIDER_virtual/gettext ?= "musl"
> >
> >  #USE_NLS ?= "no"
> >
> > diff --git a/meta/recipes-core/musl/musl_git.bb
> b/meta/recipes-core/musl/musl_git.bb
> > index fba47096f5..9cf097d067 100644
> > --- a/meta/recipes-core/musl/musl_git.bb
> > +++ b/meta/recipes-core/musl/musl_git.bb
> > @@ -15,7 +15,7 @@ SRC_URI = "git://git.musl-libc.org/musl \
> >
> >  S = "${WORKDIR}/git"
> >
> > -PROVIDES += "virtual/libc virtual/${TARGET_PREFIX}libc-for-gcc
> virtual/libiconv virtual/libintl"
> > +PROVIDES += "virtual/libc virtual/${TARGET_PREFIX}libc-for-gcc
> virtual/gettext virtual/libiconv virtual/libintl"
> >
> >  DEPENDS = "virtual/${TARGET_PREFIX}binutils \
> >             virtual/${TARGET_PREFIX}gcc-initial \
> > --
> > 2.11.0
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 5166 bytes --]

Re: [RFC][PATCH] tclibc-musl: use musl's virtual/gettext implementation

[André Draszik]

On Wed, 2017-06-21 at 12:27 +0000, Khem Raj wrote:
> On Wed, Jun 21, 2017 at 6:27 AM Jussi Kukkonen <jussi.kukkonen@intel.com>
> wrote:
> 
> > $ bitbake -k core-image-minimal core-image-full-cmdline core-image-sato
> > world
> > That seems to fail with musl on the autobuilder with "Nothing RPROVIDES
> > 'gettext-runtime' "
> > 
> > 
> > https://autobuilder.yocto.io/builders/nightly-musl/builds/313/steps/Buil
> > dImages/logs/stdio
> > 
> 
> Andre can you take care of adding it

OK, I'll have a look. core-image-minimal works fine, the other targets
require GPLv3 & X11, which might take me a few days to set up to reproduce.

Cheers,
Andre'