[PATCH] context: allow test execution with buildhistory unless version-going-backwards is present

[PATCH] context: allow test execution with buildhistory unless version-going-backwards is present

[leonardo.sandoval.gonzalez]

From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>

Users constantly running oe-selftest find annoying to disable buildhistory before running
'oe-selftest' then enabling after it. To lessen the buildhistory restriction, allow buildhistory
unless 'version-going-backwards' is present on ERROR_QA bitbake variable.

[YOCTO #11580]

Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
---
 meta/lib/oeqa/selftest/context.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/lib/oeqa/selftest/context.py b/meta/lib/oeqa/selftest/context.py
index ca73070c0b..f061b987b0 100644
--- a/meta/lib/oeqa/selftest/context.py
+++ b/meta/lib/oeqa/selftest/context.py
@@ -150,7 +150,8 @@ class OESelftestTestContextExecutor(OETestContextExecutor):
         _check_required_env_variables(["BUILDDIR"])
         _check_presence_meta_selftest()
 
-        if "buildhistory.bbclass" in self.tc.td["BBINCLUDED"]:
+        # buildhistory introduce QA 'version-going-backwards' errors so stop if the latter are enabled
+        if "buildhistory.bbclass" in self.tc.td["BBINCLUDED"] and 'version-going-backwards' in self.tc.td['ERROR_QA']:
             self.tc.logger.error("You have buildhistory enabled already and this isn't recommended for selftest, please disable it first.")
             raise OEQAPreRun
 
-- 
2.12.0

Re: [PATCH] context: allow test execution with buildhistory unless version-going-backwards is present

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

On 8 June 2017 at 21:40, <leonardo.sandoval.gonzalez@linux.intel.com> wrote:

> -        if "buildhistory.bbclass" in self.tc.td["BBINCLUDED"]:
> +        # buildhistory introduce QA 'version-going-backwards' errors so
> stop if the latter are enabled
> +        if "buildhistory.bbclass" in self.tc.td["BBINCLUDED"] and
> 'version-going-backwards' in self.tc.td['ERROR_QA']:
>

Would it be possible instead to remove version-going-backwards from
ERROR_QA?

Ross

[-- Attachment #2: Type: text/html, Size: 1174 bytes --]

Re: [PATCH] context: allow test execution with buildhistory unless version-going-backwards is present

[Leonardo Sandoval]

On Fri, 2017-06-09 at 13:51 +0100, Burton, Ross wrote:
> 
> On 8 June 2017 at 21:40, <leonardo.sandoval.gonzalez@linux.intel.com>
> wrote:
>         -        if "buildhistory.bbclass" in
>         self.tc.td["BBINCLUDED"]:
>         +        # buildhistory introduce QA 'version-going-backwards'
>         errors so stop if the latter are enabled
>         +        if "buildhistory.bbclass" in self.tc.td["BBINCLUDED"]
>         and 'version-going-backwards' in self.tc.td['ERROR_QA']:
>         
> 
> Would it be possible instead to remove version-going-backwards from
> ERROR_QA?

At the bug entry, there is a discussion around this. The idea is to keep
buildhistory disable while oe-selftest is executing, but if user really
needs this, 'force' the user to remove this check from the ERROR_QA
string on his/her local.conf.
> 
> 
> Ross

Re: [PATCH] context: allow test execution with buildhistory unless version-going-backwards is present

[Leonardo Sandoval]

The proposed approach is not the best one as discussed by RP [1]:

""Just as another note, 

ERROR_QA_remove = "version-going-backwards"
WARN_QA_remove = "version-going-backwards"

doesn't work since we can't then enable this check and the test cases
test_buildhistory_buildtime_pr_backwards and test_buildhistory_diff then
fail."

[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=11580#c7


On Thu, 2017-06-08 at 13:40 -0700,
leonardo.sandoval.gonzalez@linux.intel.com wrote:
> From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
> 
> Users constantly running oe-selftest find annoying to disable buildhistory before running
> 'oe-selftest' then enabling after it. To lessen the buildhistory restriction, allow buildhistory
> unless 'version-going-backwards' is present on ERROR_QA bitbake variable.
> 
> [YOCTO #11580]
> 
> Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
> ---
>  meta/lib/oeqa/selftest/context.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/lib/oeqa/selftest/context.py b/meta/lib/oeqa/selftest/context.py
> index ca73070c0b..f061b987b0 100644
> --- a/meta/lib/oeqa/selftest/context.py
> +++ b/meta/lib/oeqa/selftest/context.py
> @@ -150,7 +150,8 @@ class OESelftestTestContextExecutor(OETestContextExecutor):
>          _check_required_env_variables(["BUILDDIR"])
>          _check_presence_meta_selftest()
>  
> -        if "buildhistory.bbclass" in self.tc.td["BBINCLUDED"]:
> +        # buildhistory introduce QA 'version-going-backwards' errors so stop if the latter are enabled
> +        if "buildhistory.bbclass" in self.tc.td["BBINCLUDED"] and 'version-going-backwards' in self.tc.td['ERROR_QA']:
>              self.tc.logger.error("You have buildhistory enabled already and this isn't recommended for selftest, please disable it first.")
>              raise OEQAPreRun
>