Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Patrick Ohly <patrick.ohly@intel.com>
To: ed.bartosh@linux.intel.com
Cc: Otavio Salvador <otavio.salvador@ossystems.com.br>,
	Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2 0/5] #11662 - wic should mount /boot
Date: Mon, 03 Jul 2017 09:53:32 +0200	[thread overview]
Message-ID: <1499068412.5259.71.camel@intel.com> (raw)
In-Reply-To: <20170703073115.GA5380@linux.intel.com>

On Mon, 2017-07-03 at 10:31 +0300, Ed Bartosh wrote:
> On Fri, Jun 30, 2017 at 08:34:30PM +0200, Patrick Ohly wrote:
> > then I don't see a need for any additional flags. Just
> > don't use the features which result in a rootfs modification.
> 
> I also didn't see it till last message from Otavio. Now I do - they
> don't want to change .wks files. They're using standard wks from
> scripts/lib/wic/canned-wks or from standard layers and they don't want
> to duplicate them when they don't want rootfs modifications.
> 
> It could be a valid reason to have --no-fstab-update option I think.
> However, I'm still not 100% convinced I'm ok with this if nobody else
> objects.

Okay, now I see what the purpose is.

I prefer a --no-fstab-update over a general --no-rootfs-update because
for each case where wic would normally modify the rootfs, some other
mechanism must be in place which makes that modification redundant (like
using PARTUUID). Having separate parameters forces the developers to
think about it. Just my 2 cents...

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.





  reply	other threads:[~2017-07-03  7:53 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-27 13:28 [PATCH v2 0/5] #11662 - wic should mount /boot Ed Bartosh
2017-06-27 13:28 ` [PATCH v2 1/5] wic: copy rootfs directory before changing fstab Ed Bartosh
2017-07-04 22:16   ` Burton, Ross
2017-07-05  8:01     ` Ed Bartosh
2017-07-05 10:38       ` Burton, Ross
2017-06-27 13:28 ` [PATCH v2 2/5] wic: use absolute paths in rootfs plugin Ed Bartosh
2017-06-27 13:28 ` [PATCH v2 3/5] wic: rootfs: fix rootfs path reporting Ed Bartosh
2017-06-27 13:28 ` [PATCH v2 4/5] wic: rootfs: make copied rootfs unique Ed Bartosh
2017-06-27 13:28 ` [PATCH v2 5/5] wic: add /boot mount point to fstab by default Ed Bartosh
2017-06-27 20:35 ` [PATCH v2 0/5] #11662 - wic should mount /boot Otavio Salvador
2017-06-27 20:41   ` Fabio Berton
2017-06-28  7:31     ` Ed Bartosh
2017-06-28 13:32       ` Otavio Salvador
2017-06-29  8:39         ` Ed Bartosh
2017-06-30  8:37           ` Ed Bartosh
2017-06-30  9:02             ` Patrick Ohly
2017-06-30 12:23               ` Ed Bartosh
2017-06-30 13:16                 ` Patrick Ohly
2017-06-30 13:58                   ` Otavio Salvador
2017-06-30 15:37                     ` Ed Bartosh
2017-06-30 15:44                   ` Ed Bartosh
2017-06-30 17:33                     ` Otavio Salvador
2017-06-30 18:34                       ` Patrick Ohly
2017-07-03  7:31                         ` Ed Bartosh
2017-07-03  7:53                           ` Patrick Ohly [this message]
2017-07-03  8:59                             ` Ed Bartosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1499068412.5259.71.camel@intel.com \
    --to=patrick.ohly@intel.com \
    --cc=ed.bartosh@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=otavio.salvador@ossystems.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox