From: Ed Bartosh <ed.bartosh@linux.intel.com>
To: Patrick Ohly <patrick.ohly@intel.com>
Cc: Otavio Salvador <otavio.salvador@ossystems.com.br>,
Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2 0/5] #11662 - wic should mount /boot
Date: Mon, 3 Jul 2017 10:31:15 +0300 [thread overview]
Message-ID: <20170703073115.GA5380@linux.intel.com> (raw)
In-Reply-To: <1498847670.5259.9.camel@intel.com>
On Fri, Jun 30, 2017 at 08:34:30PM +0200, Patrick Ohly wrote:
> On Fri, 2017-06-30 at 14:33 -0300, Otavio Salvador wrote:
> > Other possible rootfs changes also should be possible to be disabled
> > but IMO it should be per-feature (one for fstab, one for exclude,
> > ...).
>
> I also think it should be per-feature, it necessary at all.
>
> I still do not fully understand under which circumstances wic modifies
> the rootfs. If that happens only when explicitly requested in the wks
> file as Ed said, then I don't see a need for any additional flags.
Yes, that happens only if it explicitly requested, i.e. if there are valid
mount points in .wks file
> then I don't see a need for any additional flags. Just
> don't use the features which result in a rootfs modification.
I also didn't see it till last message from Otavio. Now I do - they
don't want to change .wks files. They're using standard wks from
scripts/lib/wic/canned-wks or from standard layers and they don't want
to duplicate them when they don't want rootfs modifications.
It could be a valid reason to have --no-fstab-update option I think.
However, I'm still not 100% convinced I'm ok with this if nobody else
objects.
--
Regards,
Ed
next prev parent reply other threads:[~2017-07-03 7:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 13:28 [PATCH v2 0/5] #11662 - wic should mount /boot Ed Bartosh
2017-06-27 13:28 ` [PATCH v2 1/5] wic: copy rootfs directory before changing fstab Ed Bartosh
2017-07-04 22:16 ` Burton, Ross
2017-07-05 8:01 ` Ed Bartosh
2017-07-05 10:38 ` Burton, Ross
2017-06-27 13:28 ` [PATCH v2 2/5] wic: use absolute paths in rootfs plugin Ed Bartosh
2017-06-27 13:28 ` [PATCH v2 3/5] wic: rootfs: fix rootfs path reporting Ed Bartosh
2017-06-27 13:28 ` [PATCH v2 4/5] wic: rootfs: make copied rootfs unique Ed Bartosh
2017-06-27 13:28 ` [PATCH v2 5/5] wic: add /boot mount point to fstab by default Ed Bartosh
2017-06-27 20:35 ` [PATCH v2 0/5] #11662 - wic should mount /boot Otavio Salvador
2017-06-27 20:41 ` Fabio Berton
2017-06-28 7:31 ` Ed Bartosh
2017-06-28 13:32 ` Otavio Salvador
2017-06-29 8:39 ` Ed Bartosh
2017-06-30 8:37 ` Ed Bartosh
2017-06-30 9:02 ` Patrick Ohly
2017-06-30 12:23 ` Ed Bartosh
2017-06-30 13:16 ` Patrick Ohly
2017-06-30 13:58 ` Otavio Salvador
2017-06-30 15:37 ` Ed Bartosh
2017-06-30 15:44 ` Ed Bartosh
2017-06-30 17:33 ` Otavio Salvador
2017-06-30 18:34 ` Patrick Ohly
2017-07-03 7:31 ` Ed Bartosh [this message]
2017-07-03 7:53 ` Patrick Ohly
2017-07-03 8:59 ` Ed Bartosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170703073115.GA5380@linux.intel.com \
--to=ed.bartosh@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=otavio.salvador@ossystems.com.br \
--cc=patrick.ohly@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox