[pyro][PATCH 0/1] Backport fix for debugfs generation

[pyro][PATCH 0/1] Backport fix for debugfs generation

[Anders Darander]

An older commit, which is in both master and pyro, broke the generation of 
debugfs'. This has been fixed in master by Martin Jansa, so lets backport this to
pyro.

The following changes since commit 0b5e0d072f93a958e4211a8aeb2fd8cc3c25cc21:

  package_ipk: Clean up Source entry in ipk packages (2017-06-16 10:18:55 +0100)

are available in the git repository at:

  git://github.com/darander/openembedded-core pyro-debugfs
  https://github.com/darander/openembedded-core/tree/pyro-debugfs

Martin Jansa (1):
  package_manager: flush installed_pkgs file before oe-pkgdata-util uses
    it

 meta/lib/oe/package_manager.py | 1 +
 1 file changed, 1 insertion(+)

-- 
2.13.1

[pyro][PATCH 1/1] package_manager: flush installed_pkgs file before oe-pkgdata-util uses it

[Anders Darander]

From: Martin Jansa <martin.jansa@gmail.com>

* since this commit:
  commit f5a1013ffa9815f22e13989e2bcb83f966e7ce2c
  Author: Ross Burton <ross.burton@intel.com>
  Date:   Tue Apr 18 16:19:12 2017 +0100

    package_manager: don't race on a file when installing complementary
    packages

  the file isn't closed before oe-pkgdata-util uses it and this
  temporary file might look empty to oe-pkgdata-util, because it
  wasn't flushed yet. Which resulted in almost empty debugfs tarballs
  and no locale packages in regular rootfs.
* without this change:
  124K May 30 07:41 core-image-full-cmdline-raspberrypi3-64-20170530054003-dbg.rootfs.tar.gz
* with this change:
  173M May 30 07:29 core-image-full-cmdline-raspberrypi3-64-20170530052715-dbg.rootfs.tar.gz

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 877d38db08aa7060d16405443cf70539c559fe82)
Signed-off-by: Anders Darander <anders@chargestorm.se>
---
 meta/lib/oe/package_manager.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/lib/oe/package_manager.py b/meta/lib/oe/package_manager.py
index f1b65bdbbc..2795dd3823 100644
--- a/meta/lib/oe/package_manager.py
+++ b/meta/lib/oe/package_manager.py
@@ -399,6 +399,7 @@ class PackageManager(object, metaclass=ABCMeta):
             pkgs = self.list_installed()
             output = oe.utils.format_pkg_list(pkgs, "arch")
             installed_pkgs.write(output)
+            installed_pkgs.flush()
 
             cmd = [bb.utils.which(os.getenv('PATH'), "oe-pkgdata-util"),
                    "-p", self.d.getVar('PKGDATA_DIR'), "glob", installed_pkgs.name,
-- 
2.13.1

Re: [pyro][PATCH 1/1] package_manager: flush installed_pkgs file before oe-pkgdata-util uses it

[Anders Darander]

* Anders Darander <anders@chargestorm.se> [170626 08:53]:

> From: Martin Jansa <martin.jansa@gmail.com>

> * since this commit:
>   commit f5a1013ffa9815f22e13989e2bcb83f966e7ce2c
>   Author: Ross Burton <ross.burton@intel.com>
>   Date:   Tue Apr 18 16:19:12 2017 +0100

>     package_manager: don't race on a file when installing complementary
>     packages

>   the file isn't closed before oe-pkgdata-util uses it and this
>   temporary file might look empty to oe-pkgdata-util, because it
>   wasn't flushed yet. Which resulted in almost empty debugfs tarballs
>   and no locale packages in regular rootfs.
> * without this change:
>   124K May 30 07:41 core-image-full-cmdline-raspberrypi3-64-20170530054003-dbg.rootfs.tar.gz
> * with this change:

Ping. 

Cheers,
Anders

Re: [pyro][PATCH 1/1] package_manager: flush installed_pkgs file before oe-pkgdata-util uses it

[Richard Purdie]

On Wed, 2017-07-05 at 15:53 +0200, Anders Darander wrote:
> * Anders Darander <anders@chargestorm.se> [170626 08:53]:
> 
> > 
> > From: Martin Jansa <martin.jansa@gmail.com>
> > 
> > * since this commit:
> >   commit f5a1013ffa9815f22e13989e2bcb83f966e7ce2c
> >   Author: Ross Burton <ross.burton@intel.com>
> >   Date:   Tue Apr 18 16:19:12 2017 +0100
> > 
> >     package_manager: don't race on a file when installing
> > complementary
> >     packages
> > 
> >   the file isn't closed before oe-pkgdata-util uses it and this
> >   temporary file might look empty to oe-pkgdata-util, because it
> >   wasn't flushed yet. Which resulted in almost empty debugfs
> > tarballs
> >   and no locale packages in regular rootfs.
> > * without this change:
> >   124K May 30 07:41 core-image-full-cmdline-raspberrypi3-64-
> > 20170530054003-dbg.rootfs.tar.gz
> > * with this change:
> Ping. 

I did queue this in pyro-next earlier too. I suspect there are others
I've missed but I am trying to change my processes to make this easier
for me to make sure things get caught.

Cheers,

Richard

Re: [pyro][PATCH 1/1] package_manager: flush installed_pkgs file before oe-pkgdata-util uses it

[Anders Darander]

* Richard Purdie <richard.purdie@linuxfoundation.org> [170705 16:33]:

> On Wed, 2017-07-05 at 15:53 +0200, Anders Darander wrote:
> > * Anders Darander <anders@chargestorm.se> [170626 08:53]:


> > > From: Martin Jansa <martin.jansa@gmail.com>

> > > * since this commit:
> > >   commit f5a1013ffa9815f22e13989e2bcb83f966e7ce2c
> > >   Author: Ross Burton <ross.burton@intel.com>
> > >   Date:   Tue Apr 18 16:19:12 2017 +0100

> > >     package_manager: don't race on a file when installing
> > > complementary
> > >     packages

> > >   the file isn't closed before oe-pkgdata-util uses it and this
> > >   temporary file might look empty to oe-pkgdata-util, because it
> > >   wasn't flushed yet. Which resulted in almost empty debugfs
> > > tarballs
> > >   and no locale packages in regular rootfs.
> > > * without this change:
> > >   124K May 30 07:41 core-image-full-cmdline-raspberrypi3-64-
> > > 20170530054003-dbg.rootfs.tar.gz
> > > * with this change:
> > Ping. 

> I did queue this in pyro-next earlier too. I suspect there are others
> I've missed but I am trying to change my processes to make this easier
> for me to make sure things get caught.

Ah, thanks!

I looked at
http://git.openembedded.org/openembedded-core/log/?h=pyro-next, and
couldn't find see it, that's why I sent a ping...

Cheers,
Anders

-- 
Anders Darander, Senior System Architect
ChargeStorm AB / eStorm AB