[PATCH v2] openssl: disable default cryptodev

[PATCH v2] openssl: disable default cryptodev

[Huang Qiyu]

Because according to the other Distros,cryptodev is not enabled.
If users want enable cryptodev, just have to add "cryptodev-linux" into PACKAGECONFIG.

Signed-off-by: Huang Qiyu <huangqy.fnst@cn.fujitsu.com>
---
 meta/recipes-connectivity/openssl/openssl_1.0.2l.bb | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/meta/recipes-connectivity/openssl/openssl_1.0.2l.bb b/meta/recipes-connectivity/openssl/openssl_1.0.2l.bb
index c00dd81..7c8f18b 100644
--- a/meta/recipes-connectivity/openssl/openssl_1.0.2l.bb
+++ b/meta/recipes-connectivity/openssl/openssl_1.0.2l.bb
@@ -2,10 +2,8 @@ require openssl.inc
 
 # For target side versions of openssl enable support for OCF Linux driver
 # if they are available.
-PACKAGECONFIG[cryptodev-linux] = ",,cryptodev-linux"
-DEPENDS += "${@bb.utils.contains('PACKAGECONFIG', 'cryptodev-linux', 'cryptodev-linux', '', d)}"
-
-CFLAG += "${@bb.utils.contains('PACKAGECONFIG', 'cryptodev-linux', '-DHAVE_CRYPTODEV -DUSE_CRYPTODEV_DIGESTS', '', d)}"
+PACKAGECONFIG[cryptodev-linux] = "-DHAVE_CRYPTODEV -DUSE_CRYPTODEV_DIGESTS,,cryptodev-linux"
+CFLAG += "${PACKAGECONFIG_CONFARGS}"
 
 CFLAG_append_class-native = " -fPIC"
 
-- 
2.7.4

✗ patchtest: failure for openssl: disable default cryptodev

[Patchwork]

== Series Details ==

Series: openssl: disable default cryptodev
Revision: 1
URL   : https://patchwork.openembedded.org/series/7965/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Series does not apply on top of target branch [test_series_merge_on_head] 
  Suggested fix    Rebase your series on top of targeted branch
  Targeted branch  master (currently at 51b3ee2986)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: [PATCH v2] openssl: disable default cryptodev

[Richard Purdie]

On Thu, 2017-07-27 at 13:17 +0800, Huang Qiyu wrote:
> Because according to the other Distros,cryptodev is not enabled.
> If users want enable cryptodev, just have to add "cryptodev-linux"
> into PACKAGECONFIG.

We really need more of a justification for this change. We presumably
enable this for a reason and people probably use it. Why is disabling
it by default a better thing for the project to do? Are there specific
reasons other distros don't enable this?

Cheers,

Richard