[pyro][PATCH] package_manager: Fix support for NO_RECOMMENDATONS

[pyro][PATCH] package_manager: Fix support for NO_RECOMMENDATONS

[Richard Röjfors]

When support for dnf was introduced the check of the
no NO_RECOMMENDATIONS variable got broken.

This fixes the issue by compairing to the string "1"
rather than the number 1.

Signed-off-by: Richard Röjfors <richard@puffinpack.se>
---
 meta/lib/oe/package_manager.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/lib/oe/package_manager.py b/meta/lib/oe/package_manager.py
index 93d079d73d..28c6b2aec2 100644
--- a/meta/lib/oe/package_manager.py
+++ b/meta/lib/oe/package_manager.py
@@ -585,7 +585,7 @@ class RpmPM(PackageManager):
 
         output = self._invoke_dnf((["--skip-broken"] if attempt_only else []) +
                          (["-x", ",".join(exclude_pkgs)] if len(exclude_pkgs) > 0 else []) +
-                         (["--setopt=install_weak_deps=False"] if self.d.getVar('NO_RECOMMENDATIONS') == 1 else []) +
+                         (["--setopt=install_weak_deps=False"] if self.d.getVar('NO_RECOMMENDATIONS') == "1" else []) +
                          (["--nogpgcheck"] if self.d.getVar('RPM_SIGN_PACKAGES') != '1' else ["--setopt=gpgcheck=True"]) +
                          ["install"] +
                          pkgs)
-- 
2.11.0

✗ patchtest: failure for package_manager: Fix support for NO_RECOMMENDATONS (rev3)

[Patchwork]

== Series Details ==

Series: package_manager: Fix support for NO_RECOMMENDATONS (rev3)
Revision: 3
URL   : https://patchwork.openembedded.org/series/8021/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Series cannot be parsed correctly due to malformed diff lines [test_mbox_format] 
  Suggested fix    Create the series again using git-format-patch and ensure it can be applied using git am
  Diff line          




If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: [pyro][PATCH] package_manager: Fix support for NO_RECOMMENDATONS

[akuster808]

On 08/06/2017 11:21 PM, Richard Röjfors wrote:
> When support for dnf was introduced the check of the
> no NO_RECOMMENDATIONS variable got broken.
>
> This fixes the issue by compairing to the string "1"
> rather than the number 1.

merged to stagging.
Thanks,
Armin
>
> Signed-off-by: Richard Röjfors <richard@puffinpack.se>
> ---
>   meta/lib/oe/package_manager.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/lib/oe/package_manager.py b/meta/lib/oe/package_manager.py
> index 93d079d73d..28c6b2aec2 100644
> --- a/meta/lib/oe/package_manager.py
> +++ b/meta/lib/oe/package_manager.py
> @@ -585,7 +585,7 @@ class RpmPM(PackageManager):
>   
>           output = self._invoke_dnf((["--skip-broken"] if attempt_only else []) +
>                            (["-x", ",".join(exclude_pkgs)] if len(exclude_pkgs) > 0 else []) +
> -                         (["--setopt=install_weak_deps=False"] if self.d.getVar('NO_RECOMMENDATIONS') == 1 else []) +
> +                         (["--setopt=install_weak_deps=False"] if self.d.getVar('NO_RECOMMENDATIONS') == "1" else []) +
>                            (["--nogpgcheck"] if self.d.getVar('RPM_SIGN_PACKAGES') != '1' else ["--setopt=gpgcheck=True"]) +
>                            ["install"] +
>                            pkgs)
> -- 
> 2.11.0