Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH v2] initramfs-framework: Change recipe to be allarch
@ 2017-08-27 21:10 Otavio Salvador
  2017-08-27 21:21 ` Richard Purdie
  0 siblings, 1 reply; 3+ messages in thread
From: Otavio Salvador @ 2017-08-27 21:10 UTC (permalink / raw)
  To: OpenEmbedded Core Mailing List; +Cc: Otavio Salvador

There is no COMPATIBLE_HOST in the recipe neither it makes sense for
this to be machine specific.

Possibly, initramfs-framework's based modules may be machine specific
but if there is the case they can just RDEPENDS on
initramfs-framework-base and provide the specific module as another
recipe.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---

Changes in v2:
- Add the new dependencies to the hash whitelist

 meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb b/meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb
index 9d69a696f1..94bf1756e3 100644
--- a/meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb
+++ b/meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb
@@ -3,12 +3,10 @@ LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
 RDEPENDS_${PN} += "${VIRTUAL-RUNTIME_base-utils}"
 
-PR = "r2"
+PR = "r3"
+
+inherit allarch
 
-# While the packages maybe an allarch due to it being a
-# simple script, reality is that it is Host specific based
-# on the COMPATIBLE_HOST below, which needs to take precedence
-#inherit allarch
 INHIBIT_DEFAULT_DEPS = "1"
 
 SRC_URI = "file://init \
-- 
2.14.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] initramfs-framework: Change recipe to be allarch
  2017-08-27 21:10 [PATCH v2] initramfs-framework: Change recipe to be allarch Otavio Salvador
@ 2017-08-27 21:21 ` Richard Purdie
  2017-08-27 21:49   ` Otavio Salvador
  0 siblings, 1 reply; 3+ messages in thread
From: Richard Purdie @ 2017-08-27 21:21 UTC (permalink / raw)
  To: Otavio Salvador, OpenEmbedded Core Mailing List

On Sun, 2017-08-27 at 18:10 -0300, Otavio Salvador wrote:
> There is no COMPATIBLE_HOST in the recipe neither it makes sense for
> this to be machine specific.
> 
> Possibly, initramfs-framework's based modules may be machine specific
> but if there is the case they can just RDEPENDS on
> initramfs-framework-base and provide the specific module as another
> recipe.
> 
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> 
> Changes in v2:
> - Add the new dependencies to the hash whitelist
> 
>  meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb | 8 +++

I think there may be something missing here as this looks like v1...

Cheers,

Richard


> -----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/meta/recipes-core/initrdscripts/initramfs-
> framework_1.0.bb b/meta/recipes-core/initrdscripts/initramfs-
> framework_1.0.bb
> index 9d69a696f1..94bf1756e3 100644
> --- a/meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb
> +++ b/meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb
> @@ -3,12 +3,10 @@ LICENSE = "MIT"
>  LIC_FILES_CHKSUM =
> "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de2
> 0420"
>  RDEPENDS_${PN} += "${VIRTUAL-RUNTIME_base-utils}"
>  
> -PR = "r2"
> +PR = "r3"
> +
> +inherit allarch
>  
> -# While the packages maybe an allarch due to it being a
> -# simple script, reality is that it is Host specific based
> -# on the COMPATIBLE_HOST below, which needs to take precedence
> -#inherit allarch
>  INHIBIT_DEFAULT_DEPS = "1"
>  
>  SRC_URI = "file://init \
> -- 
> 2.14.1
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] initramfs-framework: Change recipe to be allarch
  2017-08-27 21:21 ` Richard Purdie
@ 2017-08-27 21:49   ` Otavio Salvador
  0 siblings, 0 replies; 3+ messages in thread
From: Otavio Salvador @ 2017-08-27 21:49 UTC (permalink / raw)
  To: Richard Purdie; +Cc: Otavio Salvador, OpenEmbedded Core Mailing List

On Sun, Aug 27, 2017 at 6:21 PM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Sun, 2017-08-27 at 18:10 -0300, Otavio Salvador wrote:
>> There is no COMPATIBLE_HOST in the recipe neither it makes sense for
>> this to be machine specific.
>>
>> Possibly, initramfs-framework's based modules may be machine specific
>> but if there is the case they can just RDEPENDS on
>> initramfs-framework-base and provide the specific module as another
>> recipe.
>>
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>>
>> Changes in v2:
>> - Add the new dependencies to the hash whitelist
>>
>>  meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb | 8 +++
>
> I think there may be something missing here as this looks like v1...

My fault, v3 is on the way.


-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-08-27 21:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-27 21:10 [PATCH v2] initramfs-framework: Change recipe to be allarch Otavio Salvador
2017-08-27 21:21 ` Richard Purdie
2017-08-27 21:49   ` Otavio Salvador

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox