[PATCH 0/1] dbus: fix ptest runtime failures

[PATCH 0/1] dbus: fix ptest runtime failures

[kai.kang]

From: Kai Kang <kai.kang@windriver.com>

The following changes since commit ee5bce2d11e783c0921df47b629025a6b67c44bf:

  kernel-dev: Removed bad reference for creating patches. (2017-09-02 00:52:49 +0100)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib kangkai/dbus
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=kangkai/dbus

Kai Kang (1):
  dbus: fix ptest runtime failures

 meta/recipes-core/dbus/dbus-test_1.10.20.bb | 3 +++
 meta/recipes-core/dbus/dbus_1.10.20.bb      | 6 +++---
 2 files changed, 6 insertions(+), 3 deletions(-)

-- 
2.14.1

[PATCH 1/1] dbus: fix ptest runtime failures

[kai.kang]

From: Kai Kang <kai.kang@windriver.com>

When run dbus ptest cases, there are some failures:

| ./test/test-dbus-daemon: relocation error: ./test/test-dbus-daemon: symbol
| _dbus_real_assert, version LIBDBUS_PRIVATE_1.10.20 not defined in file
| libdbus-1.so.3 with link time reference
| FAIL: test/test-dbus-daemon
| [   24.943454] test-dbus-daemo[251]: segfault at 0 ip           (null) sp
| 00007ffddabe6818 error 14 in test-dbus-daemon-eavesdrop[ 400000+a000]

It disables tests in dbus recipe which cases symbols missing and segment
fault. When 'ptest' in DISTRO_FEATURES, it should enable some configure
options to make the symbols visible to ptest cases.

It also need to correct paths in ptest configure files.

Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
 meta/recipes-core/dbus/dbus-test_1.10.20.bb | 3 +++
 meta/recipes-core/dbus/dbus_1.10.20.bb      | 6 +++---
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/meta/recipes-core/dbus/dbus-test_1.10.20.bb b/meta/recipes-core/dbus/dbus-test_1.10.20.bb
index eeadb7d35b..d50bbc8fd6 100644
--- a/meta/recipes-core/dbus/dbus-test_1.10.20.bb
+++ b/meta/recipes-core/dbus/dbus-test_1.10.20.bb
@@ -54,5 +54,8 @@ do_install_ptest() {
 	for i in $l; do install ${B}/bus/.libs/test-$i ${D}${PTEST_PATH}/test; done
 	install ${B}/dbus/.libs/test-dbus ${D}${PTEST_PATH}/test
 	cp -r ${B}/test/data ${D}${PTEST_PATH}/test
+
+	# fix host contamination
+	find ${D} -type f -not -executable -exec sed -i 's:${B}:${PTEST_PATH}:' {} \;
 }
 RDEPENDS_${PN}-ptest += "bash"
diff --git a/meta/recipes-core/dbus/dbus_1.10.20.bb b/meta/recipes-core/dbus/dbus_1.10.20.bb
index 9ddedc15fe..2b550a8599 100644
--- a/meta/recipes-core/dbus/dbus_1.10.20.bb
+++ b/meta/recipes-core/dbus/dbus_1.10.20.bb
@@ -91,8 +91,7 @@ pkg_postinst_dbus() {
 	fi
 }
 
-EXTRA_OECONF = "--disable-tests \
-                --disable-xml-docs \
+EXTRA_OECONF = "--disable-xml-docs \
                 --disable-doxygen-docs \
                 --disable-libaudit \
                 --enable-largefile \
@@ -101,10 +100,11 @@ EXTRA_OECONF = "--disable-tests \
 EXTRA_OECONF_append_class-target = " SYSTEMCTL=${base_bindir}/systemctl"
 EXTRA_OECONF_append_class-native = " --disable-selinux"
 
-PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'systemd x11', d)}"
+PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'ptest systemd x11', d)}"
 PACKAGECONFIG_class-native = ""
 PACKAGECONFIG_class-nativesdk = ""
 
+PACKAGECONFIG[ptest] = "--enable-embedded-tests --enable-asserts --enable-verbose-mode,--enable-embedded-tests --disable-asserts --enable-verbose-mode"
 PACKAGECONFIG[systemd] = "--enable-systemd --with-systemdsystemunitdir=${systemd_system_unitdir},--disable-systemd --without-systemdsystemunitdir,systemd"
 PACKAGECONFIG[x11] = "--with-x --enable-x11-autolaunch,--without-x --disable-x11-autolaunch, virtual/libx11 libsm"
 PACKAGECONFIG[user-session] = "--enable-user-session --with-systemduserunitdir=${systemd_user_unitdir},--disable-user-session"
-- 
2.14.1

Re: [PATCH 1/1] dbus: fix ptest runtime failures

[Richard Purdie]

On Mon, 2017-09-04 at 17:39 +0800, kai.kang@windriver.com wrote:
> From: Kai Kang <kai.kang@windriver.com>
> 
> When run dbus ptest cases, there are some failures:
> 
> > 
> > ./test/test-dbus-daemon: relocation error: ./test/test-dbus-daemon: 
> > symbol
> > _dbus_real_assert, version LIBDBUS_PRIVATE_1.10.20 not defined in
> > file
> > libdbus-1.so.3 with link time reference
> > FAIL: test/test-dbus-daemon
> > [   24.943454] test-dbus-daemo[251]: segfault at 0
> > ip           (null) sp
> > 00007ffddabe6818 error 14 in test-dbus-daemon-eavesdrop[
> > 400000+a000]
> It disables tests in dbus recipe which cases symbols missing and
> segment
> fault. When 'ptest' in DISTRO_FEATURES, it should enable some
> configure
> options to make the symbols visible to ptest cases.
> 
> It also need to correct paths in ptest configure files.

Does this have a runtime effect on dbus, i.e. are these runtime asserts
which we don't want in production code?

Cheers,

Richard

Re: [PATCH 1/1] dbus: fix ptest runtime failures

[Kang Kai]

On 2017年09月05日 04:04, Richard Purdie wrote:
> On Mon, 2017-09-04 at 17:39 +0800, kai.kang@windriver.com wrote:
>> From: Kai Kang <kai.kang@windriver.com>
>>
>> When run dbus ptest cases, there are some failures:
>>
>>> ./test/test-dbus-daemon: relocation error: ./test/test-dbus-daemon:
>>> symbol
>>> _dbus_real_assert, version LIBDBUS_PRIVATE_1.10.20 not defined in
>>> file
>>> libdbus-1.so.3 with link time reference
>>> FAIL: test/test-dbus-daemon
>>> [   24.943454] test-dbus-daemo[251]: segfault at 0
>>> ip           (null) sp
>>> 00007ffddabe6818 error 14 in test-dbus-daemon-eavesdrop[
>>> 400000+a000]
>> It disables tests in dbus recipe which cases symbols missing and
>> segment
>> fault. When 'ptest' in DISTRO_FEATURES, it should enable some
>> configure
>> options to make the symbols visible to ptest cases.
>>
>> It also need to correct paths in ptest configure files.
> Does this have a runtime effect on dbus, i.e. are these runtime asserts
> which we don't want in production code?

HI Richard,

I am sorry that did some copy and paste errors for packageconfig ptest. 
It should disable them all if 'ptest' is disabled.
Did that make myself misunderstood?


If not, please:

It gives warnings in configure.ac for enable embedded_tests and asserts:

if test x$enable_embedded_tests = xyes; then
         echo "NOTE: building with unit tests increases the size of the 
installed library and renders it insecure."
fi

if test x$enable_asserts = xyes; then
         echo "NOTE: building with assertions increases library size and 
decreases performance."
fi


It seems true that enable asserts will affect runtime performance. But 
the configure options are required for ptest cases.
Would is it not ok that only enable them when ptest in DISTRO_FEATURES?


I'll send V2 to correct the typos. Sorry for inconvenience.


Regards,
Kai

> Cheers,
>
> Richard
>
>

-- 
Regards,
Neil | Kai Kang

[PATCH V2 0/1] dbus: fix ptest runtime failures

[kai.kang]

From: Kai Kang <kai.kang@windriver.com>

V2:
* Fix typos. It should disable the configure options when ptest is disabled.

The following changes since commit ee5bce2d11e783c0921df47b629025a6b67c44bf:

  kernel-dev: Removed bad reference for creating patches. (2017-09-02 00:52:49 +0100)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib kangkai/dbus
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=kangkai/dbus

Kai Kang (1):
  dbus: fix ptest runtime failures

 meta/recipes-core/dbus/dbus-test_1.10.20.bb | 3 +++
 meta/recipes-core/dbus/dbus_1.10.20.bb      | 6 +++---
 2 files changed, 6 insertions(+), 3 deletions(-)

-- 
2.14.1

[PATCH 1/1] dbus: fix ptest runtime failures

[kai.kang]

From: Kai Kang <kai.kang@windriver.com>

When run dbus ptest cases, there are some failures:

| ./test/test-dbus-daemon: relocation error: ./test/test-dbus-daemon: symbol
| _dbus_real_assert, version LIBDBUS_PRIVATE_1.10.20 not defined in file
| libdbus-1.so.3 with link time reference
| FAIL: test/test-dbus-daemon
| [   24.943454] test-dbus-daemo[251]: segfault at 0 ip           (null) sp
| 00007ffddabe6818 error 14 in test-dbus-daemon-eavesdrop[ 400000+a000]

It disables tests in dbus recipe which cases symbols missing and segment
fault. When 'ptest' in DISTRO_FEATURES, it should enable some configure
options to make the symbols visible to ptest cases.

It also need to correct paths in ptest configure files.

Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
 meta/recipes-core/dbus/dbus-test_1.10.20.bb | 3 +++
 meta/recipes-core/dbus/dbus_1.10.20.bb      | 6 +++---
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/meta/recipes-core/dbus/dbus-test_1.10.20.bb b/meta/recipes-core/dbus/dbus-test_1.10.20.bb
index eeadb7d35b..d50bbc8fd6 100644
--- a/meta/recipes-core/dbus/dbus-test_1.10.20.bb
+++ b/meta/recipes-core/dbus/dbus-test_1.10.20.bb
@@ -54,5 +54,8 @@ do_install_ptest() {
 	for i in $l; do install ${B}/bus/.libs/test-$i ${D}${PTEST_PATH}/test; done
 	install ${B}/dbus/.libs/test-dbus ${D}${PTEST_PATH}/test
 	cp -r ${B}/test/data ${D}${PTEST_PATH}/test
+
+	# fix host contamination
+	find ${D} -type f -not -executable -exec sed -i 's:${B}:${PTEST_PATH}:' {} \;
 }
 RDEPENDS_${PN}-ptest += "bash"
diff --git a/meta/recipes-core/dbus/dbus_1.10.20.bb b/meta/recipes-core/dbus/dbus_1.10.20.bb
index 9ddedc15fe..010fc51946 100644
--- a/meta/recipes-core/dbus/dbus_1.10.20.bb
+++ b/meta/recipes-core/dbus/dbus_1.10.20.bb
@@ -91,8 +91,7 @@ pkg_postinst_dbus() {
 	fi
 }
 
-EXTRA_OECONF = "--disable-tests \
-                --disable-xml-docs \
+EXTRA_OECONF = "--disable-xml-docs \
                 --disable-doxygen-docs \
                 --disable-libaudit \
                 --enable-largefile \
@@ -101,10 +100,11 @@ EXTRA_OECONF = "--disable-tests \
 EXTRA_OECONF_append_class-target = " SYSTEMCTL=${base_bindir}/systemctl"
 EXTRA_OECONF_append_class-native = " --disable-selinux"
 
-PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'systemd x11', d)}"
+PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'ptest systemd x11', d)}"
 PACKAGECONFIG_class-native = ""
 PACKAGECONFIG_class-nativesdk = ""
 
+PACKAGECONFIG[ptest] = "--enable-embedded-tests --enable-asserts --enable-verbose-mode,--disable-embedded-tests --disable-asserts --disable-verbose-mode"
 PACKAGECONFIG[systemd] = "--enable-systemd --with-systemdsystemunitdir=${systemd_system_unitdir},--disable-systemd --without-systemdsystemunitdir,systemd"
 PACKAGECONFIG[x11] = "--with-x --enable-x11-autolaunch,--without-x --disable-x11-autolaunch, virtual/libx11 libsm"
 PACKAGECONFIG[user-session] = "--enable-user-session --with-systemduserunitdir=${systemd_user_unitdir},--disable-user-session"
-- 
2.14.1

Re: [PATCH 1/1] dbus: fix ptest runtime failures

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

On 5 September 2017 at 04:13, <kai.kang@windriver.com> wrote:

> +PACKAGECONFIG[ptest] = "--enable-embedded-tests --enable-asserts
> --enable-verbose-mode,--disable-embedded-tests --disable-asserts
> --disable-verbose-mode"
>

Same question with V2: does enabling ptest change the dbus daemon in ways
that make it slower/less secure/etc.

Ross

[-- Attachment #2: Type: text/html, Size: 694 bytes --]

Re: [PATCH 1/1] dbus: fix ptest runtime failures

[Kang Kai]

[-- Attachment #1: Type: text/plain, Size: 849 bytes --]

On 2017年09月05日 18:01, Burton, Ross wrote:
> On 5 September 2017 at 04:13, <kai.kang@windriver.com 
> <mailto:kai.kang@windriver.com>> wrote:
>
>     +PACKAGECONFIG[ptest] = "--enable-embedded-tests --enable-asserts
>     --enable-verbose-mode,--disable-embedded-tests --disable-asserts
>     --disable-verbose-mode"
>
>
> Same question with V2: does enabling ptest change the dbus daemon in 
> ways that make it slower/less secure/etc.

Unfortunately, yes, it affects performace of dbus-daemon. It checks 
macro DBUS_ENABLE_EMBEDDED_TESTS to add some test codes.
I doubt whether has someone deploy image with ptest feature to 
production environment.

It seems dbus is so fundamental that affect too much. But without them, 
ptest cases can not PASS. Confusing.


--Kai

>
> Ross


-- 
Regards,
Neil | Kai Kang


[-- Attachment #2: Type: text/html, Size: 2260 bytes --]