* [PATCH] package_ipk.bbclass: handle only whitespace in PACKAGE_EXCLUDE
@ 2017-10-25 4:55 Andre McCurdy
2017-11-07 22:34 ` Andre McCurdy
0 siblings, 1 reply; 2+ messages in thread
From: Andre McCurdy @ 2017-10-25 4:55 UTC (permalink / raw)
To: openembedded-core
If PACKAGE_EXCLUDE is constructed using _append then it's possible
that the final value will contain only a space. Currently that
results in build failures due to an invalid opkg command line.
Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
meta/classes/package_ipk.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/package_ipk.bbclass b/meta/classes/package_ipk.bbclass
index 8439cda..6c1fdaa 100644
--- a/meta/classes/package_ipk.bbclass
+++ b/meta/classes/package_ipk.bbclass
@@ -12,7 +12,7 @@ OPKGBUILDCMD ??= "opkg-build"
OPKG_ARGS += "--force_postinstall --prefer-arch-to-version"
OPKG_ARGS += "${@['', '--no-install-recommends'][d.getVar("NO_RECOMMENDATIONS") == "1"]}"
-OPKG_ARGS += "${@['', '--add-exclude ' + ' --add-exclude '.join((d.getVar('PACKAGE_EXCLUDE') or "").split())][(d.getVar("PACKAGE_EXCLUDE") or "") != ""]}"
+OPKG_ARGS += "${@['', '--add-exclude ' + ' --add-exclude '.join((d.getVar('PACKAGE_EXCLUDE') or "").split())][(d.getVar("PACKAGE_EXCLUDE") or "").strip() != ""]}"
OPKGLIBDIR = "${localstatedir}/lib"
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] package_ipk.bbclass: handle only whitespace in PACKAGE_EXCLUDE
2017-10-25 4:55 [PATCH] package_ipk.bbclass: handle only whitespace in PACKAGE_EXCLUDE Andre McCurdy
@ 2017-11-07 22:34 ` Andre McCurdy
0 siblings, 0 replies; 2+ messages in thread
From: Andre McCurdy @ 2017-11-07 22:34 UTC (permalink / raw)
To: OE Core mailing list
On Tue, Oct 24, 2017 at 9:55 PM, Andre McCurdy <armccurdy@gmail.com> wrote:
> If PACKAGE_EXCLUDE is constructed using _append then it's possible
> that the final value will contain only a space. Currently that
> results in build failures due to an invalid opkg command line.
PIng.
> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
> ---
> meta/classes/package_ipk.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/package_ipk.bbclass b/meta/classes/package_ipk.bbclass
> index 8439cda..6c1fdaa 100644
> --- a/meta/classes/package_ipk.bbclass
> +++ b/meta/classes/package_ipk.bbclass
> @@ -12,7 +12,7 @@ OPKGBUILDCMD ??= "opkg-build"
>
> OPKG_ARGS += "--force_postinstall --prefer-arch-to-version"
> OPKG_ARGS += "${@['', '--no-install-recommends'][d.getVar("NO_RECOMMENDATIONS") == "1"]}"
> -OPKG_ARGS += "${@['', '--add-exclude ' + ' --add-exclude '.join((d.getVar('PACKAGE_EXCLUDE') or "").split())][(d.getVar("PACKAGE_EXCLUDE") or "") != ""]}"
> +OPKG_ARGS += "${@['', '--add-exclude ' + ' --add-exclude '.join((d.getVar('PACKAGE_EXCLUDE') or "").split())][(d.getVar("PACKAGE_EXCLUDE") or "").strip() != ""]}"
>
> OPKGLIBDIR = "${localstatedir}/lib"
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-07 22:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-25 4:55 [PATCH] package_ipk.bbclass: handle only whitespace in PACKAGE_EXCLUDE Andre McCurdy
2017-11-07 22:34 ` Andre McCurdy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox