Re: [PATCH] kernel.bbclass: Add cleandirs for do_shared_workdir

[Saul Wold <sgw@linux.intel.com>]

On Wed, 2017-11-22 at 15:51 -0500, Bruce Ashfield wrote:
> On 2017-11-22 1:47 PM, Saul Wold wrote:
> > Ensure we have a clean and empty STAGING_KERNEL_BUILDDIR (kernel-
> > build-artifacts)
> > before creating it, otherwise there might be older artifacts from a
> > prior
> > kernel build.
> > 
> 
> What's the actual error that this triggers ? It would be nice to
> log it here in the commit message .. or at least a description
> of the symptoms.
> 
As refered to in the bug, there is not an actual error occurs, but
there are multiple older and non-appropriate (read older) artifacts
remaining in the kernel-build-artifacts directory, just as the commit
message describes.

Sau!

> > [YOCTO #11880]
> > 
> > Signed-off-by: Saul Wold <sgw@linux.intel.com>
> > ---
> >   meta/classes/kernel.bbclass | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/meta/classes/kernel.bbclass
> > b/meta/classes/kernel.bbclass
> > index 756707a3c25..2a0a7707a14 100644
> > --- a/meta/classes/kernel.bbclass
> > +++ b/meta/classes/kernel.bbclass
> > @@ -400,6 +400,7 @@ emit_depmod_pkgdata() {
> >   
> >   PACKAGEFUNCS += "emit_depmod_pkgdata"
> >   
> > +do_shared_workdir[cleandirs] += " ${STAGING_KERNEL_BUILDDIR}"
> >   do_shared_workdir () {
> >   	cd ${B}
> >   
> > @@ -655,8 +656,6 @@ kernel_do_deploy() {
> >   		fi
> >   	done
> >   }
> > -do_deploy[cleandirs] = "${DEPLOYDIR}"
> > -do_deploy[dirs] = "${DEPLOYDIR} ${B}"
> 
> This isn't clear to me. Why does cleaning the STAGING_KERNEL_BUILDDIR
> as part of the do_shared_workdir mean that we no longer need the
> clean before the deploy (as well as the deploy dir).
> 
> Bruce
> 
> >   do_deploy[prefuncs] += "package_get_auto_pr"
> >   
> >   addtask deploy after do_populate_sysroot do_packagedata
> > 
> 
>