* [PATCH] kernel.bbclass: Add cleandirs for do_shared_workdir @ 2017-11-22 18:47 Saul Wold 2017-11-22 20:51 ` Bruce Ashfield 0 siblings, 1 reply; 6+ messages in thread From: Saul Wold @ 2017-11-22 18:47 UTC (permalink / raw) To: openembedded-core, richard.purdie, bruce.ashfield Ensure we have a clean and empty STAGING_KERNEL_BUILDDIR (kernel-build-artifacts) before creating it, otherwise there might be older artifacts from a prior kernel build. [YOCTO #11880] Signed-off-by: Saul Wold <sgw@linux.intel.com> --- meta/classes/kernel.bbclass | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass index 756707a3c25..2a0a7707a14 100644 --- a/meta/classes/kernel.bbclass +++ b/meta/classes/kernel.bbclass @@ -400,6 +400,7 @@ emit_depmod_pkgdata() { PACKAGEFUNCS += "emit_depmod_pkgdata" +do_shared_workdir[cleandirs] += " ${STAGING_KERNEL_BUILDDIR}" do_shared_workdir () { cd ${B} @@ -655,8 +656,6 @@ kernel_do_deploy() { fi done } -do_deploy[cleandirs] = "${DEPLOYDIR}" -do_deploy[dirs] = "${DEPLOYDIR} ${B}" do_deploy[prefuncs] += "package_get_auto_pr" addtask deploy after do_populate_sysroot do_packagedata -- 2.13.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] kernel.bbclass: Add cleandirs for do_shared_workdir 2017-11-22 18:47 [PATCH] kernel.bbclass: Add cleandirs for do_shared_workdir Saul Wold @ 2017-11-22 20:51 ` Bruce Ashfield 2017-11-26 22:44 ` Saul Wold 0 siblings, 1 reply; 6+ messages in thread From: Bruce Ashfield @ 2017-11-22 20:51 UTC (permalink / raw) To: Saul Wold, openembedded-core, richard.purdie On 2017-11-22 1:47 PM, Saul Wold wrote: > Ensure we have a clean and empty STAGING_KERNEL_BUILDDIR (kernel-build-artifacts) > before creating it, otherwise there might be older artifacts from a prior > kernel build. > What's the actual error that this triggers ? It would be nice to log it here in the commit message .. or at least a description of the symptoms. > [YOCTO #11880] > > Signed-off-by: Saul Wold <sgw@linux.intel.com> > --- > meta/classes/kernel.bbclass | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass > index 756707a3c25..2a0a7707a14 100644 > --- a/meta/classes/kernel.bbclass > +++ b/meta/classes/kernel.bbclass > @@ -400,6 +400,7 @@ emit_depmod_pkgdata() { > > PACKAGEFUNCS += "emit_depmod_pkgdata" > > +do_shared_workdir[cleandirs] += " ${STAGING_KERNEL_BUILDDIR}" > do_shared_workdir () { > cd ${B} > > @@ -655,8 +656,6 @@ kernel_do_deploy() { > fi > done > } > -do_deploy[cleandirs] = "${DEPLOYDIR}" > -do_deploy[dirs] = "${DEPLOYDIR} ${B}" This isn't clear to me. Why does cleaning the STAGING_KERNEL_BUILDDIR as part of the do_shared_workdir mean that we no longer need the clean before the deploy (as well as the deploy dir). Bruce > do_deploy[prefuncs] += "package_get_auto_pr" > > addtask deploy after do_populate_sysroot do_packagedata > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kernel.bbclass: Add cleandirs for do_shared_workdir 2017-11-22 20:51 ` Bruce Ashfield @ 2017-11-26 22:44 ` Saul Wold 2017-11-27 4:52 ` Bruce Ashfield 0 siblings, 1 reply; 6+ messages in thread From: Saul Wold @ 2017-11-26 22:44 UTC (permalink / raw) To: Bruce Ashfield, openembedded-core, richard.purdie On Wed, 2017-11-22 at 15:51 -0500, Bruce Ashfield wrote: > On 2017-11-22 1:47 PM, Saul Wold wrote: > > Ensure we have a clean and empty STAGING_KERNEL_BUILDDIR (kernel- > > build-artifacts) > > before creating it, otherwise there might be older artifacts from a > > prior > > kernel build. > > > > What's the actual error that this triggers ? It would be nice to > log it here in the commit message .. or at least a description > of the symptoms. > As refered to in the bug, there is not an actual error occurs, but there are multiple older and non-appropriate (read older) artifacts remaining in the kernel-build-artifacts directory, just as the commit message describes. Sau! > > [YOCTO #11880] > > > > Signed-off-by: Saul Wold <sgw@linux.intel.com> > > --- > > meta/classes/kernel.bbclass | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/meta/classes/kernel.bbclass > > b/meta/classes/kernel.bbclass > > index 756707a3c25..2a0a7707a14 100644 > > --- a/meta/classes/kernel.bbclass > > +++ b/meta/classes/kernel.bbclass > > @@ -400,6 +400,7 @@ emit_depmod_pkgdata() { > > > > PACKAGEFUNCS += "emit_depmod_pkgdata" > > > > +do_shared_workdir[cleandirs] += " ${STAGING_KERNEL_BUILDDIR}" > > do_shared_workdir () { > > cd ${B} > > > > @@ -655,8 +656,6 @@ kernel_do_deploy() { > > fi > > done > > } > > -do_deploy[cleandirs] = "${DEPLOYDIR}" > > -do_deploy[dirs] = "${DEPLOYDIR} ${B}" > > This isn't clear to me. Why does cleaning the STAGING_KERNEL_BUILDDIR > as part of the do_shared_workdir mean that we no longer need the > clean before the deploy (as well as the deploy dir). > > Bruce > > > do_deploy[prefuncs] += "package_get_auto_pr" > > > > addtask deploy after do_populate_sysroot do_packagedata > > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kernel.bbclass: Add cleandirs for do_shared_workdir 2017-11-26 22:44 ` Saul Wold @ 2017-11-27 4:52 ` Bruce Ashfield 2017-11-27 13:35 ` Bruce Ashfield 0 siblings, 1 reply; 6+ messages in thread From: Bruce Ashfield @ 2017-11-27 4:52 UTC (permalink / raw) To: Saul Wold; +Cc: Patches and discussions about the oe-core layer [-- Attachment #1: Type: text/plain, Size: 2794 bytes --] On Sun, Nov 26, 2017 at 5:44 PM, Saul Wold <sgw@linux.intel.com> wrote: > On Wed, 2017-11-22 at 15:51 -0500, Bruce Ashfield wrote: > > On 2017-11-22 1:47 PM, Saul Wold wrote: > > > Ensure we have a clean and empty STAGING_KERNEL_BUILDDIR (kernel- > > > build-artifacts) > > > before creating it, otherwise there might be older artifacts from a > > > prior > > > kernel build. > > > > > > > What's the actual error that this triggers ? It would be nice to > > log it here in the commit message .. or at least a description > > of the symptoms. > > > As refered to in the bug, there is not an actual error occurs, but > there are multiple older and non-appropriate (read older) artifacts > remaining in the kernel-build-artifacts directory, just as the commit > message describes. > Quoting a bug isn't useful .. everything that someone needs to know *must* be in a commit message. I'm not clicking through later on when doing a 'git whatchanged', and I may not even be online at that time .. so that bug reference just isn't useful. So the old artifacts remain .. is it a disk usage question ? Is it a possible confusion when inspecting a build ? .. All that the message does is describe the change, not the why. Bruce > > Sau! > > > > [YOCTO #11880] > > > > > > Signed-off-by: Saul Wold <sgw@linux.intel.com> > > > --- > > > meta/classes/kernel.bbclass | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/meta/classes/kernel.bbclass > > > b/meta/classes/kernel.bbclass > > > index 756707a3c25..2a0a7707a14 100644 > > > --- a/meta/classes/kernel.bbclass > > > +++ b/meta/classes/kernel.bbclass > > > @@ -400,6 +400,7 @@ emit_depmod_pkgdata() { > > > > > > PACKAGEFUNCS += "emit_depmod_pkgdata" > > > > > > +do_shared_workdir[cleandirs] += " ${STAGING_KERNEL_BUILDDIR}" > > > do_shared_workdir () { > > > cd ${B} > > > > > > @@ -655,8 +656,6 @@ kernel_do_deploy() { > > > fi > > > done > > > } > > > -do_deploy[cleandirs] = "${DEPLOYDIR}" > > > -do_deploy[dirs] = "${DEPLOYDIR} ${B}" > > > > This isn't clear to me. Why does cleaning the STAGING_KERNEL_BUILDDIR > > as part of the do_shared_workdir mean that we no longer need the > > clean before the deploy (as well as the deploy dir). > > > > Bruce > > > > > do_deploy[prefuncs] += "package_get_auto_pr" > > > > > > addtask deploy after do_populate_sysroot do_packagedata > > > > > > > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core > -- "Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end" [-- Attachment #2: Type: text/html, Size: 4246 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kernel.bbclass: Add cleandirs for do_shared_workdir 2017-11-27 4:52 ` Bruce Ashfield @ 2017-11-27 13:35 ` Bruce Ashfield 2017-11-27 18:38 ` Saul Wold 0 siblings, 1 reply; 6+ messages in thread From: Bruce Ashfield @ 2017-11-27 13:35 UTC (permalink / raw) To: Saul Wold; +Cc: Patches and discussions about the oe-core layer [-- Attachment #1: Type: text/plain, Size: 3473 bytes --] On Sun, Nov 26, 2017 at 11:52 PM, Bruce Ashfield <bruce.ashfield@gmail.com> wrote: > > > On Sun, Nov 26, 2017 at 5:44 PM, Saul Wold <sgw@linux.intel.com> wrote: > >> On Wed, 2017-11-22 at 15:51 -0500, Bruce Ashfield wrote: >> > On 2017-11-22 1:47 PM, Saul Wold wrote: >> > > Ensure we have a clean and empty STAGING_KERNEL_BUILDDIR (kernel- >> > > build-artifacts) >> > > before creating it, otherwise there might be older artifacts from a >> > > prior >> > > kernel build. >> > > >> > >> > What's the actual error that this triggers ? It would be nice to >> > log it here in the commit message .. or at least a description >> > of the symptoms. >> > >> As refered to in the bug, there is not an actual error occurs, but >> there are multiple older and non-appropriate (read older) artifacts >> remaining in the kernel-build-artifacts directory, just as the commit >> message describes. >> > > Quoting a bug isn't useful .. everything that someone needs to know > *must* be in a commit message. I'm not clicking through later on > when doing a 'git whatchanged', and I may not even be online at > that time .. so that bug reference just isn't useful. > > So the old artifacts remain .. is it a disk usage question ? Is it a > possible > confusion when inspecting a build ? .. All that the message does is > describe the change, not the why. > > I should have highlighted my real question, change log semantics and nitpicking are just noise :D See below in the double quoted reply. > Bruce > > > >> >> Sau! >> >> > > [YOCTO #11880] >> > > >> > > Signed-off-by: Saul Wold <sgw@linux.intel.com> >> > > --- >> > > meta/classes/kernel.bbclass | 3 +-- >> > > 1 file changed, 1 insertion(+), 2 deletions(-) >> > > >> > > diff --git a/meta/classes/kernel.bbclass >> > > b/meta/classes/kernel.bbclass >> > > index 756707a3c25..2a0a7707a14 100644 >> > > --- a/meta/classes/kernel.bbclass >> > > +++ b/meta/classes/kernel.bbclass >> > > @@ -400,6 +400,7 @@ emit_depmod_pkgdata() { >> > > >> > > PACKAGEFUNCS += "emit_depmod_pkgdata" >> > > >> > > +do_shared_workdir[cleandirs] += " ${STAGING_KERNEL_BUILDDIR}" >> > > do_shared_workdir () { >> > > cd ${B} >> > > >> > > @@ -655,8 +656,6 @@ kernel_do_deploy() { >> > > fi >> > > done >> > > } >> > > -do_deploy[cleandirs] = "${DEPLOYDIR}" >> > > -do_deploy[dirs] = "${DEPLOYDIR} ${B}" >> > >> > This isn't clear to me. Why does cleaning the STAGING_KERNEL_BUILDDIR >> > as part of the do_shared_workdir mean that we no longer need the >> > clean before the deploy (as well as the deploy dir). >> > >> > It was this that was the real part of the question. The removal of these cleandirs didn't seem to be directly replaced by the new method. Is it that the DEPLOYDIR and STAGING_KERNEL_BUILDDIR are the same thing ? Bruce > > Bruce >> > >> > > do_deploy[prefuncs] += "package_get_auto_pr" >> > > >> > > addtask deploy after do_populate_sysroot do_packagedata >> > > >> > >> > >> -- >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-core >> > > > > -- > "Thou shalt not follow the NULL pointer, for chaos and madness await thee > at its end" > -- "Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end" [-- Attachment #2: Type: text/html, Size: 6293 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kernel.bbclass: Add cleandirs for do_shared_workdir 2017-11-27 13:35 ` Bruce Ashfield @ 2017-11-27 18:38 ` Saul Wold 0 siblings, 0 replies; 6+ messages in thread From: Saul Wold @ 2017-11-27 18:38 UTC (permalink / raw) To: Bruce Ashfield; +Cc: Patches and discussions about the oe-core layer On Mon, 2017-11-27 at 08:35 -0500, Bruce Ashfield wrote: > > > On Sun, Nov 26, 2017 at 11:52 PM, Bruce Ashfield <bruce.ashfield@gmai > l.com> wrote: > > > > On Sun, Nov 26, 2017 at 5:44 PM, Saul Wold <sgw@linux.intel.com> > > wrote: > > > On Wed, 2017-11-22 at 15:51 -0500, Bruce Ashfield wrote: > > > > On 2017-11-22 1:47 PM, Saul Wold wrote: > > > > > Ensure we have a clean and empty STAGING_KERNEL_BUILDDIR > > > (kernel- > > > > > build-artifacts) > > > > > before creating it, otherwise there might be older artifacts > > > from a > > > > > prior > > > > > kernel build. > > > > > > > > > > > > > What's the actual error that this triggers ? It would be nice > > > to > > > > log it here in the commit message .. or at least a description > > > > of the symptoms. > > > > > > > As refered to in the bug, there is not an actual error occurs, > > > but > > > there are multiple older and non-appropriate (read older) > > > artifacts > > > remaining in the kernel-build-artifacts directory, just as the > > > commit > > > message describes. > > > > Quoting a bug isn't useful .. everything that someone needs to > > know > > *must* be in a commit message. I'm not clicking through later on > > when doing a 'git whatchanged', and I may not even be online at > > that time .. so that bug reference just isn't useful. > > > > So the old artifacts remain .. is it a disk usage question ? Is it > > a possible > > confusion when inspecting a build ? .. All that the message does is > > describe the change, not the why. > > > > > > I should have highlighted my real question, change log semantics and > nitpicking are just noise :D See below in the double quoted reply. > Sorry, I missed the real question! > > Bruce > > > > > > > Sau! > > > > > > > > [YOCTO #11880] > > > > > > > > > > Signed-off-by: Saul Wold <sgw@linux.intel.com> > > > > > --- > > > > > meta/classes/kernel.bbclass | 3 +-- > > > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > > > > > diff --git a/meta/classes/kernel.bbclass > > > > > b/meta/classes/kernel.bbclass > > > > > index 756707a3c25..2a0a7707a14 100644 > > > > > --- a/meta/classes/kernel.bbclass > > > > > +++ b/meta/classes/kernel.bbclass > > > > > @@ -400,6 +400,7 @@ emit_depmod_pkgdata() { > > > > > > > > > > PACKAGEFUNCS += "emit_depmod_pkgdata" > > > > > > > > > > +do_shared_workdir[cleandirs] += " > > > ${STAGING_KERNEL_BUILDDIR}" > > > > > do_shared_workdir () { > > > > > cd ${B} > > > > > > > > > > @@ -655,8 +656,6 @@ kernel_do_deploy() { > > > > > fi > > > > > done > > > > > } > > > > > -do_deploy[cleandirs] = "${DEPLOYDIR}" > > > > > -do_deploy[dirs] = "${DEPLOYDIR} ${B}" > > > > > > > > This isn't clear to me. Why does cleaning the > > > STAGING_KERNEL_BUILDDIR > > > > as part of the do_shared_workdir mean that we no longer need > > > the > > > > clean before the deploy (as well as the deploy dir). > > > > > > > It was this that was the real part of the question. The removal of > these cleandirs > didn't seem to be directly replaced by the new method. Is it that the > DEPLOYDIR > and STAGING_KERNEL_BUILDDIR are the same thing ? > Yeah, oops, those where not meant to be removed, not sure what happened or why I missed it on review. Sau! > Bruce > > > > > Bruce > > > > > > > > > do_deploy[prefuncs] += "package_get_auto_pr" > > > > > > > > > > addtask deploy after do_populate_sysroot do_packagedata > > > > > > > > > > > > > > > > -- > > > _______________________________________________ > > > Openembedded-core mailing list > > > Openembedded-core@lists.openembedded.org > > > http://lists.openembedded.org/mailman/listinfo/openembedded-core > > > > > > > > -- > > "Thou shalt not follow the NULL pointer, for chaos and madness > > await thee at its end" > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-27 18:38 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-11-22 18:47 [PATCH] kernel.bbclass: Add cleandirs for do_shared_workdir Saul Wold 2017-11-22 20:51 ` Bruce Ashfield 2017-11-26 22:44 ` Saul Wold 2017-11-27 4:52 ` Bruce Ashfield 2017-11-27 13:35 ` Bruce Ashfield 2017-11-27 18:38 ` Saul Wold
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox