From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 3/3] apr: fix incorrect size of pid_t
Date: Fri, 29 Jun 2012 11:50:33 +0100 [thread overview]
Message-ID: <1515296.CLmyHfUsyt@helios> (raw)
In-Reply-To: <4FED1743.4050203@gmail.com>
On Thursday 28 June 2012 19:47:31 Khem Raj wrote:
> I think this may not be correct thing for 64bit targets. You are
> better of adding this to appropriate site files.
pid_t is apparently always an int on Linux and our siteinfo files state that
ac_cv_sizeof_int is 4 for every target. Nevertheless, if we see the need to
define ac_cv_sizeof_int even though the value isn't currently different
anywhere, it seems at least consistent to set ac_cv_sizeof_pid_t there as
well.
However, I can't help feeling that these files are a bit of a mess and it's not
totally clear to me where I should be putting this value. Should it go in
common-linux? Or do I have to add it to the specific site file for every arch?
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-06-29 11:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 18:29 [PATCH 0/3] apr fixes Paul Eggleton
2012-06-28 18:29 ` [PATCH 1/3] apr: Install apr-local libtool in build dir Paul Eggleton
2012-06-28 18:29 ` [PATCH 2/3] apr: add util-linux to DEPENDS for libuuid Paul Eggleton
2012-06-29 2:48 ` Khem Raj
2012-06-29 10:03 ` Paul Eggleton
2012-06-28 18:29 ` [PATCH 3/3] apr: fix incorrect size of pid_t Paul Eggleton
2012-06-29 2:47 ` Khem Raj
2012-06-29 10:50 ` Paul Eggleton [this message]
2012-06-29 11:33 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515296.CLmyHfUsyt@helios \
--to=paul.eggleton@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox