Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Cc: Paul Eggleton <paul.eggleton@linux.intel.com>
Subject: Re: [PATCH 3/3] apr: fix incorrect size of pid_t
Date: Thu, 28 Jun 2012 19:47:31 -0700	[thread overview]
Message-ID: <4FED1743.4050203@gmail.com> (raw)
In-Reply-To: <1fb664d76463830cf80997e2e13891adfff7a6eb.1340908084.git.paul.eggleton@linux.intel.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 6/28/2012 11:29 AM, Paul Eggleton wrote:
> If cross-compiling, apr's configure script assumes that pid_t is 
> 64-bit which is wrong - it appears that 32-bit is a safe
> assumption for Linux, so use that instead.
> 
> This fixes Apache writing garbage to its pid file when built using
> apr produced from this recipe.
> 
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> --- 
> meta/recipes-support/apr/apr_1.4.6.bb |    4 +++- 1 file changed, 3
> insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-support/apr/apr_1.4.6.bb
> b/meta/recipes-support/apr/apr_1.4.6.bb index 54c47fe..8af5411
> 100644 --- a/meta/recipes-support/apr/apr_1.4.6.bb +++
> b/meta/recipes-support/apr/apr_1.4.6.bb @@ -9,7 +9,7 @@
> LIC_FILES_CHKSUM =
> "file://LICENSE;md5=0c35ff3c4c83b89d2f076e315caac28b \
> 
> BBCLASSEXTEND = "native"
> 
> -PR = "r0" +PR = "r1"
> 
> SRC_URI = "${APACHE_MIRROR}/apr/${BPN}-${PV}.tar.bz2 \ 
> file://configure_fixes.patch \ @@ -23,6 +23,8 @@ inherit autotools
> lib_package binconfig multilib_header
> 
> OE_BINCONFIG_EXTRA_MANGLE = " -e
> 's:location=source:location=installed:'"
> 
> +EXTRA_OECONF_append_class-target = " ac_cv_sizeof_pid_t=4" +

I think this may not be correct thing for 64bit targets. You are
better of adding this to appropriate site files.


> do_configure_prepend() { cd ${S} ./buildconf
> 


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk/tF0MACgkQuwUzVZGdMxSXNACfUhw2qkbBYBL/mBIvJ5zwIla7
ojoAoICsjsBSRzJlS7s6Qg3i8Ze+NBQo
=yxut
-----END PGP SIGNATURE-----



  reply	other threads:[~2012-06-29  2:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-28 18:29 [PATCH 0/3] apr fixes Paul Eggleton
2012-06-28 18:29 ` [PATCH 1/3] apr: Install apr-local libtool in build dir Paul Eggleton
2012-06-28 18:29 ` [PATCH 2/3] apr: add util-linux to DEPENDS for libuuid Paul Eggleton
2012-06-29  2:48   ` Khem Raj
2012-06-29 10:03     ` Paul Eggleton
2012-06-28 18:29 ` [PATCH 3/3] apr: fix incorrect size of pid_t Paul Eggleton
2012-06-29  2:47   ` Khem Raj [this message]
2012-06-29 10:50     ` Paul Eggleton
2012-06-29 11:33       ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FED1743.4050203@gmail.com \
    --to=raj.khem@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox