recipe using environment variable does not refresh / rebuild

recipe using environment variable does not refresh / rebuild

[Piotr Lewicki]

Hi,

I have a problem with forcing rebuild of the recipe depending on the 
environment variable.

In my recipe I have an anonymous python function that obtains the env 
variable and depending on it sets some other internal variables (needed 
by swupdate recipe):


python() {
     origenv = d.getVar("BB_ORIGENV", False)
     u_boot_enabled = origenv.getVar("ADD_UBOOT_TO_UPDATE", False)

     if u_boot_enabled == None:
         bb.warn("Not adding u-boot to the image")
     else:
         bb.warn("Adding u-boot to the image")
         d.appendVar("SWUPDATE_IMAGES", " u-boot.imx")
         d.setVarFlag("SWUPDATE_IMAGES_NOAPPEND_MACHINE", "u-boot.imx", "1")
}


My issue is that there is no difference when I either set or unset my 
environment variable "ADD_UBOOT_TO_UPDATE".


Can you point me a solution how I could force checking this variable and 
rerunning/rebuilding the recipe?


Thanks,

Piotr

Re: recipe using environment variable does not refresh / rebuild

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 1102 bytes --]

On 1 February 2018 at 14:46, Piotr Lewicki <piotr.lewicki@elfin.de> wrote:

> Hi,
>
> I have a problem with forcing rebuild of the recipe depending on the
> environment variable.
>
> In my recipe I have an anonymous python function that obtains the env
> variable and depending on it sets some other internal variables (needed by
> swupdate recipe):
>
>
> python() {
>     origenv = d.getVar("BB_ORIGENV", False)
>     u_boot_enabled = origenv.getVar("ADD_UBOOT_TO_UPDATE", False)
>
>     if u_boot_enabled == None:
>         bb.warn("Not adding u-boot to the image")
>     else:
>         bb.warn("Adding u-boot to the image")
>         d.appendVar("SWUPDATE_IMAGES", " u-boot.imx")
>         d.setVarFlag("SWUPDATE_IMAGES_NOAPPEND_MACHINE", "u-boot.imx",
> "1")
> }
>
>
> My issue is that there is no difference when I either set or unset my
> environment variable "ADD_UBOOT_TO_UPDATE".
>
>
> Can you point me a solution how I could force checking this variable and
> rerunning/rebuilding the recipe?
>

Can't you use a variable set in local.conf instead?

Ross

[-- Attachment #2: Type: text/html, Size: 1625 bytes --]

Re: recipe using environment variable does not refresh / rebuild

[Piotr Lewicki]

[-- Attachment #1: Type: text/plain, Size: 1848 bytes --]

Hi Ross,

Good idea, but I'm using gitlab to perform autobuilds and I want to set 
the variable there (the "ADD_UBOOT_TO_UPDATE" variable) so that it's 
propagated to the image recipe.

I'm want to differentiate the image with and without u-boot only by 
setting this one environment variable and without additional mangling 
with local.conf.


If that's not possible- I'll use your idea with setting it in 
local.conf, but before that I'm trying to understand- why my recipe is 
not rebuilt?


Thanks,

Piotr


On 01.02.2018 15:50, Burton, Ross wrote:
> On 1 February 2018 at 14:46, Piotr Lewicki <piotr.lewicki@elfin.de 
> <mailto:piotr.lewicki@elfin.de>> wrote:
>
>     Hi,
>
>     I have a problem with forcing rebuild of the recipe depending on
>     the environment variable.
>
>     In my recipe I have an anonymous python function that obtains the
>     env variable and depending on it sets some other internal
>     variables (needed by swupdate recipe):
>
>
>     python() {
>         origenv = d.getVar("BB_ORIGENV", False)
>         u_boot_enabled = origenv.getVar("ADD_UBOOT_TO_UPDATE", False)
>
>         if u_boot_enabled == None:
>             bb.warn("Not adding u-boot to the image")
>         else:
>             bb.warn("Adding u-boot to the image")
>             d.appendVar("SWUPDATE_IMAGES", " u-boot.imx")
>             d.setVarFlag("SWUPDATE_IMAGES_NOAPPEND_MACHINE",
>     "u-boot.imx", "1")
>     }
>
>
>     My issue is that there is no difference when I either set or unset
>     my environment variable "ADD_UBOOT_TO_UPDATE".
>
>
>     Can you point me a solution how I could force checking this
>     variable and rerunning/rebuilding the recipe?
>
>
> Can't you use a variable set in local.conf instead?
>
> Ross


[-- Attachment #2: Type: text/html, Size: 3267 bytes --]

Re: recipe using environment variable does not refresh / rebuild

[Richard Purdie]

On Thu, 2018-02-01 at 16:00 +0100, Piotr Lewicki wrote:
> Hi Ross,
> Good idea, but I'm using gitlab to perform autobuilds and I want to
> set the variable there (the "ADD_UBOOT_TO_UPDATE" variable) so that
> it's propagated to the image recipe.
> I'm want to differentiate the image with and without u-boot only by
> setting this one environment variable and without additional mangling
> with local.conf.
> 
> If that's not possible- I'll use your idea with setting it in
> local.conf, but before that I'm trying to understand- why my recipe
> is not rebuilt?

It isn't rebuilt as bitbake isn't psychic!

Bitbake doesn't understand what anonymous python fragments do, so it
can't know that ADD_UBOOT_TO_UPDATE is being changed.

I have a suspicion that it might rebuild, *if* it knew it had to
reparse the recipe since it probably does know which tasks use that
variable. It doesn't know you're poking into BB_ORIGENV which you
really shouldn't be doing.

To make this work as you'd want, you could add ADD_UBOOT_TO_UPDATE to
BB_PRESERVE_ENV. That might be enough to cause it to re-parse each time
you change the value and in turn, if the tasks change based on that,
they might rebuild. I'd at least start there (and stop poking into
BB_ORIGENV).

Cheers,

Richard